From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG?] If true-color is used, overlapping colors do not work
Date: Fri, 9 Nov 2018 16:39:14 +0100 [thread overview]
Message-ID: <CAKc7PVAonAmJozdiv23NwxcqRj6OhcyZ95NaetcpUJ8NooMWQg@mail.gmail.com> (raw)
In-Reply-To: <20626-1541726901.821000@xGvJ.shtD.SkCN>
On Fri, 9 Nov 2018 at 02:28, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
>
> Sebastian Gniazdowski wrote:
> > I've applied the patch and recompiled, and the tests or the Ctrl-a
> > (with Src/zsh -fi) snippet show now change?
>
> Working through each of your tests manually, they all seem to work fine
> for me if judged purely on the basis of what I see in a terminal. I've
> checked more than one terminal programme including ones with and without
> true colour support.
Ah I've applied only the black color patch, with also the first patch,
everything works fine.
> I get differences before the tests even reach the final buffer state. The
> fact that all the setup lines get repeated back in the test output
> really isn't helping the matter. The differences are all escape
> sequences which diff is not showing, e.g 1b 5b 6d occurring at the start
> of each line. There are also further differences that can be put down to a
> difference of termcap definition. The only hope would be to strip the output
> down to just the section actually being tested (which comptest manages),
> also using something like:
> zle_highlight=( fg_start_code:FGSTART fg_end_code:FGEND fg_default_code:FGDEF )
> and perhaps zle -T somehow to map escape sequences to something readable
> somehow contriving to set TERM to something that claims 256 colour support.
> And, only relying on the portable subset of sed syntax.
> It's not without reason that I was too lazy to attempt this in the first
> place.
I'm stripping down the escape codes that Zsh/Zle normally produces
managing output. It appears that your setup generates some additional
codes. This should be only a matter of altering // substitution and
sed invocation, but maybe your right, maybe updating zle_highlight /
fg_start_code / fg_end_code is the right way.
--
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
next prev parent reply other threads:[~2018-11-09 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:19 Sebastian Gniazdowski
2018-11-07 14:40 ` Sebastian Gniazdowski
2018-11-07 19:19 ` Sebastian Gniazdowski
2018-11-08 3:48 ` Oliver Kiddle
2018-11-08 9:25 ` Sebastian Gniazdowski
2018-11-08 3:03 ` Oliver Kiddle
2018-11-08 9:19 ` Sebastian Gniazdowski
2018-11-09 1:28 ` Oliver Kiddle
2018-11-09 15:39 ` Sebastian Gniazdowski [this message]
2018-11-11 0:43 ` Sebastian Gniazdowski
2018-11-11 5:11 ` Sebastian Gniazdowski
2018-11-24 17:32 ` highlight test cases (was Re: [BUG?] If true-color is used, overlapping colors do not work) Oliver Kiddle
2018-11-30 0:34 ` Sebastian Gniazdowski
2018-12-07 1:55 ` [BUG] General 256 colors bug – zle_highlight / fg_start_code, etc. is not respected (was: highlight test cases) Sebastian Gniazdowski
2018-12-07 20:26 ` Sebastian Gniazdowski
2018-12-09 19:13 ` Daniel Shahaf
2018-12-11 8:06 ` Sebastian Gniazdowski
2018-12-10 2:54 ` highlight test cases (was Re: [BUG?] If true-color is used, overlapping colors do not work) Oliver Kiddle
2018-12-10 23:51 ` Sebastian Gniazdowski
2018-12-10 23:54 ` Sebastian Gniazdowski
2018-11-11 5:38 ` X04 zle highlight tests, near-color bug Sebastian Gniazdowski
2018-11-18 15:34 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKc7PVAonAmJozdiv23NwxcqRj6OhcyZ95NaetcpUJ8NooMWQg@mail.gmail.com \
--to=sgniazdowski@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).