From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id cb592be1 for ; Fri, 9 Nov 2018 15:39:46 +0000 (UTC) Received: (qmail 5638 invoked by alias); 9 Nov 2018 15:39:33 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43810 Received: (qmail 12477 invoked by uid 1010); 9 Nov 2018 15:39:32 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi1-f182.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.167.182):SA:0(-2.0/5.0):. Processed in 3.08858 secs); 09 Nov 2018 15:39:32 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qZNLqLKB5g3SSZTXwnky5IGtUJ6lNa+AyuSGuSyOO4c=; b=G9V8QNW4oob8cXc/f59HRrTxN2CtRBo2u7v3hZCnT1Zoylji0ccc8EFSoYgfe4Cp+a +PThRQOuA4kMd96j4VYKzqK4ICNMdvLJFzHvaBeH/0BwFmQcUlXp76TQqKynOdXdTi6Z lp4LPgoIMlG6x50us63l6iJd1Ta46l0/DZBTL+dV9mlerAvKyXtfE6TB3dIjho/DeUEI fIvPKx9/mKav2zYZw7TaqLWto1ERyNYMSZD0GmV+Veo8dmXWOFfCa4RtJgfsDSszivtY 1c7QiZgWqGRgJ3to+In/GLVQWeY3euCL8IiVPLYmk6Z2d1tOJuj40UJt8lHn6pVwd/iK pxDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qZNLqLKB5g3SSZTXwnky5IGtUJ6lNa+AyuSGuSyOO4c=; b=RR0hgVDeN+bgMZJPwN/MmSNW3kUS4+BzQ3f7c4eCQ3DyU0fT88zxtMhFqb+DmHOxaR krN352G17csmqHQyAhFgAV7osDt3ewWaJTjS2oPkgwdWy1rhyKbIchiOzpRbsIFwfGVT Sesy+j1ogaDA/aj1Fd8/TOJVRcohLGrhzsIof/iKK20I4duRKSQqkFq512NBlTF1LENk yLsgNuhAcYCirCAXllP0/cMcnUvDn8pKSLUYrO9tezuUiSnbv4rIbsNW+E/oiwZTbDw2 HnXoblgEA8uzWL/HyXq3D/geW67AlUnEKfogfIr/rwLwGOxdTKpsk0xbktC8IAN2dfSQ 2R6A== X-Gm-Message-State: AGRZ1gKahy/9ZUmteLCAapEw3RDJKzEMREKAur3zN03r4gnf98IBM2oD VCnFrwcDgMXCrva0POXOuoPI0xsZcJjeqQtFK5nmIw== X-Google-Smtp-Source: AJdET5cNHkn04YkGRc3mnOnZVTajsHmU3pc3SQogub5ypa1XUtiHItn0JwPKAaEvsfmaS+nRD6UFmMP2HE5uMaFCXAs= X-Received: by 2002:aca:f1d6:: with SMTP id p205-v6mr5484176oih.332.1541777967098; Fri, 09 Nov 2018 07:39:27 -0800 (PST) MIME-Version: 1.0 References: <2362-1541646201.813952@nGIL.zWP_.YhaK> <20626-1541726901.821000@xGvJ.shtD.SkCN> In-Reply-To: <20626-1541726901.821000@xGvJ.shtD.SkCN> From: Sebastian Gniazdowski Date: Fri, 9 Nov 2018 16:39:14 +0100 Message-ID: Subject: Re: [BUG?] If true-color is used, overlapping colors do not work To: Oliver Kiddle Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Fri, 9 Nov 2018 at 02:28, Oliver Kiddle wrote: > > Sebastian Gniazdowski wrote: > > I've applied the patch and recompiled, and the tests or the Ctrl-a > > (with Src/zsh -fi) snippet show now change? > > Working through each of your tests manually, they all seem to work fine > for me if judged purely on the basis of what I see in a terminal. I've > checked more than one terminal programme including ones with and without > true colour support. Ah I've applied only the black color patch, with also the first patch, everything works fine. > I get differences before the tests even reach the final buffer state. The > fact that all the setup lines get repeated back in the test output > really isn't helping the matter. The differences are all escape > sequences which diff is not showing, e.g 1b 5b 6d occurring at the start > of each line. There are also further differences that can be put down to a > difference of termcap definition. The only hope would be to strip the output > down to just the section actually being tested (which comptest manages), > also using something like: > zle_highlight=( fg_start_code:FGSTART fg_end_code:FGEND fg_default_code:FGDEF ) > and perhaps zle -T somehow to map escape sequences to something readable > somehow contriving to set TERM to something that claims 256 colour support. > And, only relying on the portable subset of sed syntax. > It's not without reason that I was too lazy to attempt this in the first > place. I'm stripping down the escape codes that Zsh/Zle normally produces managing output. It appears that your setup generates some additional codes. This should be only a matter of altering // substitution and sed invocation, but maybe your right, maybe updating zle_highlight / fg_start_code / fg_end_code is the right way. -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org