From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 71abe4cd for ; Tue, 30 Jul 2019 18:17:37 +0000 (UTC) Received: (qmail 10902 invoked by alias); 30 Jul 2019 18:17:27 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44597 Received: (qmail 11770 invoked by uid 1010); 30 Jul 2019 18:17:27 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua1-f45.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25524. spamassassin: 3.4.2. Clear:RC:0(209.85.222.45):SA:0(-2.0/5.0):. Processed in 3.672734 secs); 30 Jul 2019 18:17:27 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.45 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+pjI9/aGujbol+Pf80rdy50/L/AWVzIEKjhXjrNGJDM=; b=e1pSWVhRXuAaWldPYZMwNph5rsYq1UgkuDuYLdQnK9zzsUIRP2Pb8gCvhTkwG/i4Ad KENcRlnRjLQRca5HhSqinvdbFql3/S7rdWrrbP3lwrpTNnDeBRhGUddCk1eWgsMgMs4J dJuNP8kheIXixSSVFwUXa/q/XPzYL1Az4PJeyNKlQKznNYBrVHNrLg9tQyg6gM/8srXL q4I1uptn9nIkxNA4C/fFUASnhjY/FK/lgqAOMTlYXoVbR5Z3PTBjbcY/ZGyl9FG5Ovdx KwirRKWBCgZlIZHzvHDnK1fpDwtOn3z6WQFvV/C3anz3O5hLDMoglUqypKBUNP1nCtI1 1F3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+pjI9/aGujbol+Pf80rdy50/L/AWVzIEKjhXjrNGJDM=; b=WFMQcbDWJiWw7wnJjQ5/TOf+ecFcT/s2wchk5AjeO7a3fNuoDo0Mq646tyg3INZAFc qrSWTPrbfqWbm/5Abm2KWVJiQDEHTnPTYlS5GliMvcOZ5M+oVvZ5zPcvcGTGxm1KbpJ3 cBfSVJ0UgLZUxD7t2F2UgOIX8+BqQTMJAuBvsQSdLRXV2VEH50+hzjC5571lWEVb+D75 nvcFjxLXD033MmNmEcYbOUjjPmd8VemhJ8wDigQZmW4mtNnzdYj0wQL4SC5Ucv71rLCp AKvAy9qorsEi8sz9B47CCb2VQaeJILLWM3H+L1KqrJXqRnAY3KsuqHtCEp+B13c8saK2 QSzg== X-Gm-Message-State: APjAAAV7UtXSJPRYBxaY9NTbU5bfxHuHu3eoh3k3vdLhvjkbCPdg4FLd Sp6gDr99xEGFDhGYAF/ADxsTd8Knv/TFgJV0nT60MEM+ X-Google-Smtp-Source: APXvYqwrvEBvMA1bDBw/Paa14unoKGhTHCr2H94Z4HSGuggRAMNSgwc2azUyiSr0daP+iXXASBHLxi5WHYr8a7x1BTU= X-Received: by 2002:ab0:175:: with SMTP id 108mr70775111uak.136.1564510610960; Tue, 30 Jul 2019 11:16:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sebastian Gniazdowski Date: Tue, 30 Jul 2019 20:16:39 +0200 Message-ID: Subject: =?UTF-8?Q?Re=3A_A_serious_bug_in_execution_=E2=80=93_where_to_debug=3F?= To: Roman Perepelitsa Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 30 Jul 2019 at 20:12, Roman Perepelitsa wrote: > > On Tue, Jul 30, 2019 at 7:55 PM Sebastian Gniazdowski > wrote: > > Yes, implementation of plugin effects withdrawal (i.e. unloading) > > bases on this. I saw that your initialization of the prompt is called > > from precmd, where the shadowing isn't active. So (today) I've > > implemented: on-demand wrapping of any function call with the > > shadowing-enabling code, and then after a single call unwrapping. This > > way I'm able to unload your plugin. > > When you unload plugins, you also remove temporary files and kill > background daemons, right? > > Roman. No. I guess that the temp-files removal can be easily added =E2=80=93 by shadowing mktemp call. I didn't think about killing of the background processes. I guess this too can be added, but I suspect that most of them will be invisible in $jobtexts, i.e. disowned, so it might get hard. Thanks for the suggestions. How are you running the gitstatus process in the plugin? --=20 Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org