zsh-workers
 help / color / Atom feed
* [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL
@ 2019-10-21 13:30 Sebastian Gniazdowski
  2019-10-21 13:35 ` Sebastian Gniazdowski
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Gniazdowski @ 2019-10-21 13:30 UTC (permalink / raw)
  To: Zsh hackers list

Hello,
I've just fixed a long standing bug in F-Sy-H:

https://github.com/zdharma/fast-syntax-highlighting/issues/146

by a patch that changed appending to an array from:

arr=( ${arr[@]//(#e)/an-appendage} )

with a manual loop:

for __ in ${arr[@]}; do
__s+=( ${__}an-appendage )
done

The exact commit is:
https://github.com/zdharma/fast-syntax-highlighting/commit/9a6f

I guess that a Valgrind run would be helpful. BTW. How are the
automatic Valgrind tests doing? They would be helpful now.

-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL
  2019-10-21 13:30 [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL Sebastian Gniazdowski
@ 2019-10-21 13:35 ` Sebastian Gniazdowski
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Gniazdowski @ 2019-10-21 13:35 UTC (permalink / raw)
  To: Zsh hackers list

PS. The commit might seem to be doing more, but in an investigation
branch the step was only the append-method switch:

https://github.com/zdharma/fast-syntax-highlighting/commit/6590

On Mon, 21 Oct 2019 at 15:30, Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> Hello,
> I've just fixed a long standing bug in F-Sy-H:
>
> https://github.com/zdharma/fast-syntax-highlighting/issues/146
>
> by a patch that changed appending to an array from:
>
> arr=( ${arr[@]//(#e)/an-appendage} )
>
> with a manual loop:
>
> for __ in ${arr[@]}; do
> __s+=( ${__}an-appendage )
> done
>
> The exact commit is:
> https://github.com/zdharma/fast-syntax-highlighting/commit/9a6f
>
> I guess that a Valgrind run would be helpful. BTW. How are the
> automatic Valgrind tests doing? They would be helpful now.
>
> --
> Sebastian Gniazdowski
> News: https://twitter.com/ZdharmaI
> IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
> Blog: http://zdharma.org



-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 13:30 [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL Sebastian Gniazdowski
2019-10-21 13:35 ` Sebastian Gniazdowski

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git