From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 4998520a for ; Mon, 21 Oct 2019 13:35:53 +0000 (UTC) Received: (qmail 23267 invoked by alias); 21 Oct 2019 13:35:48 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44860 Received: (qmail 18812 invoked by uid 1010); 21 Oct 2019 13:35:48 -0000 X-Qmail-Scanner-Diagnostics: from mail-vs1-f66.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25608. spamassassin: 3.4.2. Clear:RC:0(209.85.217.66):SA:0(-2.0/5.0):. Processed in 1.469229 secs); 21 Oct 2019 13:35:48 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.66 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=4bAPkr3kJKGrnAtF36HqDW2Xsxo81THArwYvhxneysU=; b=kWvSyBGthb2x+9rzKTLAVRidNGaVUfoAuDpdLJADXFB0WMZ1dQMKRnXgRZVXg2PzqY 0xnrgLvWKSYd8AjGJ3O7KtTljqfXDEHzU6E7v5o/GuWSIhHuLic70OJ0sOvxGDncVzxV xHcgQWJ/Ns8J5931Lm7imZS2py2S8KvvX0hEqBd+HJdx5ov2KNAR5e6BBKfTEV/UEcnc Hfr8A5ss4JX4KZVhmyTCaCaYs9ySOZN4O5Io7qiETe9uhdaAvmnAHpSqw6uR2IxWnqxu VPFJOz0l7MRJp0Vd0Ac+i8AEbLh3SAEX8T26SugOYX36p4NUwAtqQhvPNlx7eFPfjU/0 2dZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=4bAPkr3kJKGrnAtF36HqDW2Xsxo81THArwYvhxneysU=; b=PXvrQ8UlwDFxq9o6w17or7TO8iCeHLwkFdxf0TwMEezPNQEXjc7DjUqIrvTLSDfFbB 7zDwHPcFdVnX2wV4lJ50dd98jf/RXpjcGpT8MeRAh5QugCBFsTabDViXQSR+o/Z3qp1/ qtNv6NGkNVBcfIovBGiF3Kmbza66WlSKkleIPIV2bez2xxhnl6Fsg3f29ptZRII47nAQ W/uRIYHG5UtZ3lGt7kfAPAnuDhJwjhZ6FSOuFo/UwG7GuKo7xkMjmAebTGDOXcQWXENa SxAbOYTZVzE1nDFwzdbR6GdKY7KGrwc232OY5uwBD24mUjDEMANiP8cgQwNUl/UIEcRh jN1A== X-Gm-Message-State: APjAAAUuUq+saZDazJTdeM4wZBkDwboR+vgO8TBhDvjlBMjjPWbJIyDZ 1BKx6dho3UCcmaDHI5VzSxqGt8Q0sh37QQMoYn62QySe X-Google-Smtp-Source: APXvYqyWBxy48pPNu3zVSNjug1mBjKSIAtaX3IB5Qr3ipfpE/y7ySE2eU2fPpTLhvZXQPGU/6oYo7ojC6NTLLNoQH3k= X-Received: by 2002:a67:ea01:: with SMTP id g1mr13493471vso.77.1571664913831; Mon, 21 Oct 2019 06:35:13 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sebastian Gniazdowski Date: Mon, 21 Oct 2019 15:35:06 +0200 Message-ID: Subject: Re: [BUG] Appending by arr[@]//(#e)/... crashes Zsh on WSL To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" PS. The commit might seem to be doing more, but in an investigation branch the step was only the append-method switch: https://github.com/zdharma/fast-syntax-highlighting/commit/6590 On Mon, 21 Oct 2019 at 15:30, Sebastian Gniazdowski wrote: > > Hello, > I've just fixed a long standing bug in F-Sy-H: > > https://github.com/zdharma/fast-syntax-highlighting/issues/146 > > by a patch that changed appending to an array from: > > arr=( ${arr[@]//(#e)/an-appendage} ) > > with a manual loop: > > for __ in ${arr[@]}; do > __s+=( ${__}an-appendage ) > done > > The exact commit is: > https://github.com/zdharma/fast-syntax-highlighting/commit/9a6f > > I guess that a Valgrind run would be helpful. BTW. How are the > automatic Valgrind tests doing? They would be helpful now. > > -- > Sebastian Gniazdowski > News: https://twitter.com/ZdharmaI > IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin > Blog: http://zdharma.org -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org