From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-36972-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 14925 invoked by alias); 27 Oct 2015 08:31:28 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 36972
Received: (qmail 24233 invoked from network); 27 Oct 2015 08:31:27 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,
	T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:from:date:message-id:subject:to:content-type;
        bh=d0PutZon7JhOw2c25GkzFs/c37CwzEmO35hxiTELn4Y=;
        b=ziUKKnZECPAZTOKMxtOtZr0vseCrWssAhUEQVwylhjpWHoGDv8RbsDtHwXEouValI7
         ugAkCLDrGA1DOi1B5lW9OjmNxzzNiwlFHZyAMkr9craAmB2hXlKWIgYY8M642gjLbBvN
         qcXDg7HuQ8OGXwFCfO+V/OhG+sf4weK6vSGQeIY6HGvuNHxJcAXQsP122yb+qYcsDLEk
         /xt7bb0m+VoKDpZbQIEYZUe1ubkAkdEuUXzx1dfFi+nw1AIXQF5jh7EoFlcbX5lynfm4
         vXw1S5jLrnnG8P6oS4/6+Md9+P0RBh2Cp8+wwv7VffvkTvkENmrurAJrk/TXmeZEz+BT
         L6Yw==
X-Received: by 10.112.157.74 with SMTP id wk10mr20102178lbb.54.1445934681442;
 Tue, 27 Oct 2015 01:31:21 -0700 (PDT)
MIME-Version: 1.0
From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Date: Tue, 27 Oct 2015 09:31:02 +0100
Message-ID: <CAKc7PVBM070eO+zb8GEUjiuWvksBEYVQRmcQRr0CHYp_xifVAg@mail.gmail.com>
Subject: Question about mb_metastrlen
To: zsh-workers@zsh.org
Content-Type: text/plain; charset=UTF-8

Hello,
the function counts bytes in last incomplete wide character:

        ret = mbrtowc(&wc, &inchar, 1, &mb_shiftstate);
        if (ret == MB_INCOMPLETE) {
            num_in_char++;
        } else {

When returning, it makes use of the count:

    /* If incomplete, treat remainder as trailing single bytes */
    return num + num_in_char;

Strings are stored in wchar_t arrays. The incomplete character will
occupy single index, correct? So maybe the return should be:

    return num + ( num_in_char > 0 ? 1 : 0 );

?

Best regards,
Sebastian Gniazdowski