From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27870 invoked by alias); 20 Oct 2016 16:12:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 39693 Received: (qmail 13508 invoked from network); 20 Oct 2016 16:12:47 -0000 X-Qmail-Scanner-Diagnostics: from mail-qk0-f177.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.220.177):SA:0(1.1/5.0):. Processed in 0.31714 secs); 20 Oct 2016 16:12:47 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=DATE_IN_PAST_03_06, FREEMAIL_FROM,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.220.177 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cmvXw2hDbKCzwLnyQrZJKVSjQg1zm/8ygQh7T4oTO9o=; b=wEw1eIf4Gk0bo0YEd4rIk+Qd3ux67vKTtF+Zf+9zLAO/JTpoixjgTPMPIygCm2tumc 6b6kVqSsMFTZLsRUQYiq3lgC3o7rgR75JiVxc6WsKTdu23VXhj+4HUQsuG6pIkeV8lUx YY5I7/Bsn8pKCM4FnWaw9xUCPobjbR6nxIaHai7lO4WzvPsYGHy0Xjcq+E6wl6j900vm VPBTWMo00f1x178kph5kMOmgHzDQRa2B4K12E+CxDFqePFkbOsnkiuyTJk8uBJmyOMHT fW8puIdg41x8A+APx8WMGX/56eHQDYgHiuvhKqaHMBuMlj7Wpcl0HFiFxNhdcI4bU2Ji 4QDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cmvXw2hDbKCzwLnyQrZJKVSjQg1zm/8ygQh7T4oTO9o=; b=h0S5Qtn67qvN7+RZ7pnBu9CZiijEd96g0zZCA9C8WYQvmTT3rF7LizJx6nIMATylem x0On3WscQzZ9hvOvvkau7LuiKiTRHQgQ67PIn2oIJ3GR3LT9xcQCwk0/bnK9x9h8c7MS aMhtQ1m0BHfUhkazGNTTWI0dPLsD2j171iSJB22JxPMwVBhJul5CUcvTHCqEEMfb1ohg vWY03gPvBY0GSdhOT/YwBSaAZxwqLu9UDhtzaZEdvlS1S3aowIczfqKY4TIk1lhcFw8P I8iyHFs0u3xDY8aUq6CTbN2zEBB74GnzvyavLI0ObpZsL8Szd/ZABFh1tEKPvlqZWnqw kaBg== X-Gm-Message-State: ABUngvfAXc9kbNQfVxF6mcebg3Sm5uHUg5oL3TiOsUcGBPvNFc0MqDTKZg1vB7TqyloPzchxalPuH5L6GTqLbg== X-Received: by 10.55.158.139 with SMTP id h133mr11844330qke.202.1476959470539; Thu, 20 Oct 2016 03:31:10 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20161020111819.4088896a@pwslap01u.europe.root.pri> References: <20161013104321.29159e3f@pwslap01u.europe.root.pri> <20161019141435.42eb6df2@pwslap01u.europe.root.pri> <20161020103259.0b0fe556@pwslap01u.europe.root.pri> <20161020111819.4088896a@pwslap01u.europe.root.pri> From: Sebastian Gniazdowski Date: Thu, 20 Oct 2016 12:30:50 +0200 Message-ID: Subject: Re: Cores almost on demand in patcompile() To: Peter Stephenson Cc: Zsh hackers list , Bart Schaefer Content-Type: text/plain; charset=UTF-8 On 20 October 2016 at 12:18, Peter Stephenson wrote: > Hmm... well, what I've posted fixes the pointers at line 650 of > pattern.c > > for (; pscan; pscan = next) { > next = PATNEXT(pscan); > > where they would have been wrong before, so if you're *still* seeing > problems after the change, you've found something else. Valgrind points at patadd(NULL, 0, nmeta, 0). Wonder why not to its interior? But to all logic, problem should be inside patadd() because nothing else near dereferences a pointer. So there might be two problems. Debugger didn't report inaccessible memory when I did step-over on the patadd(), maybe memory is accessible but invalid from other reason recognized by Valgrind. Best regards, Sebastian Gniazdowski