zsh-workers
 help / color / mirror / code / Atom feed
From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: true colour support
Date: Tue, 6 Nov 2018 13:12:34 +0100	[thread overview]
Message-ID: <CAKc7PVBjmnpmghFRteDwymuHcOmo87DgkfULN3f3TiCX_YYjxA@mail.gmail.com> (raw)
In-Reply-To: <14759-1541295720.747208@yAOj.Gon2.-2mF>

On Sun, 4 Nov 2018 at 02:42, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> (...)
> I don't think there's any sense in trying to detect support for
> true colour. termcap/terminfo can't help us and it'll be more
> reliable to leave it to users to craft whatever heuristics work for
> those terminals that they use. No true colour escapes will ever be
> generated if you don't specify colours as hex triples anyway. And
> even if they are, they should be ignored. For what it's worth,
> checking for *(truecolor|24bit)* in $COLORTERM is a reasonable test
> with the nearcolor module from the first patch acting as a fallback.
> And, you might want to add COLORTERM in AcceptEnv/SendEnv for ssh
> if it isn't there already.

I'm grepping the patches and cannot find any snippet that decides
whether to use 24-bit escape sequences or zsh/nearcolor module. How
it's decided?

You've also written: "No true colour escapes will ever be generated if
you don't specify colours as hex triples anyway. And even if they are,
they should be ignored.".This sounds like: if true-color/near-color
was not enabled, ignore hex-triplet. But I think there is no switch
(e.g. an option) to enable true-color support?

-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

  parent reply	other threads:[~2018-11-06 12:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAKc7PVCEmTTMRR0P3kx9ktpLDBYqJ+MRsE77UMLFjonEZAixfA@mail.gmail.com>
2018-10-30 23:41 ` Terminal theme tool – a workaround for lack of 24-bit color in Zsh? Oliver Kiddle
2018-11-01 18:42   ` dana
2018-11-04  1:42   ` PATCH: true colour support Oliver Kiddle
2018-11-04 22:57     ` Oliver Kiddle
2018-11-05 14:36     ` Sebastian Gniazdowski
     [not found]       ` <46482-1541429525.040210@53iC.Cv7F.M2xE>
2018-11-05 15:48         ` Sebastian Gniazdowski
2018-11-05 16:22           ` Sebastian Gniazdowski
2018-11-06 12:12     ` Sebastian Gniazdowski [this message]
2018-11-06 13:37       ` Oliver Kiddle
2018-11-06 21:46         ` Sebastian Gniazdowski
2018-11-06 12:22     ` Should there be a Zsh release for true-color support to adopt earlier? Sebastian Gniazdowski
2018-11-06 22:35       ` Daniel Shahaf
2018-11-06 23:46         ` Bart Schaefer
2018-11-05 14:03   ` Terminal theme tool – a workaround for lack of 24-bit color in Zsh? Sebastian Gniazdowski
2018-11-15 11:50   ` Jun T
2018-11-15 12:44     ` Peter Stephenson
2018-11-16  7:54       ` Jun T
2018-11-19  8:29         ` Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKc7PVBjmnpmghFRteDwymuHcOmo87DgkfULN3f3TiCX_YYjxA@mail.gmail.com \
    --to=sgniazdowski@gmail.com \
    --cc=okiddle@yahoo.co.uk \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).