From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Parse error on autoload -X and a function with & in name
Date: Tue, 9 Jul 2019 01:51:57 +0200 [thread overview]
Message-ID: <CAKc7PVBnn4on_KdZS_inENm1A2OmhWzCOjhcvxnc8P-LFsG+FA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7bxJWMWrYo3+tmrm3Ua6nyOyBQnqj87ToR7nr=BD7JMHw@mail.gmail.com>
On Tue, 9 Jul 2019 at 00:12, Bart Schaefer <schaefer@brasslantern.com> wrote:
> Try this (apologies if gmail line wraps the @@ heading):
>
> diff --git a/Src/builtin.c b/Src/builtin.c
> index 9b9e76c77..7db36c41b 100644
> --- a/Src/builtin.c
> +++ b/Src/builtin.c
> @@ -3029,7 +3029,7 @@ eval_autoload(Shfunc shf, char *name, Options
> ops, int func)
> }
> if (OPT_MINUS(ops,'X')) {
> char *fargv[3];
> - fargv[0] = name;
> + fargv[0] = quotestring(name, QT_SINGLE_OPTIONAL);
> fargv[1] = "\"$@\"";
> fargv[2] = 0;
> shf->funcdef = mkautofn(shf);
The patch works:
echo echo hello > '&abcd'
function \&abcd() {
autoload -X
}
\&abcd
hello
--
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org
prev parent reply other threads:[~2019-07-08 23:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 19:35 Sebastian Gniazdowski
2019-07-08 19:40 ` Roman Perepelitsa
2019-07-08 19:42 ` Sebastian Gniazdowski
2019-07-08 20:02 ` Sebastian Gniazdowski
2019-07-08 22:12 ` Bart Schaefer
2019-07-08 23:51 ` Sebastian Gniazdowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKc7PVBnn4on_KdZS_inENm1A2OmhWzCOjhcvxnc8P-LFsG+FA@mail.gmail.com \
--to=sgniazdowski@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).