From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43700-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 81c88342 for ; Wed, 17 Oct 2018 04:29:54 +0000 (UTC) Received: (qmail 24675 invoked by alias); 17 Oct 2018 04:29:36 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43700 Received: (qmail 10206 invoked by uid 1010); 17 Oct 2018 04:29:35 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot1-f65.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.210.65):SA:0(-1.9/5.0):. Processed in 11.857528 secs); 17 Oct 2018 04:29:35 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=siTMTxb16pbPelYUcKWwLuvS9NG2Zrzsih6X2L0+YHg=; b=bZA76d98I20Hgo5GdFkMVO6lovsQ/F1dQJ76FH95/zmpE/feyo7uT1Qynjz0m13YoI U0h58880GS0aycqdjLDW5yHOwHtavPTfSkBZoMo1JPoXooTjKyjO8CEVoqe/kZj0esz1 l549ASdlOjLEl+zunxsul+Up8SYcNqWNtHe4eALXg0DDikRNr1Dpqh1ZnQPL9HenDOXg kT5Ebj8uxHKeaQd0hPUACI5A5eEI6q0sFktb70kMMoLGzpjvalpASlJFapZ2PWtRyzIA HEHyzssS9FBkHojLtT8kmUWn2mPYgGp5hgS1sgA/0AQ2jeQxhN6a8tBfQkRbil0Oqra/ Duig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=siTMTxb16pbPelYUcKWwLuvS9NG2Zrzsih6X2L0+YHg=; b=CYpztK1WZ3N71doSL7Rizlk+Mwumar4ZP7n1UldoR8obEaGs7Caqz504IeJ/n58XCj yIf8YJA/5U/IFpIUz0rngh5sxhPPnyZsqDgi+JrEfyCzQhroCyLuz8VCA01u2gvPFXel dVORPL4q1m43Ki2ziL623V4x0g/JEDb3Q0jmtYBQsjn7rgEM3/t79pZtbACG8HslK9Sm 8fy6LfcypSj/Q52boefwTfTCj2wFoo/1DGFXcQMCGyvuoqRNSCrxsArFJpb1iAKDTUWI at34FhPi9WEEVnymqt7+oCFwzwAX60bx/myfEL+m1bA2nUN8g+ZnWa0SHIuhbzLnDc8B TvYw== X-Gm-Message-State: ABuFfoiuedkvxn+1SgkqCFZ2pviYzg3XahcKOf1y+PXJLG+O2F15aEjQ QumSugKBk2PV3y1Z1GVOFEhCWGPEjW/rT4X55XtkhPv8 X-Google-Smtp-Source: ACcGV60v6R8gw4BN8VYtGL3fjhq368ez/X+BO763+oAD0lPNJffcGktXNeLTxfeVHhcEcm1MVjLY+CIWWGBSmUv2jBE= X-Received: by 2002:a9d:3cbd:: with SMTP id z58mr16153981otc.159.1539750559688; Tue, 16 Oct 2018 21:29:19 -0700 (PDT) MIME-Version: 1.0 From: Sebastian Gniazdowski Date: Wed, 17 Oct 2018 06:29:08 +0200 Message-ID: Subject: [PATCH] ztrsub() execution time / 2 To: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000274c4e0578651dbd" --000000000000274c4e0578651dbd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, this optimization is a drop of callgrind instruction count by 43 mln for ztrsub() =E2=80=93 it had 89 mln instructions normally, now it has 46 m= ln: ztrsub() callgrind I-count: 1> (89873326 - 46452836) / 1000000.0 43,4205 total callgrind I-count 2> (7906279976 - 7858975498) / 1000000.0 47,3045 89,873,326 ztrsub [/usr/local/bin/zsh-5.6.2-dev-1-2noopt] vs 46,452,836 ztrsub [/usr/local/bin/zsh-5.6.2-dev-1-2yesopt] Ran this callgrind probe twice to confirm. That said, `zsh -i -c exit' nor a performance test script show any gain. I wonder why.. But callgrind doesn't lie, and looking at the code one can understand why I-count dropped by factor of 2. The patch has many context lines to see whole function. --=20 Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org --000000000000274c4e0578651dbd Content-Type: text/plain; charset="US-ASCII"; name="ztrsub_opt.diff.txt" Content-Disposition: attachment; filename="ztrsub_opt.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jncnokf90 ZGlmZiAtLWdpdCBhL1NyYy91dGlscy5jIGIvU3JjL3V0aWxzLmMKaW5kZXggOTE0ZTMwYy4uMWVi OGM3MSAxMDA2NDQKLS0tIGEvU3JjL3V0aWxzLmMKKysrIGIvU3JjL3V0aWxzLmMKQEAgLTUwNTgs MjMgKzUwNTgsMjMgQEAgenRybGVuZW5kKGNoYXIgY29uc3QgKnMsIGNoYXIgY29uc3QgKmVwdHIp CiAjZW5kaWYgLyogTVVMVElCWVRFX1NVUFBPUlQgKi8KIAogLyogU3VidHJhY3QgdHdvIHBvaW50 ZXJzIGluIGEgbWV0YWZpZWQgc3RyaW5nLiAqLwogCiAvKiovCiBtb2RfZXhwb3J0IGludAogenRy c3ViKGNoYXIgY29uc3QgKnQsIGNoYXIgY29uc3QgKnMpCiB7CiAgICAgaW50IGwgPSB0IC0gczsK IAogICAgIHdoaWxlIChzICE9IHQpIHsKLQlpZiAoKnMrKyA9PSBNZXRhKSB7CisJaWYgKCpzKysg PT0gTWV0YSB8fCAocyAhPSB0ICYmICpzKysgPT0gTWV0YSkpIHsKICNpZmRlZiBERUJVRwogCSAg ICBpZiAoISAqcyB8fCBzID09IHQpCiAJCWZwcmludGYoc3RkZXJyLCAiQlVHOiBzdWJzdHJpbmcg ZW5kcyBpbiB0aGUgbWlkZGxlIG9mIGEgbWV0YWNoYXIgaW4genRyc3ViKClcbiIpOwogCSAgICBl bHNlCiAjZW5kaWYKIAkgICAgcysrOwogCSAgICBsLS07CiAJfQogICAgIH0KICAgICByZXR1cm4g bDsKIH0K --000000000000274c4e0578651dbd--