zsh-workers
 help / Atom feed
* PATCH: configure - use ncurses (not only ncursesw) before tinfo
@ 2019-08-27  2:32 Sebastian Gniazdowski
  2019-08-28  0:51 ` Sebastian Gniazdowski
  0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Gniazdowski @ 2019-08-27  2:32 UTC (permalink / raw)
  To: Zsh hackers list

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Hello,
I've noticed that Zsh shipped with Mageia doesn't include zsh/curses
module. Trying to build Zsh revealed the cause: Mageia ships with
libncurses, not libncursesw and the relevant part in configure.ac
says:

termcap_curses_order="$ncursesw_test tinfo termcap $ncurses_test curses" ;;

The width of the curses library is irrelevant to Zsh - it only needs
the terminal sequences from the library, which aren't associated to
any Unicode topic. As for the part that actually is relevant to the
Unicode - the zsh/curses module - it is still better to build it
without the multibyte support than not to build it at all.

Not to say that libncurses libraries today do have multibyte support.
So the conservative terminal-library order doesn't have any support in
reality. The patch changes the order to:

termcap_curses_order="$ncursesw_test $ncurses_test tinfo termcap curses" ;;

-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

[-- Attachment #2: 0001-configure-use-ncurses-not-only-ncursesw-before-tinfo.patch.txt --]
[-- Type: text/plain, Size: 1322 bytes --]

From 4038724a554f9b6dae228bdbabcb0822c31163f7 Mon Sep 17 00:00:00 2001
From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Date: Tue, 27 Aug 2019 04:16:06 +0200
Subject: [PATCH] =?UTF-8?q?configure=20=E2=80=93=20use=20ncurses=20(not=20?=
 =?UTF-8?q?only=20ncursesw)=20before=20tinfo=20and=20termcap?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8a2664ed2..9ccf17b84 100644
--- a/configure.ac
+++ b/configure.ac
@@ -774,7 +774,7 @@ AS_HELP_STRING([--with-term-lib=LIBS],[search space-separated LIBS for terminal
   termcap_curses_order="$withval"
   AC_SEARCH_LIBS(tigetstr, [$termcap_curses_order])
 else
-  termcap_curses_order="$ncursesw_test tinfo termcap $ncurses_test curses"
+  termcap_curses_order="$ncursesw_test $ncurses_test tinfo termcap curses"
 fi],
 [case "$host_os" in
   solaris*)
@@ -783,7 +783,7 @@ fi],
    DL_EXT="${DL_EXT=sl}"
    termcap_curses_order="Hcurses $ncursesw_test $ncurses_test curses termcap" ;;
   *)
-   termcap_curses_order="$ncursesw_test tinfo termcap $ncurses_test curses" ;;
+   termcap_curses_order="$ncursesw_test $ncurses_test tinfo termcap curses" ;;
 esac])dnl
 
 AH_TEMPLATE([ZSH_NO_XOPEN],
-- 
2.21.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: PATCH: configure - use ncurses (not only ncursesw) before tinfo
  2019-08-27  2:32 PATCH: configure - use ncurses (not only ncursesw) before tinfo Sebastian Gniazdowski
@ 2019-08-28  0:51 ` Sebastian Gniazdowski
  0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Gniazdowski @ 2019-08-28  0:51 UTC (permalink / raw)
  To: Zsh hackers list

Just one more thing – if someone would have doubts as whether we
should so one directionally bind Zsh to ncurses, then let's notice
that the second library in the order enumeration – tinfo – is an
extracted terminal-sequences sublibrary taken out of ncurses.

On Tue, 27 Aug 2019 at 04:32, Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> Hello,
> I've noticed that Zsh shipped with Mageia doesn't include zsh/curses
> module. Trying to build Zsh revealed the cause: Mageia ships with
> libncurses, not libncursesw and the relevant part in configure.ac
> says:
>
> termcap_curses_order="$ncursesw_test tinfo termcap $ncurses_test curses" ;;
>
> The width of the curses library is irrelevant to Zsh - it only needs
> the terminal sequences from the library, which aren't associated to
> any Unicode topic. As for the part that actually is relevant to the
> Unicode - the zsh/curses module - it is still better to build it
> without the multibyte support than not to build it at all.
>
> Not to say that libncurses libraries today do have multibyte support.
> So the conservative terminal-library order doesn't have any support in
> reality. The patch changes the order to:
>
> termcap_curses_order="$ncursesw_test $ncurses_test tinfo termcap curses" ;;
>
> --
> Sebastian Gniazdowski
> News: https://twitter.com/ZdharmaI
> IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
> Blog: http://zdharma.org



-- 
Sebastian Gniazdowski
News: https://twitter.com/ZdharmaI
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin
Blog: http://zdharma.org

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-27  2:32 PATCH: configure - use ncurses (not only ncursesw) before tinfo Sebastian Gniazdowski
2019-08-28  0:51 ` Sebastian Gniazdowski

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/ public-inbox