From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: zsh-workers-return-43695-ml=inbox.vuxu.org@zsh.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id c98bc7a9 for ; Tue, 16 Oct 2018 22:08:37 +0000 (UTC) Received: (qmail 26111 invoked by alias); 16 Oct 2018 22:08:21 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43695 Received: (qmail 22178 invoked by uid 1010); 16 Oct 2018 22:08:20 -0000 X-Qmail-Scanner-Diagnostics: from mail-ot1-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.210.54):SA:0(-1.9/5.0):. Processed in 3.46603 secs); 16 Oct 2018 22:08:20 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kLuf5+gkCcR20OjtwoAEQpeqVeZuQGBwESh4RzUkZaI=; b=kJw2w50yNXUCzvMYxJwSWBbqWfyy24VjO79GPGgyR4WRMY3TLUwC/gtX5x+gaa5ycU Mz0Fr1kiMkn0/C9x2PDddlGxn10s2OylEZGdxYk8PKqWwCgJHhRFX9HHBPuXDIC5cng5 +UYHwN9kcS66PPUWDlbuG4LAvPyhN5wXZB7XBAdCc3VkHR64WDoRSVGEZ23zFbcFhue0 jVtO+z94C1LYXz9yPVl8IqTNBRyLcVcRDzzGBlWs17qi1qWgCbygEi0bKXJee34+sv3R Yh8XTKm2XEMbqvXSV1kIuZVXVCn37lwhsnn7ZheQfjR9j6erMeuKnHsgH4Z5orb7oD2x FucA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kLuf5+gkCcR20OjtwoAEQpeqVeZuQGBwESh4RzUkZaI=; b=dms/SCv7iTsQDQ4ygWC0hEp+kJ4VAqq9tcqhs0LOWKOWgAf25BrZbwHTtWtXRXsxtf VKH1TDtZ6HK4spi8blfgm3yWii4Gu7UDIirHghrmayBY2J8hhlOfXR52ForS5kgN8nin QgWggEnJxxlyTVbl4bl63KEsLpQJRKxAkL59+g/r2qIEoFF3LXn9lt7C8q4fz2LyeHQn ogRXAjcL152eUEaQicRyj0nfq9Y8CVo1Z9QrmrCFDTLW8m3DvAkqKWyx7+i5VtIXJy+t Beo37R4bOk6LYvA1fiAcIhNymnLcGsfJOzjuuA23GIW12trSyQ9CdONtGYgO4XtvyPMM R4YQ== X-Gm-Message-State: ABuFfoipzA7k4W9eT2dvyq83cqvthhlX9iagtzGFt46hLJuH0y3HqlF1 7tX7pEvV+FF5EUa4r7EoatOKaVgLPUlWzG5ffa4j7w== X-Google-Smtp-Source: ACcGV62jEx1tm2HO9Lbvphp3PQ8FFW4IA/tB6tU5jU9GiS3fjFzGpyv1sYOkirn1avj3JwltR/VWBw1msGqKoEXCwjQ= X-Received: by 2002:a9d:55ce:: with SMTP id z14mr14039423oti.17.1539727693761; Tue, 16 Oct 2018 15:08:13 -0700 (PDT) MIME-Version: 1.0 From: Sebastian Gniazdowski Date: Wed, 17 Oct 2018 00:08:01 +0200 Message-ID: Subject: [PATCH] Clean but not very effective optimization (lex.c / dupstring_wlen) To: Zsh hackers list Content-Type: multipart/mixed; boundary="0000000000003cfc3505785fca61" --0000000000003cfc3505785fca61 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, dupstring_wlen (i.e. with-len) is ready to use, so this patch is just 4 changes dupstring(s) -> dupstring_wlen(s, l). Each of those dupstrings has a nice strlen() invocation already there in lex.c, a few lines above. Callgrind doesn't report any real change in number of instructions of strlen() call and a test that repeatedly invokes (z) flag on a 32-line buffer 150 times reports 24 ms for both unoptimized and optimized version. However performance test of F-Sy-Highlighting reports rather stable 40 ms gain =E2=80=93 out of ~3000 ms, so not much. In general simplicity of this patch made me send it. --=20 Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org --0000000000003cfc3505785fca61 Content-Type: text/plain; charset="US-ASCII"; name="lex_4strlens.diff.txt" Content-Disposition: attachment; filename="lex_4strlens.diff.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jnca2w8u0 ZGlmZiAtLWdpdCBhL1NyYy9sZXguYyBiL1NyYy9sZXguYwppbmRleCA0NGFkODgwLi5mYTI5ZGEz IDEwMDY0NAotLS0gYS9TcmMvbGV4LmMKKysrIGIvU3JjL2xleC5jCkBAIC0xNjI2LDcgKzE2MjYs NyBAQCBwYXJzZXN0cm5vZXJyKGNoYXIgKipzKQogCiAgICAgemNvbnRleHRfc2F2ZSgpOwogICAg IHVudG9rZW5pemUoKnMpOwotICAgIGlucHVzaChkdXBzdHJpbmcoKnMpLCAwLCBOVUxMKTsKKyAg ICBpbnB1c2goZHVwc3RyaW5nX3dsZW4oKnMsIGwpLCAwLCBOVUxMKTsKICAgICBzdHJpbmJlZygw KTsKICAgICBsZXhidWYubGVuID0gMDsKICAgICBsZXhidWYucHRyID0gdG9rc3RyID0gKnM7CkBA IC0xNjU4LDcgKzE2NTgsNyBAQCBwYXJzZV9zdWJzY3JpcHQoY2hhciAqcywgaW50IHN1YiwgaW50 IGVuZGNoYXIpCiAgICAgaWYgKCEqcyB8fCAqcyA9PSBlbmRjaGFyKQogCXJldHVybiAwOwogICAg IHpjb250ZXh0X3NhdmUoKTsKLSAgICB1bnRva2VuaXplKHQgPSBkdXBzdHJpbmcocykpOworICAg IHVudG9rZW5pemUodCA9IGR1cHN0cmluZ193bGVuKHMsIGwpKTsKICAgICBpbnB1c2godCwgMCwg TlVMTCk7CiAgICAgc3RyaW5iZWcoMCk7CiAgICAgLyoKQEAgLTE2NzQsNyArMTY3NCw3IEBAIHBh cnNlX3N1YnNjcmlwdChjaGFyICpzLCBpbnQgc3ViLCBpbnQgZW5kY2hhcikKICAgICAgKiBsZW5n dGggcHJlc2VydmF0aW9uLgogICAgICAqLwogICAgIGxleGJ1Zi5sZW4gPSAwOwotICAgIGxleGJ1 Zi5wdHIgPSB0b2tzdHIgPSBkdXBzdHJpbmcocyk7CisgICAgbGV4YnVmLnB0ciA9IHRva3N0ciA9 IGR1cHN0cmluZ193bGVuKHMsIGwpOwogICAgIGxleGJ1Zi5zaXogPSBsICsgMTsKICAgICBlcnIg PSBkcXVvdGVfcGFyc2UoZW5kY2hhciwgc3ViKTsKICAgICB0b2tsZW4gPSAoaW50KShsZXhidWYu cHRyIC0gdG9rc3RyKTsKQEAgLTE3MTMsNyArMTcxMyw3IEBAIHBhcnNlX3N1YnN0X3N0cmluZyhj aGFyICpzKQogCXJldHVybiAwOwogICAgIHpjb250ZXh0X3NhdmUoKTsKICAgICB1bnRva2VuaXpl KHMpOwotICAgIGlucHVzaChkdXBzdHJpbmcocyksIDAsIE5VTEwpOworICAgIGlucHVzaChkdXBz dHJpbmdfd2xlbihzLCBsKSwgMCwgTlVMTCk7CiAgICAgc3RyaW5iZWcoMCk7CiAgICAgbGV4YnVm LmxlbiA9IDA7CiAgICAgbGV4YnVmLnB0ciA9IHRva3N0ciA9IHM7Cg== --0000000000003cfc3505785fca61--