From: Sebastian Gniazdowski <sgniazdowski@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] zsystem:34: flock: invalid timeout value: '0'
Date: Fri, 26 Jun 2020 21:42:01 +0200 [thread overview]
Message-ID: <CAKc7PVCtHg1Pq1qBWBUwdiNe_8w9LXS_3t-2eBSuCg-ZoZnUgw@mail.gmail.com> (raw)
In-Reply-To: <20200626141644.7cb5e511@tarpaulin.shahaf.local2>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
On Fri, 26 Jun 2020 at 16:16, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Sebastian Gniazdowski wrote on Thu, 25 Jun 2020 19:49 +0200:
> > Hi
> > I think that something happened to zsystem / flock, as the following
> > returns the above error under Cygwin:
> >
> > $ zsystem flock -t 0 -f FD -e /home/SG/.zsh_nr1
> > zsystem:34: flock: invalid timeout value: '0'
> >
> > Timeout of value 0 is an acceptable one - it means no waiting for the
> lock,
> > just try-to-lock and exit.
>
> You've neglected to identify the environment it works in
What do you mean? I don't have access to environment other than Cygwin and
I've written about the Cygwin-environment to narrow this report.
> the environment number it doesn't work in
I've written what has to converge to the current HEAD.
> and the reason you didn't do
> a bisect as courtesy prescribes.
>
> In this case, system.c gets so few commits that a bisect is almost
> a formality. The bug is likely to have been introduced by workers/45708.
>
I saw the subsecond timeout changes conversation/patch and assumed that
it's the cause, thus I've left the interested party to be alerted by the
title.
> I recommend that you test the behaviour with and without that commit
> and reported the results.
>
> I further recommend that, if you have time, you also prepare a patch,
> or at least an expected-to-fail regression test (using the 'f' flag
> after the exit code).
>
I might prepare a patch, but I also think that the involved party might do
this.
--
Sebastian Gniazdowski
IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zinit
Blog: http://zdharma.org
next prev parent reply other threads:[~2020-06-26 19:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 17:49 Sebastian Gniazdowski
2020-06-26 14:16 ` Daniel Shahaf
2020-06-26 19:42 ` Sebastian Gniazdowski [this message]
2020-06-27 1:47 ` Daniel Shahaf
2020-06-27 2:04 ` Bart Schaefer
2020-06-27 7:13 ` Cedric Ware
2020-06-27 7:27 ` Roman Perepelitsa
2020-06-27 17:01 ` Bart Schaefer
2020-06-27 17:12 ` Roman Perepelitsa
2020-06-27 17:58 ` Bart Schaefer
2020-06-27 18:09 ` Roman Perepelitsa
2020-06-27 20:38 ` Cedric Ware
2020-06-28 9:27 ` Roman Perepelitsa
2020-07-10 15:28 ` Sebastian Gniazdowski
2020-07-11 5:18 ` dana
2020-06-27 17:25 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKc7PVCtHg1Pq1qBWBUwdiNe_8w9LXS_3t-2eBSuCg-ZoZnUgw@mail.gmail.com \
--to=sgniazdowski@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).