From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27976 invoked from network); 26 Jun 2020 19:42:57 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 26 Jun 2020 19:42:57 -0000 Received: (qmail 11829 invoked by alias); 26 Jun 2020 19:42:47 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46133 Received: (qmail 2775 invoked by uid 1010); 26 Jun 2020 19:42:47 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk1-f196.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25850. spamassassin: 3.4.4. Clear:RC:0(209.85.221.196):SA:0(-2.0/5.0):. Processed in 3.741773 secs); 26 Jun 2020 19:42:47 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.221.196 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dxGT6RP4jYMFMcWrlbw2I6/icp9Vp96SALAtX6xSktw=; b=AqcumEdNpuAxZL2KfdVMS/oJd0JrncZp4is++9rIfPuvDdTjIoN1K1HJbkwWJF9Nbz Y4LO1Zf/Ggvh9VPbmd55wEYPZFlXtTjcfi5mX7mQlmuiBgisUB1wdSoJXIIMzBM/ml7U jm+/VDZmyyxAOQgOv7Kc96GuyEpTUJ7lZWv4ykSp2SEQdeQm3ggto10hNl1T/BSzblyh AHTGRmXFo0A/Sz1dXfS3U7bxB5ZIU2/YHgx52wCvjdQEu99RDx3ky4LW7/PyFOAYBQil UcrJPm38TkV4Cdkl1CCLbFVSMJEU8V9VdNaUxdUqW92Oo7LijpqdHfcJjprYuziiznGZ a3aA== X-Gm-Message-State: AOAM531pGuu85Dw10JI2NQb/KTI9KvmAVFQta97O6mHUA4M9vjYZrF4i dYCfBM0ISweDkD6rRVg3MoVQC9dj3aZLFM/oC/A= X-Google-Smtp-Source: ABdhPJwC8RuXlNC4B7nfqZww8SFuzYULLjhLJ/0Yer9C5C3VdoA3r9Zi0lIAexyCFrvYgcENYmTHlAhY1EJNgYLU7q4= X-Received: by 2002:a05:6122:106f:: with SMTP id k15mr3326477vko.21.1593200529524; Fri, 26 Jun 2020 12:42:09 -0700 (PDT) MIME-Version: 1.0 References: <20200626141644.7cb5e511@tarpaulin.shahaf.local2> In-Reply-To: <20200626141644.7cb5e511@tarpaulin.shahaf.local2> From: Sebastian Gniazdowski Date: Fri, 26 Jun 2020 21:42:01 +0200 Message-ID: Subject: Re: [BUG] zsystem:34: flock: invalid timeout value: '0' To: Daniel Shahaf Cc: Zsh hackers list Content-Type: multipart/alternative; boundary="0000000000009e4bd005a901e76c" --0000000000009e4bd005a901e76c Content-Type: text/plain; charset="UTF-8" On Fri, 26 Jun 2020 at 16:16, Daniel Shahaf wrote: > Sebastian Gniazdowski wrote on Thu, 25 Jun 2020 19:49 +0200: > > Hi > > I think that something happened to zsystem / flock, as the following > > returns the above error under Cygwin: > > > > $ zsystem flock -t 0 -f FD -e /home/SG/.zsh_nr1 > > zsystem:34: flock: invalid timeout value: '0' > > > > Timeout of value 0 is an acceptable one - it means no waiting for the > lock, > > just try-to-lock and exit. > > You've neglected to identify the environment it works in What do you mean? I don't have access to environment other than Cygwin and I've written about the Cygwin-environment to narrow this report. > the environment number it doesn't work in I've written what has to converge to the current HEAD. > and the reason you didn't do > a bisect as courtesy prescribes. > > In this case, system.c gets so few commits that a bisect is almost > a formality. The bug is likely to have been introduced by workers/45708. > I saw the subsecond timeout changes conversation/patch and assumed that it's the cause, thus I've left the interested party to be alerted by the title. > I recommend that you test the behaviour with and without that commit > and reported the results. > > I further recommend that, if you have time, you also prepare a patch, > or at least an expected-to-fail regression test (using the 'f' flag > after the exit code). > I might prepare a patch, but I also think that the involved party might do this. -- Sebastian Gniazdowski IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zinit Blog: http://zdharma.org --0000000000009e4bd005a901e76c--