From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26809 invoked by alias); 24 Oct 2015 08:05:09 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36932 Received: (qmail 8355 invoked from network); 24 Oct 2015 08:05:08 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=pQi6v1XIKfb4xDTuKOnt+PqvHlcvHS3HNnievJjrUxs=; b=SPpm7IR3TvluUGVQeLpK1YDINy1ZoIErWs/YgdWR80M6a0ozOtr4xOu9L7RvkeCxNS 7+ursMbWbtkP+kYDtFUc1hwvnzY4xmbj0wqZ61FUI9zY+TCsOtvQGYR0Tm1QHbNsAi0p MCtej1zUCF1entmvwcEA5gCHrt5ZDwThWvK0o2EPGIRpRcq975166hguJkax8jHNkI+0 EjNJF0WKh6iRiv32Kgb6S94WKVxaADxcausIdMvuc3iy5MNqedm1yrN7VsLWLNWDh5aR NlNerpi1YVZaLZ4U8ywEOQ1mLf0ad/m7asb1aeYNVHdGlEBJpF+kLyEOHut66gT7AG4l IfFA== X-Received: by 10.112.189.193 with SMTP id gk1mr3597649lbc.98.1445673906121; Sat, 24 Oct 2015 01:05:06 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <151010105849.ZM10144@torch.brasslantern.com> <151010170623.ZM16166@torch.brasslantern.com> <151010232045.ZM12931@torch.brasslantern.com> <151011091757.ZM27755@torch.brasslantern.com> <151011103121.ZM8814@torch.brasslantern.com> <151011142204.ZM9103@torch.brasslantern.com> <151012070105.ZM15099@torch.brasslantern.com> <151012173304.ZM15477@torch.brasslantern.com> <151013085246.ZM30504@torch.brasslantern.com> <20151014142722.282d0c5a@pwslap01u.europe.root.pri> <151014092536.ZM32511@torch.brasslantern.com> <151014095009.ZM19954@torch.brasslantern.com> <151014213224.ZM15646@torch.brasslantern.com> <151015173554.ZM30733@torch.brasslantern.com> <151019102117.ZM32700@torch.brasslantern.com> <151022080024.ZM6471@torch.brasslantern.com> <151023122655.ZM21177@torch.brasslantern.com> <151023165006.ZM25785@torch.brasslantern.com> From: Sebastian Gniazdowski Date: Sat, 24 Oct 2015 10:04:46 +0200 Message-ID: Subject: Re: Slowdown around 5.0.5-dev-0 To: zsh-workers@zsh.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Turns out I read this correctly for the first time. You meant 36926, which is the yesterday's patch. Having this in mind my email still makes sense. I just described how 36834, 36836, 36926 behave. On 24 October 2015 at 09:37, Sebastian Gniazdowski wrote: > On 24 October 2015 at 08:09, Sebastian Gniazdowski > wrote: >> On 24 October 2015 at 01:50, Bart Schaefer w= rote: >>> On Oct 23, 12:26pm, Bart Schaefer wrote: >>> } >>> } Try the below patch against 8e9a68ad1 ? >>> >>> However, if the results can be considered reliable anyway, note that >>> 36926 retains most of the search_test speed, which I think is an >>> improvement over backing out all of 36834 (Sebastian's results for >>> zsh-newheaps-zhalloc, if I'm reading his email correctly). >> >> I ran quick tests yesterday and obtained this too. Good news that not >> all gains of 36834 will be withdrawn! :) The newheaps-zhalloc is what >> you write, two following patches without 36834. > > I misread this. What I wanted to state, is that your patch from > yesterday retained search_test speed. > > The fact that 36836 has its contribution in speeding up search_test is > was described by me in previous email: > >> newheaps is responsible for >> instant-responsivity of my script, 36836 for much faster searching =E2= =80=93 >> that's a good compromise > > So the thing is that your patch from yesterday retains search_test > speed up of 36834, while fixing the memory issues of 36834. Together > with 36836, this gives full retain of search_test speedup, nothing is > lost, speed of pattern matching is as high as with no revert from > current head state. What's lost is string_test speedup 36834 gave, > however, it did so with cost of increased memory usage > > Best regards, > Sebastian Gniazdowski