From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id a1a3b422 for ; Thu, 3 Oct 2019 14:40:25 +0000 (UTC) Received: (qmail 21546 invoked by alias); 3 Oct 2019 14:40:15 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44802 Received: (qmail 26686 invoked by uid 1010); 3 Oct 2019 14:40:15 -0000 X-Qmail-Scanner-Diagnostics: from mail-ua1-f46.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25587. spamassassin: 3.4.2. Clear:RC:0(209.85.222.46):SA:0(-2.0/5.0):. Processed in 3.494341 secs); 03 Oct 2019 14:40:15 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.222.46 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=uxN2K2cQCsbBUAeeVAWn7MaatHvpM/exmo2/f7eSCrg=; b=BVKCzBgs/fv0/CWgC4qanA5PvT0ePXwqRAjyZAXi5Kut8EQ++i7jZT0hknxYTvBl65 JELpjH/PDTiDxqJXj6zuZW7KZrJqsIsY2+Ya+FKiMfgYuq+JL+TvsUai/g954pnnoQi8 P7G2PzxaJaPXqm6aMvjtDWsS8mionfoG8Z3DGXAKTBSJJfz/qgJ4Gswbo4CASwg3sk9R Jcvk2VVZHBeLusO496Xa7Iyhdh9H1UWI5DRKEenBfz0DWVSELJ/rN1ykpm5SGn5yZJA5 T3qCAIiciOW8ehIInEdMbo7poQOXqotfDQeaOqOZpNli+9CbVkKaQvxMj/o/vDFSdcJ4 7MwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=uxN2K2cQCsbBUAeeVAWn7MaatHvpM/exmo2/f7eSCrg=; b=lZXNH+7f6EbzeNjiivG5+MUzaRq/s3gkjfbBbsco9UN4Kym/eW121PQrUHPJaHefGI 0loeBOxyT5cnluZ6H75n3w5hvvTF36gxpPsBGH/YBk+ysbtgdZXmIvn1ejb+VF0gcZVQ 2dmpG8Ko5BX9P2mGhUOasHckovPmaAZJ6VI1sRWiQhOwD8fET3/EJz9U0COR2CRMu5kT Obx3Ir7Y9+JmruT6zcUCeTIac/Md8v4+sgnlBn+0Ey0hWxPZr4kb/f57OR23KnUovMwF ptrQKJ1ZPg0e/l3yT1JMJ50b9+NH19m1C3g8tvOizR92dL7t/NYzjarNZWkDIOcFwprM dDGA== X-Gm-Message-State: APjAAAVyK9gK9GtMIFklBd00dCMCeZkHtWJWyf3vEvZTQtrRjzXw+y0x 5N8YEXbtqKv5D/5uqLyjVDvVADtmQcKwL3+L06lW5w== X-Google-Smtp-Source: APXvYqxX6CqjvUz5MukTWr2Ea/HgwP+BRWu+Ewj4Q4PuQGCMytgBfsrQXm4i8pT4pvtax2tkvPwHz7xC7HMMnTAo0Zk= X-Received: by 2002:a9f:35eb:: with SMTP id u40mr4748664uad.82.1570113577390; Thu, 03 Oct 2019 07:39:37 -0700 (PDT) MIME-Version: 1.0 From: Sebastian Gniazdowski Date: Thu, 3 Oct 2019 14:39:25 +0000 Message-ID: Subject: PATCH: Link with curses if (and even) if it doesn't provide tgetent To: Zsh hackers list Content-Type: multipart/mixed; boundary="00000000000009ced30594028efe" --00000000000009ced30594028efe Content-Type: text/plain; charset="UTF-8" Hello, I've noticed that on Gentoo the zsh built doesn't include the curses module. Closer look revealed the cause: the ncurses libraries (ncursesw and ncurses) don't provide the call tgetent (nor tigetflag), only tinfo does provide it. I guess this is the next step in splitting libtinfo out of ncurses. But this means that the binary can be linked to both ncurses and tinfo. I've also checked that linking against such tgetent-lacking ncurses and termcap works with no problems. The patch does: - it allows the normal flow of the checks with no changes, - in the "if we need to ignore ncurses" check it adds, in case of positive resolution of the test, an additional check that verifies for initscr() in any of ncursesw, ncurses, curses and if this check is positive, it then allows to link against that found curses library, - it also adds libtinfow (side to libtinfo) to the terminal libraries searched, as such library exists on the Gentoo system. This way the zsh/curses module builds OK. I attach the git-format-patch file. -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org --00000000000009ced30594028efe Content-Type: text/plain; charset="US-ASCII"; name="0001-configure-Link-with-ncurses-if-and-even-it-doesn-t-p.patch.txt" Content-Disposition: attachment; filename="0001-configure-Link-with-ncurses-if-and-even-it-doesn-t-p.patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k1at1diz0 RnJvbSBlNTZiZjcwMGFjYWY0YTUwMTQzZGFlYzE2MjA4YWI4NmM4NTg2ZjljIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWJhc3RpYW4gR25pYXpkb3dza2kgPHNnbmlhemRvd3NraUBn bWFpbC5jb20+CkRhdGU6IFRodSwgMyBPY3QgMjAxOSAxNTo1NDoxNyArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIGNvbmZpZ3VyZTogTGluayB3aXRoIG5jdXJzZXMgaWYgKGFuZCBldmVuKSBpdCBkb2Vz bid0IHByb3ZpZGUKIHRnZXRlbnQsIHRvIGJ1aWxkIHRoZSBtb2R1bGUuIEFsc28gbGluayB3aXRo IHRpbmZvdyAobm90IG9ubHkgdGluZm8pCgotLS0KIGNvbmZpZ3VyZS5hYyB8IDE3ICsrKysrKysr KysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5kZXggYjMxYjFk OTU4Li5jMzMxODg1NjEgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1cmUu YWMKQEAgLTc3NCw3ICs3NzQsNyBAQCBBU19IRUxQX1NUUklORyhbLS13aXRoLXRlcm0tbGliPUxJ QlNdLFtzZWFyY2ggc3BhY2Utc2VwYXJhdGVkIExJQlMgZm9yIHRlcm1pbmFsCiAgIHRlcm1jYXBf Y3Vyc2VzX29yZGVyPSIkd2l0aHZhbCIKICAgQUNfU0VBUkNIX0xJQlModGlnZXRzdHIsIFskdGVy bWNhcF9jdXJzZXNfb3JkZXJdKQogZWxzZQotICB0ZXJtY2FwX2N1cnNlc19vcmRlcj0iJG5jdXJz ZXN3X3Rlc3QgJG5jdXJzZXNfdGVzdCB0aW5mbyB0ZXJtY2FwIGN1cnNlcyIKKyAgdGVybWNhcF9j dXJzZXNfb3JkZXI9IiRuY3Vyc2Vzd190ZXN0ICRuY3Vyc2VzX3Rlc3QgdGluZm93IHRpbmZvIHRl cm1jYXAgY3Vyc2VzIgogZmldLAogW2Nhc2UgIiRob3N0X29zIiBpbgogICBzb2xhcmlzKikKQEAg LTc4Myw3ICs3ODMsNyBAQCBmaV0sCiAgICBETF9FWFQ9IiR7RExfRVhUPXNsfSIKICAgIHRlcm1j YXBfY3Vyc2VzX29yZGVyPSJIY3Vyc2VzICRuY3Vyc2Vzd190ZXN0ICRuY3Vyc2VzX3Rlc3QgY3Vy c2VzIHRlcm1jYXAiIDs7CiAgICopCi0gICB0ZXJtY2FwX2N1cnNlc19vcmRlcj0iJG5jdXJzZXN3 X3Rlc3QgJG5jdXJzZXNfdGVzdCB0aW5mbyB0ZXJtY2FwIGN1cnNlcyIgOzsKKyAgIHRlcm1jYXBf Y3Vyc2VzX29yZGVyPSIkbmN1cnNlc3dfdGVzdCAkbmN1cnNlc190ZXN0IHRpbmZvdyB0aW5mbyB0 ZXJtY2FwIGN1cnNlcyIgOzsKIGVzYWNdKWRubAogCiBBSF9URU1QTEFURShbWlNIX05PX1hPUEVO XSwKQEAgLTgzMSw3ICs4MzEsMTggQEAgQUNfQ0FDSEVfQ0hFQ0soaWYgd2UgbmVlZCB0byBpZ25v cmUgbmN1cnNlcywgenNoX2N2X2lnbm9yZV9uY3Vyc2VzLAogICB6c2hfY3ZfaWdub3JlX25jdXJz ZXM9bm8KICAgOzsKICAgKikKLSAgenNoX2N2X2lnbm9yZV9uY3Vyc2VzPXllcworICAgIGRubCBJ ZiB0aGUgdGdldGVudCBub3IgdGlnZXRmbGFnIHdlcmVuJ3QgZm91bmQgaW4gdGhlIGxpYm5jdXJz ZXMqLnNvLCB0aGVuCisgICAgZG5sIHRoZXJlIHdpbGwgYmUgbm8gY29uZmxpY3Qgd2l0aCB0aGUg b3RoZXIgdGVybWluYWwgbGlicmFyeSBzZWxlY3RlZCAoZS5nLgorICAgIGRubCBsaWJ0aW5mbykg YW5kIGl0J3MgcG9zc2libGUgdG8gbGluayBuY3Vyc2VzIHByb3ZpZGVkIHRoYXQgaXQgaXMgd29y a2luZworICAgIEFDX1NFQVJDSF9MSUJTKGluaXRzY3IsIFtuY3Vyc2VzdyBuY3Vyc2VzIGN1cnNl c10pCisgICAgY2FzZSAkTElCUyBpbgorICAgICAgKi1sbmN1cnNlcyp8Ki1sY3Vyc2VzKikKKyAg ICAgIHpzaF9jdl9pZ25vcmVfbmN1cnNlcz1ubworICAgICAgOzsKKyAgICAgICopCisgICAgICB6 c2hfY3ZfaWdub3JlX25jdXJzZXM9eWVzCisgICAgICA7OworICAgIGVzYWMKICAgOzsKIGVzYWNd KQogCi0tIAoyLjIxLjAKCg== --00000000000009ced30594028efe--