From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 7d92e9df for ; Wed, 23 Oct 2019 17:18:56 +0000 (UTC) Received: (qmail 8263 invoked by alias); 23 Oct 2019 17:18:46 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44865 Received: (qmail 26020 invoked by uid 1010); 23 Oct 2019 17:18:45 -0000 X-Qmail-Scanner-Diagnostics: from mail-vs1-f53.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25608. spamassassin: 3.4.2. Clear:RC:0(209.85.217.53):SA:0(-2.0/5.0):. Processed in 3.776203 secs); 23 Oct 2019 17:18:45 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.217.53 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=tLtM9pli2Iud82VQO5eYBHiS3ar8vSsk3VfJZoi+1GU=; b=eC5haxzZCLxtJG0rLs7q6oZWO99FW3B+FwXx3n4b/4MCDck/FbzBW1ZPlWRXsuIDWD 6gIrNgvyCo19EAmZj86lq7nWli+Lc/EEmHrLZMQTD44x//tfCnpUgm1td5b11F1R32vx n7t9urmNw23JrdRHFi+7FMam67oJ/D/rHWBxyWCnNW2F0em06dSrFgTdPemjbn4fA1KV jR2zcjXKf2aqgZ2MvpY74iL42YmDOhSZwClBOpwyQ7SQYQs8iypMGB38/ilvJdrmHKUr muJ4gYgR4T0F5VP6jyOYaMqrpslJQOtU/fw2cpD1tBsE2amuIY/2HMdnqiEhSJn8i7ab MHXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=tLtM9pli2Iud82VQO5eYBHiS3ar8vSsk3VfJZoi+1GU=; b=Rcsy4wTqoW3NbyTnlf0g578DGvfUQQqB6lZm8aP1SokdH0BbbZ5ZIrfKbM/7AWaP0s BvkuIsTlkWkb8zQuyXHxZYFVRmBYwmEptouk6SXCGxzC/SojjEu8Ug/Nyqs/Fln3cWuR JNEAW9N3OvT2FZQ7V6S349UFx5C56Mxagq9qA066Wq2/Slcfl58e7WF8IoN0kffxK/3V 4OLjn7omkjUpGBL+YN7EYDLxnrqgK3cuKth1hNQrSaQejou6xwdOxvf2iZcWU37NDBVT 3IqN0cy985lJVAwDWbk1NykjTiyiKIyh+begyEA1/pXUPubG4ObzJxVmpExspCuVnAqq qnOw== X-Gm-Message-State: APjAAAWQvOUClA3ZrRIhII5s2fnKvlbRhJd23JB0jCNTYr/gj1oRodcL 9mqQBjXzSChhq/UzrRvEpPjwuzPiSjL8c0WBrSYuIw== X-Google-Smtp-Source: APXvYqy8QshfLayRp9isX81rJd1qieWTVexgMVO1fbasO09UDC+CBtBjMcfYG7xYoJio8tM/wP/MFepDi7KCC8zv3zQ= X-Received: by 2002:a67:ff14:: with SMTP id v20mr6116506vsp.215.1571851088234; Wed, 23 Oct 2019 10:18:08 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Sebastian Gniazdowski Date: Wed, 23 Oct 2019 19:18:01 +0200 Message-ID: Subject: Re: PATCH: Link with curses if (and even) if it doesn't provide tgetent To: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000c1a35c0595971910" --000000000000c1a35c0595971910 Content-Type: text/plain; charset="UTF-8" Hello, I've revised the patch. It has been seriously upgraded: - the checks against the termcap & terminfo functions is being ran again explicitly before deciding to link with ncurses, - more functions are being checked, namely all that I've found tests in the configure for, i.e.: besides tgetent and tigetflag, also tigetstr and tigetnum, - I've also extended the normal- i.e.: previous test with the tigetstr function, as it seems to be most important, because it's the function that's being tested for when --with-term-lib=... is being used. Besides, the update adding tinfow to the searched libs is preserved. I think that the patch is important. Ncurses is being drilled out of termcap & terminfo functions, and this means that the zsh/curses module will never be built. On Thu, 3 Oct 2019 at 16:39, Sebastian Gniazdowski wrote: > > Hello, > I've noticed that on Gentoo the zsh built doesn't include the curses > module. Closer look revealed the cause: the ncurses libraries > (ncursesw and ncurses) don't provide the call tgetent (nor tigetflag), > only tinfo does provide it. I guess this is the next step in splitting > libtinfo out of ncurses. > > But this means that the binary can be linked to both ncurses and > tinfo. I've also checked that linking against such tgetent-lacking > ncurses and termcap works with no problems. > > The patch does: > - it allows the normal flow of the checks with no changes, > - in the "if we need to ignore ncurses" check it adds, in case of > positive resolution of the test, an additional check that verifies for > initscr() in any of ncursesw, ncurses, curses and if this check is > positive, it then allows to link against that found curses library, > - it also adds libtinfow (side to libtinfo) to the terminal libraries > searched, as such library exists on the Gentoo system. > > This way the zsh/curses module builds OK. > > I attach the git-format-patch file. > -- > Sebastian Gniazdowski > News: https://twitter.com/ZdharmaI > IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin > Blog: http://zdharma.org -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org --000000000000c1a35c0595971910 Content-Type: text/plain; charset="US-ASCII"; name="0001-configure-Try-to-link-with-a-curses-library-if-it-do.patch.txt" Content-Disposition: attachment; filename="0001-configure-Try-to-link-with-a-curses-library-if-it-do.patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_k23jioo10 RnJvbSA1YjdkNDNhYmUzZjAxZDNhNzIzMDFmOWI0NGZhZjI4Y2FmZTVkYTI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWJhc3RpYW4gR25pYXpkb3dza2kgPHNnbmlhemRvd3NraUBn bWFpbC5jb20+CkRhdGU6IFdlZCwgMjMgT2N0IDIwMTkgMTk6MDY6NDAgKzAyMDAKU3ViamVjdDog W1BBVENIXSA9P1VURi04P3E/Y29uZmlndXJlPTIwPUUyPTgwPTkzPUMyPUEwVHJ5PTIwdG89MjBs aW5rPTIwd2k/PQogPT9VVEYtOD9xP3RoPTIwYT0yMGN1cnNlcz0yMGxpYnJhcnk9MjBpZj0yMGl0 PTIwZG9lc24ndD0yMGNvbnRhaW49MjB0aGU/PQogPT9VVEYtOD9xPz0yMHRlcmNhbXA9MjAmPTIw dGVybWluZm89MjBmdW5jdGlvbnM/PQpNSU1FLVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRl eHQvcGxhaW47IGNoYXJzZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoK LS0tCiBjb25maWd1cmUuYWMgfCA1NyArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNTQgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9jb25maWd1cmUuYWMgYi9jb25maWd1cmUuYWMKaW5k ZXggYjMxYjFkOTU4Li44ZmQ0ZDQ1MmYgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9j b25maWd1cmUuYWMKQEAgLTc3NCw3ICs3NzQsNyBAQCBBU19IRUxQX1NUUklORyhbLS13aXRoLXRl cm0tbGliPUxJQlNdLFtzZWFyY2ggc3BhY2Utc2VwYXJhdGVkIExJQlMgZm9yIHRlcm1pbmFsCiAg IHRlcm1jYXBfY3Vyc2VzX29yZGVyPSIkd2l0aHZhbCIKICAgQUNfU0VBUkNIX0xJQlModGlnZXRz dHIsIFskdGVybWNhcF9jdXJzZXNfb3JkZXJdKQogZWxzZQotICB0ZXJtY2FwX2N1cnNlc19vcmRl cj0iJG5jdXJzZXN3X3Rlc3QgJG5jdXJzZXNfdGVzdCB0aW5mbyB0ZXJtY2FwIGN1cnNlcyIKKyAg dGVybWNhcF9jdXJzZXNfb3JkZXI9IiRuY3Vyc2Vzd190ZXN0ICRuY3Vyc2VzX3Rlc3QgdGluZm93 IHRpbmZvIHRlcm1jYXAgY3Vyc2VzIgogZmldLAogW2Nhc2UgIiRob3N0X29zIiBpbgogICBzb2xh cmlzKikKQEAgLTc4Myw3ICs3ODMsNyBAQCBmaV0sCiAgICBETF9FWFQ9IiR7RExfRVhUPXNsfSIK ICAgIHRlcm1jYXBfY3Vyc2VzX29yZGVyPSJIY3Vyc2VzICRuY3Vyc2Vzd190ZXN0ICRuY3Vyc2Vz X3Rlc3QgY3Vyc2VzIHRlcm1jYXAiIDs7CiAgICopCi0gICB0ZXJtY2FwX2N1cnNlc19vcmRlcj0i JG5jdXJzZXN3X3Rlc3QgJG5jdXJzZXNfdGVzdCB0aW5mbyB0ZXJtY2FwIGN1cnNlcyIgOzsKKyAg IHRlcm1jYXBfY3Vyc2VzX29yZGVyPSIkbmN1cnNlc3dfdGVzdCAkbmN1cnNlc190ZXN0IHRpbmZv dyB0aW5mbyB0ZXJtY2FwIGN1cnNlcyIgOzsKIGVzYWNdKWRubAogCiBBSF9URU1QTEFURShbWlNI X05PX1hPUEVOXSwKQEAgLTgwNyw2ICs4MDcsOCBAQCBkbmwgVGhhdCdzIHNvIHRoYXQgb24gc3lz dGVtcyB3aGVyZSB0ZXJtY2FwIGFuZCBbbl1jdXJzZXMgYXJlCiBkbmwgYm90aCBhdmFpbGFibGUg YW5kIGJvdGggY29udGFpbiB0ZXJtY2FwIGZ1bmN0aW9ucywgd2hpbGUKIGRubCBvbmx5IFtuXWN1 cnNlcyBjb250YWlucyB0ZXJtaW5mbyBmdW5jdGlvbnMsIHdlIG9ubHkgbGluayBhZ2FpbnN0CiBk bmwgW25dY3Vyc2VzLgorTElCU19zYXZlX3ByZV90ZXJtPSIkTElCUyIKK0FDX1NFQVJDSF9MSUJT KHRpZ2V0c3RyLCBbJHRlcm1jYXBfY3Vyc2VzX29yZGVyXSkKIEFDX1NFQVJDSF9MSUJTKHRpZ2V0 ZmxhZywgWyR0ZXJtY2FwX2N1cnNlc19vcmRlcl0pCiBBQ19TRUFSQ0hfTElCUyh0Z2V0ZW50LCBb JHRlcm1jYXBfY3Vyc2VzX29yZGVyXSwKICAgdHJ1ZSwKQEAgLTgzMSw3ICs4MzMsNTYgQEAgQUNf Q0FDSEVfQ0hFQ0soaWYgd2UgbmVlZCB0byBpZ25vcmUgbmN1cnNlcywgenNoX2N2X2lnbm9yZV9u Y3Vyc2VzLAogICB6c2hfY3ZfaWdub3JlX25jdXJzZXM9bm8KICAgOzsKICAgKikKLSAgenNoX2N2 X2lnbm9yZV9uY3Vyc2VzPXllcworICAgIGRubCBUaGUgbGFjayBvZiAtbG5jdXJzZXMgaW4gdGhl ICRMSUJTIG1pZ2h0IGJlIHRoZSByZXN1bHQgb2YgcGFzc2luZworICAgIGRubCAtLXdpdGgtdGVy bS1saWI9Xm5jdXJzZXMgb3B0aW9uLiBUbyBhZGRyZXNzIHRoaXMsIGEgdGVzdCBmb3IgdGhlIHRn ZXRlbnQKKyAgICBkbmwgYW5kIG90aGVyIGZ1bmN0aW9ucyBpcyByYW4gaGVyZSwgcG9zc2libHkg Zm9yIHRoZSBzZWNvbmQgdGltZSwganVzdCB0bworICAgIGRubCBlbnN1cmUgdGhhdCB0aGUgbmN1 cnNlcyBsaWJyYXJ5IGRvZXNuJ3QgaGF2ZSB0aGVtLgorICAgIExJQlNfc2F2ZT0iJExJQlMiCisg ICAgZG5sIFJlbWVtYmVyICh0aGUgdmFsdWVzIGFyZSB1c2VkIGxhdGVyLCBhcm91bmQgbGluZSAz MDA1KSBhbmQgcmVtb3ZlIHRoZSBjYWNoZQorICAgIGFjX2N2X3NlYXJjaF90aWdldHN0cl9TQVZF PSIkYWNfY3Zfc2VhcmNoX3RpZ2V0c3RyIgorICAgIGFjX2N2X3NlYXJjaF90aWdldG51bV9TQVZF PSIkYWNfY3Zfc2VhcmNoX3RpZ2V0bnVtIgorICAgIGFjX2N2X3NlYXJjaF90aWdldGZsYWdfU0FW RT0iJGFjX2N2X3NlYXJjaF90aWdldGZsYWciCisgICAgYWNfY3Zfc2VhcmNoX3RnZXRlbnRfU0FW RT0iJGFjX2N2X3NlYXJjaF90Z2V0ZW50IgorICAgIHVuc2V0IGFjX2N2X3NlYXJjaF90aWdldHN0 ciBhY19jdl9zZWFyY2hfdGlnZXRudW0gYWNfY3Zfc2VhcmNoX3RpZ2V0ZmxhZyBhY19jdl9zZWFy Y2hfdGdldGVudAorICAgIExJQlM9IiRMSUJTX3NhdmVfcHJlX3Rlcm0iCisKKyAgICBkbmwgUnVu IHRoZSBjaGVja3MgZm9yIGFsbCBmb3VyIHVzZWQgdGVybWluYWwgZnVuY3Rpb25zCisgICAgQUNf U0VBUkNIX0xJQlModGlnZXRzdHIsIFtuY3Vyc2VzdyBuY3Vyc2VzIGN1cnNlc10pCisgICAgQUNf U0VBUkNIX0xJQlModGlnZXRudW0sIFtuY3Vyc2VzdyBuY3Vyc2VzIGN1cnNlc10pCisgICAgQUNf U0VBUkNIX0xJQlModGlnZXRmbGFnLCBbbmN1cnNlc3cgbmN1cnNlcyBjdXJzZXNdKQorICAgIEFD X1NFQVJDSF9MSUJTKHRnZXRlbnQsIFtuY3Vyc2VzdyBuY3Vyc2VzIGN1cnNlc10pCisgICAgTElC U19yZXN1bHQ9IiRMSUJTIgorCisgICAgTElCUz0iJExJQlNfc2F2ZSIKKyAgICBkbmwgUmVzdG9y ZSB0aGUgY2FjaGUKKyAgICBhY19jdl9zZWFyY2hfdGlnZXRzdHI9IiRhY19jdl9zZWFyY2hfdGln ZXRzdHJfU0FWRSIKKyAgICBhY19jdl9zZWFyY2hfdGlnZXRudW09IiRhY19jdl9zZWFyY2hfdGln ZXRudW1fU0FWRSIKKyAgICBhY19jdl9zZWFyY2hfdGlnZXRmbGFnPSIkYWNfY3Zfc2VhcmNoX3Rp Z2V0ZmxhZ19TQVZFIgorICAgIGFjX2N2X3NlYXJjaF90Z2V0ZW50PSIkYWNfY3Zfc2VhcmNoX3Rn ZXRlbnRfU0FWRSIKKworICAgIGNhc2UgJExJQlNfcmVzdWx0IGluCisgICAgICAqLWxuY3Vyc2Vz KnwqLWxjdXJzZXMqKQorICAgICAgICBkbmwgWWVzIHdlIG5lZWQgdG8gaWdub3JlIG5jdXJzZXMs IGl0cyB0Z2V0ZW50IG9yIHRpZ2V0ZmxhZyBtaWdodAorICAgICAgICBkbmwgY29uZmxpY3Qgd2l0 aCB0aGUgb25lIGZyb20gdGhlIHNlbGVjdGVkIHRlcm1pbmFsIGxpYnJhcnkKKyAgICAgICAgenNo X2N2X2lnbm9yZV9uY3Vyc2VzPXllcworICAgICAgICA7OworICAgICAgKikKKyAgICAgICAgZG5s IElmIHRoZSB0Z2V0ZW50IG5vciB0aWdldGZsYWcgd2VyZW4ndCBmb3VuZCBpbiB0aGUgbGlibmN1 cnNlcyouc28sIHRoZW4KKyAgICAgICAgZG5sIHRoZXJlIHdpbGwgYmUgbm8gY29uZmxpY3Qgd2l0 aCB0aGUgb3RoZXIgdGVybWluYWwgbGlicmFyeSBzZWxlY3RlZCAoZS5nLgorICAgICAgICBkbmwg bGlidGluZm8pIGFuZCBpdCdzIHBvc3NpYmxlIHRvIGxpbmsgbmN1cnNlcyBwcm92aWRlZCB0aGF0 IGl0IGlzIHdvcmtpbmcKKyAgICAgICAgZG5sIC0gaXQgaXMgaGVyZSB2ZXJpZmllZCB0aGF0IGl0 IGhhcyBpbml0c2NyKCkgZnVuY3Rpb24gdG8gY2hlY2sgdGhhdAorICAgICAgICBBQ19TRUFSQ0hf TElCUyhpbml0c2NyLCBbbmN1cnNlc3cgbmN1cnNlcyBjdXJzZXNdKQorICAgICAgICBjYXNlICRM SUJTIGluCisgICAgICAgICAgKi1sbmN1cnNlcyp8Ki1sY3Vyc2VzKikKKyAgICAgICAgICAgIGRu bCBObyBuZWVkIHRvIGlnbm9yZSBjdXJzZXMgLSBpdCBpcyB3b3JraW5nIGFuZCBpdCBkb2Vzbid0 CisgICAgICAgICAgICBkbmwgaGF2ZSB0Z2V0ZW50IG5vciB0aWdldGZsYWcKKyAgICAgICAgICAg IHpzaF9jdl9pZ25vcmVfbmN1cnNlcz1ubworICAgICAgICAgIDs7CisgICAgICAgICAgKikKKyAg ICAgICAgICAgIHpzaF9jdl9pZ25vcmVfbmN1cnNlcz15ZXMKKyAgICAgICAgICA7OworICAgICAg ICBlc2FjCisgICAgZXNhYwogICA7OwogZXNhY10pCiAKLS0gCjIuMjEuMAoK --000000000000c1a35c0595971910--