From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 7e158751 for ; Thu, 21 Nov 2019 23:11:15 +0000 (UTC) Received: (qmail 9532 invoked by alias); 21 Nov 2019 23:11:06 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44915 Received: (qmail 21352 invoked by uid 1010); 21 Nov 2019 23:11:06 -0000 X-Qmail-Scanner-Diagnostics: from mail-vk1-f173.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.0/25635. spamassassin: 3.4.2. Clear:RC:0(209.85.221.173):SA:0(-2.0/5.0):. Processed in 4.03415 secs); 21 Nov 2019 23:11:06 -0000 X-Envelope-From: sgniazdowski@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.221.173 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3zQNN/wvLlLC+L9Bl8F4xiCTckM6B7gqjuD6zx6vKVA=; b=hdHYQYDYnE40raGVfRVLXWxh3gzAkHVhbUAWZ827EoYRcOi/2KW/O0CSOuf4p4bD1m X6AXq4cKenDdvbpRLxPZ2/ylhQjUnLRINk0CA2LVwptt232sCYVDdffSlJIHj8cfLpOD bZpMdqioCR+EYdPgh03pKNxJ9z12OhRi+dU3pG0EqCbbbfbze6FE6JFNVbXhUlQUecGr sn+Lr5VAqH6eNdW3JkDO5BwuGqIJKK7oszQHkRcZMGXTEwqfRSSwp4VLi46394ai+Q/D xejJqaLfJdv0D1hDknkI6jGlb93h9e1k/ZBIBQUMtQ8G6qElWTIN/khoGgA/TkRMwT3/ URYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3zQNN/wvLlLC+L9Bl8F4xiCTckM6B7gqjuD6zx6vKVA=; b=jEDw7PiijR03svBIfeLMwG+9Jb/eWgro/TXtukFZkuFpfcrsBqVg3skXS5AxV7SlbU 9PFcm7o1n1w4uWJvkRg5EMBB9pCcD1y4Gmw3gHXZNO66qd+9fLpU+g3NXdF6rAltpcf4 84WHftz7YZv3gx37qnyWX5Agkinkeh1xqi0t2ZXobRm5tGssnFHvRT+vwRoOnpOE3j2b N+EzF1tpgb1bB6W3kRfGGVKH+fna09NcDfNH6GiTppf/sDB1bvicAeVoSOt0bKRwraET F3V3snP01DkZUGRUUetIiFEMS9/LtIxwZmmK+LFRDmmIdyp7JDH8y6AwOHrPN7t0+v3R wrZQ== X-Gm-Message-State: APjAAAXFhpWYIfa3Fj8X1gT81xwAZd1MW9FXcRRnrFzekIRB3Ua9uXh1 rncip2PrePIK1lALkbo+U72SVA7YAYN9Otikc1U= X-Google-Smtp-Source: APXvYqzI2f3PP2QqYJDqVgYoKJZJ/e21pHsd3wKBS7MYFr8Yf+mEdscA2D9QBnMQqvPll2XFHsH3Ioc08YeX1+MNCDc= X-Received: by 2002:a1f:90d5:: with SMTP id s204mr7440050vkd.21.1574377828416; Thu, 21 Nov 2019 15:10:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Sebastian Gniazdowski Date: Fri, 22 Nov 2019 00:10:21 +0100 Message-ID: Subject: Re: Completion for aplay from alsa-utils To: dana Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Mon, 4 Nov 2019 at 00:17, dana wrote: > > On 2 Nov 2019, at 16:13, Sebastian Gniazdowski wrote: > > the submitted completion is in file _alsa-utils Thanks for the review. > And you can add arecord to #compdef, since it's basically the same thing as > aplay True, diff on help messages reveals no differences. > Some functional issues i noticed: > > * _arguments should have -S > > * There are no exclusions for any of the alias options (e.g., -D and --device > should be exclusive) How to add them? > * --device, --file-type, and --process-id-file should take arguments --file-type and --process-id-file take arguments without =. How to add arguments to their spec, should it be +? > * All short aliases of long options that take an argument should have + (e.g., > -c+ for --channels=) > > * -v is cumulative, but there is no * in the spec What do you mean? > Would also be nice to have better optarg completion (there are no argument > descriptions, some of the options take pre-defined arguments that are listed > in the documentation that you could offer, &c.), and taking the option > descriptions from the help output verbatim doesn't look that nice here, but > i'm probably being too pedantic now I think that editing of the descriptions provided the number of options is large would be quite artificial. I mean I could express a few options by my own words, however on long term I would have to drop this because it would be an overwhelming task. -- Sebastian Gniazdowski News: https://twitter.com/ZdharmaI IRC: https://kiwiirc.com/client/chat.freenode.net:+6697/#zplugin Blog: http://zdharma.org