zsh-workers
 help / color / mirror / code / Atom feed
From: Charles Blake <charlechaud@gmail.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix)
Date: Mon, 20 May 2019 08:41:21 -0400	[thread overview]
Message-ID: <CAKiz1a8ZKX2JDwRsAEgHq-W9w4_A-8J6as57p7aa=jjR+tmgzA@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMo9uK1BPqwAF=i7pEbOVuhhSWxVXi75Wb-pMjo9rvkRtQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

So, feel free to confirm yourself with xterm -rw or resource/default or
menu setting of reverseWrap, but with your patch and reverseWrap enabled, I
get incorrect behavior of a different sort.  The cursor is not left
immediately after the 2, but there is an intervening blank space of exactly
1 character.  Flipping the menu item on/off and hitting enter in the shell
to force a refresh toggles the misbehavior.

As to whether this should be a "supported configuration", well that is for
the larger audience to decide.  Obviously for N config bools there are 2^N
configs and supporting them all is probably between impractical and
impossible.  However, the xterm man page under the -rw option section says
this one is specifically encouraged:

    This is very useful for editing long shell command lines
    and is encouraged.

I'm not sure why reverseWrap is not on by default..You'd have to ask Tom
Dickey that, but I would guess it is to support some popular shell/usage
mode.  Or maybe the feature and documentation are vestiges from some long
bygone era.  I haven't looked into it much.

In better news, I also got things to work both with/without your patch in
emacs shell mode under X11 emacs as well as terminal mode emacs -nw.

  parent reply	other threads:[~2019-05-20 12:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 15:38 Roman Perepelitsa
2019-05-19 15:41 ` Roman Perepelitsa
2019-05-19 17:04 ` Bart Schaefer
2019-05-19 17:34   ` Roman Perepelitsa
2019-05-19 18:09     ` Roman Perepelitsa
2019-05-19 18:51       ` Roman Perepelitsa
2019-05-19 20:12         ` Bart Schaefer
2019-05-19 21:07           ` Roman Perepelitsa
2019-05-20  8:21             ` Yannic Schröder
2019-05-20  8:36               ` Roman Perepelitsa
2019-05-20 10:21                 ` Charles Blake
2019-05-20 10:46                   ` Roman Perepelitsa
2019-05-20 11:06                     ` Daniel Shahaf
2019-05-20 11:07                     ` Charles Blake
2019-05-20 11:11                       ` Peter Stephenson
2019-05-20 11:32                       ` Roman Perepelitsa
2019-05-20 12:41                     ` Charles Blake [this message]
2019-05-20 13:16                       ` Roman Perepelitsa
     [not found]                         ` <CAKiz1a-nOkAe42JoxFRgMJ+LXZ3fgMxqgwNZOW+2Y45oqzu8hA@mail.gmail.com>
2019-05-20 13:55                           ` Roman Perepelitsa
2019-05-23  5:48                             ` Roman Perepelitsa
2019-05-23 21:36                               ` Daniel Shahaf
2019-05-23 22:52                                 ` Roman Perepelitsa
2019-05-24 12:18                                   ` Daniel Shahaf
2019-05-27 15:36                                     ` Roman Perepelitsa
2019-05-27 21:51                                       ` Peter Stephenson
2019-05-28  8:44                                         ` Peter Stephenson
2019-05-28  8:46                                           ` Roman Perepelitsa
2019-05-28 14:26                                         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKiz1a8ZKX2JDwRsAEgHq-W9w4_A-8J6as57p7aa=jjR+tmgzA@mail.gmail.com' \
    --to=charlechaud@gmail.com \
    --cc=roman.perepelitsa@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).