From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11014 invoked by alias); 24 Oct 2017 18:14:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 41951 Received: (qmail 2344 invoked by uid 1010); 24 Oct 2017 18:14:29 -0000 X-Qmail-Scanner-Diagnostics: from mail-oi0-f54.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.218.54):SA:0(-1.4/5.0):. Processed in 1.957907 secs); 24 Oct 2017 18:14:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD,SPF_PASS,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: sokolov@google.com X-Qmail-Scanner-Mime-Attachments: |smime.p7s| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=NgacDE2W+d4eGig0SvKtaUxUBbXUj/DQk75L6QLfVrY=; b=pBmbPNB4OI8JhLEHdMxyx9Dzoi4LQvTi8HFTnFx5AikF3GHYmjSINXA2iTIDeN6sSx 6tthtfoniiR/JtyUsB4MBVVmOoBppUc9/DeG3jhfJV3oQAwfIkoZZeG01cmaoWcidzZI KjE7GyO00DmkOqGCHD49w3SerEywZvPl5iRlqUj4c/C0wTESAsvxOAilLvWL9uz0mJw/ QeZoKOThmcCuGRXBoR2S2o44ON3Brwc80Ctsf8Z0YoNKlH/RcbXxpQkZ6k6EmF6gvVw9 T8B5Kzq7Zw5fA5vspmdf/JC+/49sioyzA/G56mJ9WZfPoWVWYYGbu1Mhu6/+/81WktWF iYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=NgacDE2W+d4eGig0SvKtaUxUBbXUj/DQk75L6QLfVrY=; b=duUYYWKg5HKzsn5OtExCRhYS00hOgFejnRwqS+jXTHLRuGCaSsmUpWBM6pB0ABbLSS ouK7hMGm2N5oqHQQFCaGPVcjoZU0w0GAPPNgLrlruNs/W5zNoSIzsG2y3R/oH8bfXHpI 6rRjO/HL+f5Tb4GUBK9TdkfaN4rortJQ3M/gDNpLPvnFIdI2Pd0ThmlI8Ev7ea7P2Fvw 5X0XPf1KjE6yjrzOdqHLJYK2KpjzhmrH0xl6Ai7H5g8ZmaWDWFyIgVHybs+Cyq9mLLqj 5zxkDDkfhmVkG+HlyOUn8ldh7AKg2CaeGfWGRDA4c/K18tRwz3HfWmvtWDaj1paJW8Gg 94xA== X-Gm-Message-State: AMCzsaWod9J1+eKe+CVQmIirZoKyXyQYbdu5h9R0hw8Alh86L06JA9fo P1p+YhLQrLXmjjHU8EIZHOWhA9oI05wiSB6m0MoG6oFy3vY= X-Google-Smtp-Source: ABhQp+T2LDjvhcgo42/Lq+roZLxS5wrLf+Ny6kkNez4XS1Mcw7P3UAcyebL+t5MjJ3XS8+Ufsa4VMsB3RfxLG4mgs4U= X-Received: by 10.157.43.18 with SMTP id o18mr9546233otb.263.1508868861920; Tue, 24 Oct 2017 11:14:21 -0700 (PDT) MIME-Version: 1.0 From: Alexey Sokolov Date: Tue, 24 Oct 2017 19:14:01 +0100 Message-ID: Subject: Use HGPLAIN instead of HGRCPATH in VCS_INFO_get_data_hg To: zsh-workers@zsh.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="001a1141b482a61e87055c4ee8d4" --001a1141b482a61e87055c4ee8d4 Content-Type: multipart/alternative; boundary="001a1141b48287e59a055c4ee82d" --001a1141b48287e59a055c4ee82d Content-Type: text/plain; charset="UTF-8" Use HGPLAIN instead of HGRCPATH in VCS_INFO_get_data_hg Fixes prompt indicator in case if the repository requires a non-default feature. With HGRCPATH, it results in: abort: repository requires features unknown to this Mercurial: ... (see https://mercurial-scm.org/wiki/MissingRequirement for more information) Which, in turn, results in "default" getting reported regardless of what the current state of the repo is. diff --git a/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg b/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg index d4030125c..cd5ef321d 100644 --- a/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg @@ -55,8 +55,8 @@ if zstyle -t ":vcs_info:${vcs}:${usercontext}:${rrn}" get-revision ; then zstyle -t ":vcs_info:${vcs}:${usercontext}:${rrn}" \ "check-for-changes" || hgid_args+=( -r. ) - local HGRCPATH - HGRCPATH="/dev/null" ${vcs_comm[cmd]} ${(z)hgid_args} 2> /dev/null \ + local HGPLAIN + HGPLAIN=1 ${vcs_comm[cmd]} ${(z)hgid_args} 2> /dev/null \ | read -r r_csetid r_lrev r_branch fi fi --001a1141b48287e59a055c4ee82d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
=C2=A0=C2=A0=C2=A0 Use HGPLAIN instead of HGRCPATH in VCS_= INFO_get_data_hg
=C2=A0=C2=A0=C2=A0
=C2=A0=C2=A0=C2=A0 Fixes prompt = indicator in case if the repository requires a non-default
=C2=A0=C2=A0= =C2=A0 feature. With HGRCPATH, it results in:
=C2=A0=C2=A0=C2=A0
=C2= =A0=C2=A0=C2=A0 abort: repository requires features unknown to this Mercuri= al: ...
=C2=A0=C2=A0=C2=A0 (see https://mercurial-scm.org/wiki/MissingRequirement= for more information)
=C2=A0=C2=A0=C2=A0
=C2=A0=C2=A0=C2=A0 Which, = in turn, results in "default" getting reported regardless of what=
=C2=A0=C2=A0=C2=A0 the current state of the repo is.

diff --git = a/Functions/VCS_Info/Backends/VCS_INFO_get_data_hg b/Functions/VCS_Info/Bac= kends/VCS_INFO_get_data_hg
index d4030125c..cd5ef321d 100644
--- a/Fu= nctions/VCS_Info/Backends/VCS_INFO_get_data_hg
+++ b/Functions/VCS_Info/= Backends/VCS_INFO_get_data_hg
@@ -55,8 +55,8 @@ if zstyle -t ":vcs_= info:${vcs}:${usercontext}:${rrn}" get-revision ; then
=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 zstyle -t ":vcs_info:${vcs}:${use= rcontext}:${rrn}" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 "check-for-changes" || hgid_args+=3D(= -r. )
=C2=A0
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 local HGRCP= ATH
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 HGRCPATH=3D"/dev/nu= ll" ${vcs_comm[cmd]} ${(z)hgid_args} 2> /dev/null \
+=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 local HGPLAIN
+=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 HGPLAIN=3D1 ${vcs_comm[cmd]} ${(z)hgid_args} 2> /d= ev/null \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 | read -r r_csetid r_lrev r_branch
=C2=A0=C2=A0=C2=A0=C2=A0= fi
=C2=A0fi

--001a1141b48287e59a055c4ee82d-- --001a1141b482a61e87055c4ee8d4 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIS6QYJKoZIhvcNAQcCoIIS2jCCEtYCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ghBPMIIEXDCCA0SgAwIBAgIOSBtqDm4P/739RPqw/wcwDQYJKoZIhvcNAQELBQAwZDELMAkGA1UE BhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYtc2ExOjA4BgNVBAMTMUdsb2JhbFNpZ24gUGVy c29uYWxTaWduIFBhcnRuZXJzIENBIC0gU0hBMjU2IC0gRzIwHhcNMTYwNjE1MDAwMDAwWhcNMjEw NjE1MDAwMDAwWjBMMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTEiMCAG A1UEAxMZR2xvYmFsU2lnbiBIViBTL01JTUUgQ0EgMTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCC AQoCggEBALR23lKtjlZW/17kthzYcMHHKFgywfc4vLIjfq42NmMWbXkNUabIgS8KX4PnIFsTlD6F GO2fqnsTygvYPFBSMX4OCFtJXoikP2CQlEvO7WooyE94tqmqD+w0YtyP2IB5j4KvOIeNv1Gbnnes BIUWLFxs1ERvYDhmk+OrvW7Vd8ZfpRJj71Rb+QQsUpkyTySaqALXnyztTDp1L5d1bABJN/bJbEU3 Hf5FLrANmognIu+Npty6GrA6p3yKELzTsilOFmYNWg7L838NS2JbFOndl+ce89gM36CW7vyhszi6 6LqqzJL8MsmkP53GGhf11YMP9EkmawYouMDP/PwQYhIiUO0CAwEAAaOCASIwggEeMA4GA1UdDwEB /wQEAwIBBjAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwEgYDVR0TAQH/BAgwBgEB/wIB ADAdBgNVHQ4EFgQUyzgSsMeZwHiSjLMhleb0JmLA4D8wHwYDVR0jBBgwFoAUJiSSix/TRK+xsBtt r+500ox4AAMwSwYDVR0fBEQwQjBAoD6gPIY6aHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9ncy9n c3BlcnNvbmFsc2lnbnB0bnJzc2hhMmcyLmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIG CCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG 9w0BAQsFAAOCAQEACskdySGYIOi63wgeTmljjA5BHHN9uLuAMHotXgbYeGVrz7+DkFNgWRQ/dNse Qa4e+FeHWq2fu73SamhAQyLigNKZF7ZzHPUkSpSTjQqVzbyDaFHtRBAwuACuymaOWOWPePZXOH9x t4HPwRQuur57RKiEm1F6/YJVQ5UTkzAyPoeND/y1GzXS4kjhVuoOQX3GfXDZdwoN8jMYBZTO0H5h isymlIl6aot0E5KIKqosW6mhupdkS1ZZPp4WXR4frybSkLejjmkTYCTUmh9DuvKEQ1Ge7siwsWgA NS1Ln+uvIuObpbNaeAyMZY0U5R/OyIDaq+m9KXPYvrCZ0TCLbcKuRzCCBB4wggMGoAMCAQICCwQA AAAAATGJxkCyMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAt IFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTExMDgwMjEw MDAwMFoXDTI5MDMyOTEwMDAwMFowZDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24g bnYtc2ExOjA4BgNVBAMTMUdsb2JhbFNpZ24gUGVyc29uYWxTaWduIFBhcnRuZXJzIENBIC0gU0hB MjU2IC0gRzIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCg/hRKosYAGP+P7mIdq5NB Kr3J0tg+8lPATlgp+F6W9CeIvnXRGUvdniO+BQnKxnX6RsC3AnE0hUUKRaM9/RDDWldYw35K+sge C8fWXvIbcYLXxWkXz+Hbxh0GXG61Evqux6i2sKeKvMr4s9BaN09cqJ/wF6KuP9jSyWcyY+IgL6u2 52my5UzYhnbf7D7IcC372bfhwM92n6r5hJx3r++rQEMHXlp/G9J3fftgsD1bzS7J/uHMFpr4MXua eoiMLV5gdmo0sQg23j4pihyFlAkkHHn4usPJ3EePw7ewQT6BUTFyvmEB+KDoi7T4RCAZDstgfpzD rR/TNwrK8/FXoqnFAgMBAAGjgegwgeUwDgYDVR0PAQH/BAQDAgEGMBIGA1UdEwEB/wQIMAYBAf8C AQEwHQYDVR0OBBYEFCYkkosf00SvsbAbba/udNKMeAADMEcGA1UdIARAMD4wPAYEVR0gADA0MDIG CCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzA2BgNVHR8E LzAtMCugKaAnhiVodHRwOi8vY3JsLmdsb2JhbHNpZ24ubmV0L3Jvb3QtcjMuY3JsMB8GA1UdIwQY MBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQACAFVjHihZCV/IqJYt 7Nig/xek+9g0dmv1oQNGYI1WWeqHcMAV1h7cheKNr4EOANNvJWtAkoQz+076Sqnq0Puxwymj0/+e oQJ8GRODG9pxlSn3kysh7f+kotX7pYX5moUa0xq3TCjjYsF3G17E27qvn8SJwDsgEImnhXVT5vb7 qBYKadFizPzKPmwsJQDPKX58XmPxMcZ1tG77xCQEXrtABhYC3NBhu8+c5UoinLpBQC1iBnNpNwXT Lmd4nQdf9HCijG1e8myt78VP+QSwsaDT7LVcLT2oDPVggjhVcwljw3ePDwfGP9kNrR+lc8XrfClk WbrdhC2o4Ui28dtIVHd3MIIDXzCCAkegAwIBAgILBAAAAAABIVhTCKIwDQYJKoZIhvcNAQELBQAw TDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24x EzARBgNVBAMTCkdsb2JhbFNpZ24wHhcNMDkwMzE4MTAwMDAwWhcNMjkwMzE4MTAwMDAwWjBMMSAw HgYDVQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEG A1UEAxMKR2xvYmFsU2lnbjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBAMwldpB5Bngi FvXAg7aEyiie/QV2EcWtiHL8RgJDx7KKnQRfJMsuS+FggkbhUqsMgUdwbN1k0ev1LKMPgj0MK66X 17YUhhB5uzsTgHeMCOFJ0mpiLx9e+pZo34knlTifBtc+ycsmWQ1z3rDI6SYOgxXG71uL0gRgykmm KPZpO/bLyCiR5Z2KYVc3rHQU3HTgOu5yLy6c+9C7v/U9AOEGM+iCK65TpjoWc4zdQQ4gOsC0p6Hp sk+QLjJg6VfLuQSSaGjlOCZgdbKfd/+RFO+uIEn8rUAVSNECMWEZXriX7613t2Saer9fwRPvm2L7 DWzgVGkWqQPabumDk3F2xmmFghcCAwEAAaNCMEAwDgYDVR0PAQH/BAQDAgEGMA8GA1UdEwEB/wQF MAMBAf8wHQYDVR0OBBYEFI/wS3+oLkUkrk1Q+mOai97i3Ru8MA0GCSqGSIb3DQEBCwUAA4IBAQBL QNvAUKr+yAzv95ZURUm7lgAJQayzE4aGKAczymvmdLm6AC2upArT9fHxD4q/c2dKg8dEe3jgr25s bwMpjjM5RcOO5LlXbKr8EpbsU8Yt5CRsuZRj+9xTaGdWPoO4zzUhw8lo/s7awlOqzJCK6fBdRoyV 3XpYKBovHd7NADdBj+1EbddTKJd+82cEHhXXipa0095MJ6RMG3NzdvQXmcIfeg7jLQitChws/zyr VQ4PkX4268NXSb7hLi18YIvDQVETI53O9zJrlAGomecsMx86OyXShkDOOyyGeMlhLxS67ttVb9+E 7gUJTb0o2HLO02JQZR7rkpeDMdmztcpHWD9fMIIEZjCCA06gAwIBAgIMHI/A3acBo2jWBaLSMA0G CSqGSIb3DQEBCwUAMEwxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSIw IAYDVQQDExlHbG9iYWxTaWduIEhWIFMvTUlNRSBDQSAxMB4XDTE3MDkxODE4NDQxOVoXDTE4MDMx NzE4NDQxOVowIzEhMB8GCSqGSIb3DQEJAQwSc29rb2xvdkBnb29nbGUuY29tMIIBIjANBgkqhkiG 9w0BAQEFAAOCAQ8AMIIBCgKCAQEAtUmEcHHt8Lec+GzIwyy9bwZWeaoJOCgdsDM+fuju6UH3MjDN ujJ8AMuOF7s7AhDL7N2VzmGK5slJHhdgaTuTlrvu/N8legG78tEAAZUqyrlImAVpgt+p2XkHWuc8 vuVBXRa7N4VqmOyRZKp+UnmFm3sdevJ9CGsr8ciH4yO5WJKai9BIZ4BiF02b8S20zKNBn8sMx3ZT a1jEwfRjWqZH+r52OVO0j2twMUKuFMD2jO0Znx66fdwDwXGn4UKMgJm5iidpWQFR+frZcHhZp0zU TuH1x4K8oXZIHteqUAohglfDgRhxPjXW8lgPCEimGfOapy8ZqGlqpLB2cdcuJ8jt8QIDAQABo4IB bzCCAWswHQYDVR0RBBYwFIESc29rb2xvdkBnb29nbGUuY29tMFAGCCsGAQUFBwEBBEQwQjBABggr BgEFBQcwAoY0aHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NodnNtaW1lY2Ex LmNydDAdBgNVHQ4EFgQUZE3/7DvI57q80AGtWRq3ZjglyLYwHwYDVR0jBBgwFoAUyzgSsMeZwHiS jLMhleb0JmLA4D8wTAYDVR0gBEUwQzBBBgkrBgEEAaAyASgwNDAyBggrBgEFBQcCARYmaHR0cHM6 Ly93d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wOwYDVR0fBDQwMjAwoC6gLIYqaHR0cDov L2NybC5nbG9iYWxzaWduLmNvbS9nc2h2c21pbWVjYTEuY3JsMA4GA1UdDwEB/wQEAwIFoDAdBgNV HSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwDQYJKoZIhvcNAQELBQADggEBAIF18VhhcadrLaTA s7AZKQEFWCbd8YtkARjcu1JsPFObB9G7HrDSBcyL7xkw6YR4Dk9bBsw4QZSQaMaKsNtzBh8PAvN8 dLHLKU4jQwH+dlsgOb56w6K9MIY8dtTfGucSFXKPxc9PVjOOyWguqVtT0/R8IHkRDOK8oBUahGbu pT+9e2rrqjuMkrQuK0z4849X74S2a4mMwatYaAtUYJXFaDiJ6+eBbCkj+JlGZ4AoYpwvisFV0Kta 1gl59xo4HfiRYDPQ+4zGPWJToRXIz59LwFPanXO9TKDVT/+0PmHCKZAcvxUIyxfShCwwjgDvTzvW st1kYpysLZgY6YEZH781pLMxggJeMIICWgIBATBcMEwxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBH bG9iYWxTaWduIG52LXNhMSIwIAYDVQQDExlHbG9iYWxTaWduIEhWIFMvTUlNRSBDQSAxAgwcj8Dd pwGjaNYFotIwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIHY/CyLUyrwTcXc8IeuL YtTy2UpYinVkVNQ/xVzAg72DMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTE3MTAyNDE4MTQyM1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQADdeWkImksAzCTafquhjxIsL3xsGf7ZO3i8Swp lnnbewEqBigZjTxLKYRDG2LGZ5w0nlTeiG4ZANjUw4OSES027JAv6dVvXdJ988hR8Zk4VHSRcOnc RlFKFi+g+mOQdANdOpNdTao97GRHAIobWfd+JHXyj1VM8y1JX2kVmuiSxUgTRshwrpr5ZLUtUqbL 8/j8j3YAd9Jbi0rOsICxItdCTL2boCw63DDfwdVOtyIDBZGtnyVbyLbd4KVWUaURL3oItsqoenUm pzGXcRAUwnOcQvKnDXHSoI4FM3423Q1Y0qeAPk8CZNm8sMxnLIMgK73w+YkxN0eGWMAHkfE32JHy --001a1141b482a61e87055c4ee8d4--