From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25565 invoked by alias); 25 Sep 2015 07:14:52 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 36626 Received: (qmail 6726 invoked from network); 25 Sep 2015 07:14:51 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=G5AM3tg+j4x0FH/Ueups4apVDw4qRH/sIHociwcn2Ww=; b=jVrFl7uNq+UIrgLTDoq0VQLCSuvi4sO85VkeS+aRAdmU8KROZhQpo139EAKzoW5J3F ZrzjyRAf8OnvLuO4kNSvvAYy2/bqhLd/PpSFmzt893PHJZ6T9HE6EcRXWUmEV8lcNLCf gtPFkNEctOSx+9ior0gHRWkz9QINNO1+G7Ntma/VwIQ/DAoD2ZjCjTGlU/qmUg2f6CRE K3P21AeQLsKpfcicwuidtYygc5Vhu+7F2nuMC1atP6BWtcIy4m7msJSPbKpRiJUhvc7+ vEUZNxqAGumytM111kJDvm18rqwjOa3S6Yp9J6tVE9whL9grvrGDw2vWk8Zr/HqtPmNG pI7Q== MIME-Version: 1.0 X-Received: by 10.25.208.141 with SMTP id h135mr758694lfg.81.1443165287165; Fri, 25 Sep 2015 00:14:47 -0700 (PDT) In-Reply-To: <20150924160550.GD1906@tarsus.local2> References: <20150924160550.GD1906@tarsus.local2> Date: Fri, 25 Sep 2015 09:14:46 +0200 Message-ID: Subject: Re: [patch] _hg: completion for 'hg bookmarks' From: Christoph Mathys To: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary=001a114115fe4b553505208d1a3d --001a114115fe4b553505208d1a3d Content-Type: text/plain; charset=UTF-8 Hi Daniel, Thank you for the quick response. On Thu, Sep 24, 2015 at 6:05 PM, Daniel Shahaf wrote: > 1. The function should be defined further up in the file (_hg_cmd_* are > defined alphabetically). Fixed. > 2. --rev and --message need to become --rev= and --message= to allow > both '--rev ARG' and '--rev=ARG' (which both work). Fixed for --rev. > 3. Why do you have a leading '-' on the first and last line? Is it > intentional? They were intentional. I wanted to create groups of mutually exclusive arguments. But on typing the reply I realized that it is very well possible to call '--inactive ', so the patch was wrong. I have done away with the '-' in this version of the patch and it should be more straightforward like this. > 4. How should positional arguments (i.e., 'hg bookmarks ') be > completed? They are currently completed as files; presumably they > should be completed as _hg_bookmarks_internal? Should now always be _hg_bookmarks_internal. > 5. Your mailer munged whitespace in the patch. You should be able to > avoid this by sending the patch as an attachment named *.txt. Done. thx, Christophq --001a114115fe4b553505208d1a3d Content-Type: text/plain; charset=US-ASCII; name="_hg_cmd_bookmarks.diff" Content-Disposition: attachment; filename="_hg_cmd_bookmarks.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iezbbruz0 ZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vVW5peC9Db21tYW5kL19oZyBiL0NvbXBsZXRpb24vVW5p eC9Db21tYW5kL19oZwppbmRleCA5ZGQwMjM2Li5jODRmYWYzIDEwMDY0NAotLS0gYS9Db21wbGV0 aW9uL1VuaXgvQ29tbWFuZC9faGcKKysrIGIvQ29tcGxldGlvbi9Vbml4L0NvbW1hbmQvX2hnCkBA IC00NjAsNiArNDYwLDE2IEBAIF9oZ19jbWRfYmlzZWN0KCkgewogICAnKC0tY29tbWFuZCAtYyAt LW5vdXBkYXRlIC1VKSd7LVUsLS1ub3VwZGF0ZX0nW2RvIG5vdCB1cGRhdGUgdG8gdGFyZ2V0XScK IH0KIAorX2hnX2NtZF9ib29rbWFya3MoKSB7CisgIF9hcmd1bWVudHMgLXMgLXcgOiAkX2hnX2ds b2JhbF9vcHRzIFwKKyAgJygtLWZvcmNlIC1mKSd7LWYsLS1mb3JjZX0nW2ZvcmNlXScgXAorICAn KC0tcmV2IC1yKSd7LXIrLC0tcmV2PX0nW3NldCBib29rbWFyayBhdCByZXZpc2lvbl06cmV2aXNp b246X2hnX3RhZ3MnIFwKKyAgJygtLWRlbGV0ZSAtZCkney1kLC0tZGVsZXRlfSdbZGVsZXRlIGEg Z2l2ZW4gYm9va21hcmtdJyBcCisgICcoLS1yZW5hbWUgLW0pJ3stbSssLS1yZW5hbWV9J1tyZW5h bWUgZ2l2ZW4gYm9va21hcmtdOmJvb2ttYXJrOl9oZ19ib29rbWFya3NfaW50ZXJuYWwnIFwKKyAg JygtLWluYWN0aXZlIC1pKSd7LWksLS1pbmFjdGl2ZX0nW21hcmsgYSBib29rbWFyayBpbmFjdGl2 ZV0nIFwKKyAgJzpib29rbWFyazpfaGdfYm9va21hcmtzX2ludGVybmFsJworfQorCiBfaGdfY21k X2JyYW5jaCgpIHsKICAgX2FyZ3VtZW50cyAtcyAtdyA6ICRfaGdfZ2xvYmFsX29wdHMgXAogICAn KC0tZm9yY2UgLWYpJ3stZiwtLWZvcmNlfSdbc2V0IGJyYW5jaCBuYW1lIGV2ZW4gaWYgaXQgc2hh ZG93cyBhbiBleGlzdGluZyBicmFuY2hdJyBcCg== --001a114115fe4b553505208d1a3d--