From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9347 invoked from network); 2 Jan 2021 18:30:35 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Jan 2021 18:30:35 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1609612235; b=xtK8G8WGPesGU315ATlwtJChSp5Qd6BLLkna6CsfBI6vJbs3zyd1wQY+BDlbbWpC/ix0CZGsxT LvhnpoDWAUjh1u1TYFr+bJEXWCmDmFGC03SM/C/EzG6zGvvihpA8EQH3HyTDKHBU/CcPAK17ll 9BfPbEKkdozOGQHBPnEU03JdM1pbzvj6OurzCe7Hamjkjt2W8JVIzmglbhHaacrogPgU33sl6k 9RWjqkp1BV7G53IreKxo+RLFfj4wNOZtp8jkenibOzJTt4K0lQ51Q2mKM09CPAuymqegFGF6Vd nl7rYMCuFwqnSAaP60o76jpwaSmnoK7QpP1CGgi7cwQkAg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wm1-f52.google.com) smtp.remote-ip=209.85.128.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1609612235; bh=uj3iTbZwkTTDAp03zNihb8DrxHLy6Ric6BpjnYRA7Ag=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=nEtT60aZ09vPDy/GS7p4r3amHp8ubT898OEuC4Fy1LfQc+1d65E/Kzekuj3UN9j5dS8bexWX79 7LGEoxyoUYucJ4y7GayXf40SI22fFbBpmr0fnz2NgsOqb8jQ2L1WsJhICqPH7bPu05wcUyZaAb vSeJKn2ZvQCYPNPyNu1ywOFKvXl+MVKz/jldwRh03K57xYVxEvWzIF/3cTZRrOeC3SGblBBzsw lAe82Qei3Sz+BswGh6CBRzpfvw1yuLT3RloVznivlF9Uy1HNtdxOWBM9pUmwta0AJ2HSX7sWvv i42fRJThbwL4fkQlj/gIz0RyiiZVFg73AcSSj28g0sZc/A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=T3XXUZLrRrFxvbjxAVnoq5MzOtyXOzBZ2c5fQPglD+w=; b=gewI3CCjJ4Z0ShM6NkozlNUtP7 RBhynA1Fnqs6PD02NEnMOrbY3eU4DjkgBR0jcTv93qt1Gk7xhgjTlI7FNmD3rX/jjQ5RWqk5dD3+Y 8YeDyDiw4ehxNc5QGiEdC/m72ycliUMfR8gr6fnySibZi/UluiWIyoaWFzCTz1KIP3rttW5UfRR3T TShCbCibsB2AtzvxmHFDKN51WiTqnxJuJZ7Q2g3GdcmMOGFYSensLTIPED1cY74Ibx6SflVPKNMyo bR1Sn3SDvrk2i8DRuDg+gyOcvgcNIlnzPTpUPtAQDa3Oh89mo4JGfQceyNX2YGCENEwrm6JPf0hG9 xwxtmYew==; Received: from authenticated user by zero.zsh.org with local id 1kvlfd-000G0S-7h; Sat, 02 Jan 2021 18:30:33 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wm1-f52.google.com) smtp.remote-ip=209.85.128.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-wm1-f52.google.com ([209.85.128.52]:33278) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kvlfS-000Frd-2M; Sat, 02 Jan 2021 18:30:22 +0000 Received: by mail-wm1-f52.google.com with SMTP id n16so5888502wmc.0 for ; Sat, 02 Jan 2021 10:30:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=T3XXUZLrRrFxvbjxAVnoq5MzOtyXOzBZ2c5fQPglD+w=; b=dJS3Q/tfIvj+TiLtUuCSKOg68UkNZEcYAY2wnp/ZPulvoOVoJ1XDVnssR4u79vjMHP WFdikl6S/QTw+ewiIJpvehQIn/F/6TP/jFkNHAbpSJ91Ln4WSBsdiusgI6pljPH3fc+Q +hGAgtfCm+lnCx77U1VdmB2GTjaGTpsoHXSH1Zz+wIlzWUjO7d0r2QcCREWiRMZvoVEP WVDa4G6Kj5MQArVXBvuACOYjdH8xfrhHkd1/jdkRi/gy0Qpieo2VC1Q2rtcpQAjnUVUY o3tGotaFcfg9BuiOq300MODSiQ6aLhNWMy/yFClKFxTdq99WldMQtIiyFjgqMZ80C4R/ mqVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=T3XXUZLrRrFxvbjxAVnoq5MzOtyXOzBZ2c5fQPglD+w=; b=qtCrSGmrIOUVutusKgu01vGt6Iwcx33QeJZkX8KSJq/GgUlAK0kQVL5iQTtGekPF7h Z2BxWwRAJqDY3yp4VOYPHG0ATY/hE2TShsDZccSTQefUN5RnQADhJbTRovkdcvoT4Xt5 wipYgVG3BW24caKJm1qx5vWikIqWMUvl4VBGtJbv1Jmj9sP4dosPWeoPlZhtNE5QNAOM KKu/UrNFWEzymmodle0zDRMeAd3+j9tXmV+0GmWcsWpm4ar0S51vS61TQ/n9YKg2bA5D D0SsVB2xaS5YupLmGnOoF5KLGKqk3cln0QB34mknmJ6OmYjyDllAIw01q59sOl9WoWHr 3V8Q== X-Gm-Message-State: AOAM533lPrisZCUIPpmRTDbKqmvZ/ag2Ew+Uyein94S2hNwd4l0l1rzf fEEa/CG0+x55fAi/XY7MC47TOnWnK4uXKvGMi+lEgF6+ejA= X-Google-Smtp-Source: ABdhPJyCnKWGiO6WZ6LC0h+/15RanS0i3exvYZcqvwi6drt3SecwKXjJlT7+lJyzZTm3uZ1Fsb5M8w4xkVi6OJMSCOU= X-Received: by 2002:a1c:df57:: with SMTP id w84mr20003071wmg.37.1609612221725; Sat, 02 Jan 2021 10:30:21 -0800 (PST) MIME-Version: 1.0 References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> In-Reply-To: From: Felipe Contreras Date: Sat, 2 Jan 2021 12:30:11 -0600 Message-ID: Subject: Re: [PATCH 1/3] src: fix build warnings To: Mikael Magnusson Cc: Daniel Shahaf , Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 47789 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Sat, Jan 2, 2021 at 10:41 AM Mikael Magnusson wrote: > If we ever return the address of tmp, bad things are likely to happen > regardless of the static so hopefully that never happens. Returning > the address of a local variable basically means it will be junk > (current hypothetical behavior), whereas returning a static means the > function wouldn't be re-entrant (hypothetical behavior with the > patch). Correct, but one is more proper than the other, and it gets rid of the warning. The best fix is to allocate one byte, especially if it's going to be freed later on. -- Felipe Contreras