From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19467 invoked from network); 2 Sep 2022 09:55:32 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 2 Sep 2022 09:55:32 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1662112532; b=dVu3BcgIn2tBN3VllrbvHg0+zwt/5q8zXo2arR1tdfkq4npgDUnTAyWKDyKkUyzd2U2URPAY11 /9T6ywgACSRQMK7qbSKxbkPhEb9IV38iDnXDDE06rQFzNqvf/gAZ02JJK0dLlmGICs//zs4YUc yUKtclxWfT1uDYzRMGCt7DuKLpK3muPWepwJkEIQcwHrSKAEfBttcCxpnW75lSObr2AZ/IHddw /WvxX8fa4M9YjbRPfDEuGNcyyc7HDcFf2VEhTM4aK30+0IfjnY8c7K+o6UzWKBSaeYteAbpSIG 10NlK6I+LSNj1YlfLDqB4kIryJMDkr+qmrDpv5yk/7XmKQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1662112532; bh=I3GzoOEkFJyrqW8D1Tg6OK1YNtUMRTw5lScNaVuXukA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=k9jvIKYlhOTpzEWFujOyEBURhtrcBOh34jgh0TNTSN7ezVhmY9uIa5ZwA7XsssCRtxduAuUj/K RxFozeNRxAmNPY4q3azwNVik6H3Ia3txy6cgbmk/H9EH3slwJ+hXmlMHvlzf5mcq9FQwntL6df kI9K7K+tNLVtQTy15o0y1MIM3MKzvea2HAmH+CMBgmLYXGsIdVwaV/SbxugXR0DGtDMqAYs/Ue yi/PNWQYOmTMzIIRRz/l+AUWwcHao5B+dQt9mUYLzLw9I5P5qq429jDXWeDyrN577w6pNc6e4g ISgWXEd9zFinou1mWXXVHaMsJ8fOyAwTyduaoxILt/jHfQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qnkdTwoWGCINRJXmAuSAImZjlxyMI/x79FrVTd4ZOPw=; b=Lu+WjOsGh4WECT78qtvTn3IKNc EpuKva6hDoWvcYCJ7UvR5d2up9KBioWEJ86LngKgypnqkAy+O2LSAdd5vAMgYhT0h66gXK3tFcWO+ vyUTZlNRBJoa9LKo0d1NnOu2jD35TK+9AAnNHslGgLBGgaOvrThbg+T0N/KrjsYboDD0nP9kpKLzr xZcz4iIKSgPO4w5WWqi+CBA1/fiYynFcK1XyeGSKk543USbiPs7rJnDeiZ9PQeBY6oBrSa3PdQzPy 2dlnWEgaS+I0P8dlQmidw+sCkO37v3zIVh4UdcQoqpYwc0AokDWXq6oR8L3k39ixEiovIn5RxwMo0 BHmzWLjg==; Received: from authenticated user by zero.zsh.org with local id 1oU3Oe-000Ppd-9n; Fri, 02 Sep 2022 09:55:32 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f51.google.com ([209.85.218.51]:45704) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oU3JF-000PNP-Sm; Fri, 02 Sep 2022 09:49:58 +0000 Received: by mail-ej1-f51.google.com with SMTP id lx1so2714527ejb.12 for ; Fri, 02 Sep 2022 02:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=qnkdTwoWGCINRJXmAuSAImZjlxyMI/x79FrVTd4ZOPw=; b=p5ed5ez8ydnhMQR8mJ2LHgwqW6kQnpdIJnmI0XsHyien4FUQsl9p91ejxSOma0DW7D 4lti6ygBXJ8nWDnKN4gi7GgynP0/cA1WLflfZrJf1aUXODyu4sSdrJnZYXHwu5+x53oC A5Rgu3RDqb7gXfKYFdMqfTpX+r9dI+FxgikRAv5LVGglvx7rAVTujsuGf9OiG3aqKYIW VwOtmj86go0XQhUqTtZ+FrFQT2IFEueky+yPHaAUHr2iCU7ZSdmbkENMLjcdvJzfQmAC VTB5RxGE5RMtBDPyhnhsXmOTDWp7PGp6xdSC6PFQzzR5mNysHvLWqCdeIoGA/VEvbB3H YScw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=qnkdTwoWGCINRJXmAuSAImZjlxyMI/x79FrVTd4ZOPw=; b=XRIwU1aNwjnfCCFDDg/MHfWSJkGj0AOHuVr7D2dtDwjHR3tx3pxqgcFhegumc0oxFc MWfKMOR52l/F6aNuLbR2FHO6hSK2oJFQXg6TQ6P2QJp7K6wiRVwt7tpb8AEzJKnJIYnG UGtt1Hw2aLp5pYhw3PACi7ZZbcVOQL6yEaNaRP03Mn4N2S8Vsms841ySysr3H0F/w23a ioNKYuDSWIvLPd2YqSlk5FQZ6WHBgdZLYAIDVYN0rFhRSvCgqEQvm61J+rNMyrGozZAp beS5X38dheItWI090DCDZj7zodbtcb4cJreaGINPv4QHlid1RIZ2arJL6tcPGcYnSPGm qM/A== X-Gm-Message-State: ACgBeo236T19k16Y6Df3G9dbsD60h2k5YyogErlU3PA6809+yKL8zV68 tssElY5un69om96lRD8ZCd1wa9ARnjJd72nE7Ak= X-Google-Smtp-Source: AA6agR5kyviLdn11o0j9IumdBGyX7SE+Q6yA/UDm0Od/5HQcUV/eaFkhes0kxKu4lpj0/MVsE7m3Sd7Yo+HylEaSPLY= X-Received: by 2002:a17:906:7954:b0:742:7a6:b179 with SMTP id l20-20020a170906795400b0074207a6b179mr12775553ejo.679.1662112197482; Fri, 02 Sep 2022 02:49:57 -0700 (PDT) MIME-Version: 1.0 References: <20220831031854.27312-1-felipe.contreras@gmail.com> <20220831031854.27312-3-felipe.contreras@gmail.com> <20220902090132.GG5920@tarpaulin.shahaf.local2> In-Reply-To: <20220902090132.GG5920@tarpaulin.shahaf.local2> From: Felipe Contreras Date: Fri, 2 Sep 2022 04:49:44 -0500 Message-ID: Subject: Re: [PATCH 2/2] Increase default HISTSIZE to 1000 To: Daniel Shahaf Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50575 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Fri, Sep 2, 2022 at 4:01 AM Daniel Shahaf wrote: > Felipe Contreras wrote on Tue, Aug 30, 2022 at 22:18:54 -0500: > > If the default is sensible it's not necessary for the user to change it. > > > > Signed-off-by: Felipe Contreras > > --- > > Etc/FAQ.yo | 13 +++++-------- > > Functions/Newuser/zsh-newuser-install | 1 - > > StartupFiles/zshrc | 2 +- > > configure.ac | 2 +- > > 4 files changed, 7 insertions(+), 11 deletions(-) > > > > diff --git a/Etc/FAQ.yo b/Etc/FAQ.yo > > index dd573767e..4c058c363 100644 > > --- a/Etc/FAQ.yo > > +++ b/Etc/FAQ.yo > > @@ -1626,19 +1626,16 @@ work?) > > sect(Why is my history not being saved?) > > label(321) > > > > - In zsh, you need to set three variables to make sure your history is > > + In zsh, you need to set two variables to make sure your history is > > If 1/2 is accepted, this sentence will be true for zsh 5.10 No, it's true for all versions of zsh. Right now the default value of HISTSIZE is 30, therefore the text is wrong, you don't need 3 variables, you only need 2: HISTFILE and SAVEHIST. In fact, I just learned APPEND_HISTORY is on by default, this means a HISTSIZE of 30 is actually quite useful. You don't need to increase it to make sure your history is written, you only need to increase it to make sure you don't lose any history of your current shell instance. Either way you don't *need* to set it, with this patch or without it. And patch 1 certainly doesn't change the situation. All it does is make sure SAVEHIST is the same as HISTSIZE, whether it's 1000, 200, or 30. HISTSIZE can be removed regardless of the previous patch. -- Felipe Contreras