zsh-workers
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Patch 1/3: Fix prefix insertion logic
Date: Mon, 1 May 2023 17:37:45 -0500	[thread overview]
Message-ID: <CAMP44s0OW6C9knL3GZ=k72GiaVfzKR9rp3rrJQADE4GpCeRv_w@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDvjmWTrdG_vWuOSdpAsZP2riZe9V4MfFt08HhU9e=16-g@mail.gmail.com>

On Sat, Apr 29, 2023 at 2:03 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> On Sat, Apr 29, 2023 at 9:58 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > On Sat, Apr 29, 2023 at 1:09 PM Marlon Richert <marlon.richert@gmail.com> wrote:
> > I don't know what's zsh's policy regarding sending patches, but
> > personally I can't review zero content mails.
>
> Looks fine to me on the mailing list archives:
> https://www.zsh.org/mla/workers/2023/msg00409.html

Yes, and I suspect in many mail clients as well. But not in Gmail.

A standard way to send patches is with `git send-email` which sends
the mails generated by `git format-patch` as is. Notice that your
attachments have "From", "Date" and "Subject" mail fields, so they can
be piped to sendmail.

> Should I copy-paste the commit message into the email's body next time?

I would recommend to configure `git sendemail` as sending patches to
any mailing list becomes much easier.

But again, that's my personal recommendation, I don't know if there's
any zsh guideline.

-- 
Felipe Contreras


  parent reply	other threads:[~2023-05-01 22:38 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-29 18:07 Marlon Richert
2023-04-29 18:08 ` Patch 2/3: Make dynamic dir completion easier to implement Marlon Richert
2023-04-29 18:09   ` Patch 3/3: Fix subscript completion bugs inside ~[...] Marlon Richert
2023-04-29 18:58 ` Patch 1/3: Fix prefix insertion logic Felipe Contreras
2023-04-29 19:02   ` Marlon Richert
2023-04-29 19:17     ` Bart Schaefer
2023-05-01 21:08     ` Aaron Schrab
2023-05-01 22:03       ` Bart Schaefer
2023-05-05 11:41         ` [PATCH 1/3] Fix _prefix " Marlon Richert
2023-06-07  6:03           ` Marlon Richert
2023-06-08 12:41             ` Jun. T
2023-06-15 14:11             ` Marlon Richert
2023-05-05 11:41         ` [PATCH 2/3] Make dynamic dir completion easier to implement Marlon Richert
2023-05-06 17:28           ` Bart Schaefer
2023-05-13 17:30             ` Bart Schaefer
2023-05-15  9:04           ` Oliver Kiddle
2023-05-05 11:41         ` [PATCH 3/3] Fix subscript completion bugs inside ~[...] Marlon Richert
2023-05-01 22:37     ` Felipe Contreras [this message]
2023-05-01 22:52       ` Patch 1/3: Fix prefix insertion logic Bart Schaefer
2023-05-02  4:49         ` Felipe Contreras
2023-05-02 19:16           ` Bart Schaefer
2023-05-02 20:14             ` Felipe Contreras
2023-05-05 11:51           ` Marlon Richert
2023-05-05 12:38             ` Felipe Contreras
2023-05-05 15:04             ` Mikael Magnusson
2023-05-06 17:23               ` Bart Schaefer
2023-05-01 23:36       ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMP44s0OW6C9knL3GZ=k72GiaVfzKR9rp3rrJQADE4GpCeRv_w@mail.gmail.com' \
    --to=felipe.contreras@gmail.com \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).