From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6822 invoked from network); 11 Aug 2022 19:44:52 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Aug 2022 19:44:52 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1660247092; b=QrFQyrGpu1m1P/oshikQFafTa8C7vtnl/0inUE8KbUtM6z4qAJypuO0KQ+fMISEVqNOWC2lOI7 hs2oLNqMTB6YTlLnAQulvyJOMgLoZrDXWE+cTqsEUGqZeiingKWyq88QFqrWgc+zZBXMPrCQ2A mZTvqb9GqJD8m+k5b5L12besxkba9+EskcLqswU+r6SBKWhDxMNCgtfP0w2MKqh4/VhDBTJnbc 8IbDWa0L9/dbIBk/YssdbDSWmAvYHOt5rZzlvb6aINByaWpWm1RK80vQzTWhgS4AImEwF3NSFT IaxyOg2pas+S49Ehv8aZSFkmCH9+ruN30JucSpWF8LeGXQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f49.google.com) smtp.remote-ip=209.85.208.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1660247092; bh=33G8JNwOEvvClm3Fd3VG8genppevCQzdTaQktqAtbBk=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=cx6mvy1tHDOD8TvQOYoP5Eoa80r/N8gTVGNd8anDM0boLslewcJluBhUeIf0oYn3HLPMydgK4I hqUIS0uuq4dmVJxD+V3eNNdagdC9cMMZ9nIAlAuHBjyPSYfZTy1QSic3TjF1T0cJNpeBjGFl+3 S/FGi08yNbMllsDje7S1ZLsEjzzeg+nU2eUqJSFLWm7xF1MNzVyk8AqWJrSnelhH1Bj7yJh80B 1kvvGhSz1DsH0pGznG8VrdT4l2qzKcNze2guTCDimTSbd98c93QpKUZ0PhLt6OsAPVFqtko16E BsZGSlOlo/hrnRseDEctIFK+qSZip9OFdPka6SA2xr9F5w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=jEUXIEZbKhyP1JXjymt53KXxG1TILuP4rPHA9xV1rG4=; b=Q+XG9yauqExv0jPcq/o1nijuyo i2zww48WLk48GtXjuvvoChTwWm9ZxcJmIYNXbgjbr7W5F9iprhCc8UwJIb25votqu0nqDBV1N9krn 2MUA4mViktHr5xUU/5EAVPt+5fGz8B5I686E/bhGwhSXPcd1qFmPxl6CuwiZshO+LjuFt22h/lBOD OGB+PFBqb+47tnnixjRSBCTe77t5WMlChfhdHiXRtUQj49/XLdYjKm25+R0UmXCXDlheSu2+eSNX7 XOiNlVRZshhR6HtrrTKbXxSPABWJ9hBD5/U2aSEsRZGnVgMTMvbog13Yh5qDXp01iyfj/EKk+FO/A EAMRHRfA==; Received: from authenticated user by zero.zsh.org with local id 1oME6t-000Md3-EH; Thu, 11 Aug 2022 19:44:51 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f49.google.com) smtp.remote-ip=209.85.208.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ed1-f49.google.com ([209.85.208.49]:33378) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oME6Z-000MIu-Qj; Thu, 11 Aug 2022 19:44:32 +0000 Received: by mail-ed1-f49.google.com with SMTP id b96so24328333edf.0; Thu, 11 Aug 2022 12:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=jEUXIEZbKhyP1JXjymt53KXxG1TILuP4rPHA9xV1rG4=; b=NLWnpqHw+uHMg3m+a1rmixVNMAcCWeXQzLUbGrTwtNHyXiqRhGWuaJsHibw+Ygcb0G 7IvUH12mCJ1UUBz+2HqSXZDWE3WAagaBM59+ke4s8bevAFZZTXPAtzY43y55aUIlK8qw 5AzNvElkFBNe1BuHnwctXxqbelerHDx0lqvqpBuX95NtXc7OqokxIamLDGYDPpQ3aNHj ClZQ+j2UV4Tch50wWuoAG2aowZFxPz6ZjdfXa23rxqzmcVaDp9A/sIhD+ORe3LUe7uJH bRL0UVAiE3nAOPuLJR2fQ89H27ws/4sP7KJ6XRgGEBvcmzGPBqj128bOh6SDUJJfRK/R Jyqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=jEUXIEZbKhyP1JXjymt53KXxG1TILuP4rPHA9xV1rG4=; b=6JEY52UW/MQ+1gSIJdTw1g8G61DV6l9CSZcqQ8Qw0ZvfPsA3pZKnnTbi7ZgQ0OCqt/ GcigF/iIDk4bEXS91B03G6lnClol5/oyGiGS6stl2xJhodJ0RkHYbMk36rez/869Z73P Pi+WCuWAXLhmB7WJo79Eohq/xsRgSr76jPyoEZkDGamgtgg6kLdvkH7gBwCAz3laD4u/ tSkgWGgkAiS4fOlE/j3HzG8vmu8+Rms3jx6wQ274JSKeJYZDITEiUyGm82uhqsODKPmb K2AunlEP0XMh/VxDxfLBIUnST4OVDABDEogLuzt7yAeSSZjljNQhW+A59C7XSexqCmjO pJFw== X-Gm-Message-State: ACgBeo0rgjt4APPX5PyeKkpF2tM18j4CzDKNCpJQI1N5emz2zmM03ayx x6H38FMGNarDGtEB6x7rYwQVe8ZDFI8SlFwQPA7giDGUzKg= X-Google-Smtp-Source: AA6agR4O5x/mi49BOS4cHSGlDJNJQ6CEjG7EH7jglxL/MlBQQlrZ9n3RYXSyH1K8lgCwy8gy5MZOrSnrY78B9AmLJFs= X-Received: by 2002:a05:6402:329b:b0:43d:bd4b:2f08 with SMTP id f27-20020a056402329b00b0043dbd4b2f08mr609572eda.244.1660247071339; Thu, 11 Aug 2022 12:44:31 -0700 (PDT) MIME-Version: 1.0 References: <20220810115120.182853-1-felipe.contreras@gmail.com> In-Reply-To: From: Felipe Contreras Date: Thu, 11 Aug 2022 14:44:20 -0500 Message-ID: Subject: Re: [PATCH] prompt: support generic non-visible regions To: Roman Perepelitsa Cc: zsh-workers@zsh.org, Oliver Kiddle , dana Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 50466 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Aug 11, 2022 at 2:35 PM Roman Perepelitsa wrote: > > On Thu, Aug 11, 2022 at 9:24 PM Felipe Contreras > wrote: > > > > On Thu, Aug 11, 2022 at 12:24 PM Roman Perepelitsa > > wrote: > > > > > > On Thu, Aug 11, 2022 at 4:37 PM Roman Perepelitsa > > > wrote: > > > > > > > > I like this patch [...] > > > > > > I should've said that I like the idea behind it. The patch implements > > > one part of it. To complete the implementation percent expansion need= s > > > to output \001 and \002. > > > > That's easy. The current code in prompt.c uses Inpar and Outpar, which > > are 0x88 and 0x8A respectively. If instead we do: > > > > #define invis_start ((char) 0x01) > > #define invis_end ((char) 0x02) > > > > And replace Inpar/Outpar with invis_start/invis_end the code should > > behave identically (since those characters are removed). > > > > Then in promptexpand() we simply not remove them. > > Let me clarify. Ideally we want (I think) for these two tests to pass: > > 1. > > [[ $(print -r -- ${(%):-'%{hello%}'}) =3D=3D hello ]] > > 2. > > [[ $(print -r -- ${(m)#${(%):-'%F{1}=E2=9D=8E%f'}}) =3D=3D 2 ]] > > The first test currently passes, the second fails. In my previous > comment I tried to say that making the second test pass will cause the > first test to fail. > > Do you see how to make both of these tests pass? We could add a mode to the % flag which is passed to promptexpand() in order to tell it to not remove the invisible start/end markers. However, in my tests this simply adds two characters to $((m)#...}. I don't see how this would return the correct amount of visible characters. --=20 Felipe Contreras