From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org, Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: Alignment issue with multiple describes
Date: Sun, 21 Apr 2013 03:31:53 -0500 [thread overview]
Message-ID: <CAMP44s0mnhRbq6pfhKDAE_moVyab0cR2tvuOmVzPjmE1f49S-g@mail.gmail.com> (raw)
In-Reply-To: <130420232740.ZM12405@torch.brasslantern.com>
On Sun, Apr 21, 2013 at 1:27 AM, Bart Schaefer
<schaefer@brasslantern.com> wrote:
> On Apr 20, 10:03pm, Felipe Contreras wrote:
> }
> } I've noticed a problem when using more than one
> } describe: the completion's description is aligned, but only to the
> } same description, even if they are not grouped.
>
> In part the issue here is that they *are* grouped, implicitly, as you
> can see here:
>
> schaefer<504> foobar
> Completing commands
> one -- command one
> two -- command two
> Completing extra
> extraone -- extra command one
> zbiggertoshowthealignissue -- extra command two
>
> That you've chosen not to display the groups separately doesn't mean
> they aren't grouped internally.
Well, I didn't choose it, that's the way it is by default.
> Curiously, though, the above happens for me only the very first time that
> the completion is tried. Here's my second try:
>
> schaefer<504> foobar
> Completing commands
> one -- command one
> two -- command two
> Completing extra
> extraone -- extra command one
> zbiggertoshowthealignissue -- extra command two
>
> There's no difference in shell code executed (_complete_debug output), so
> the whole problem seems to hinge on whether compadd has been invoked at
> least once before. As a third example, if I complete after "ls --" to
> force a long list of options, and then complete after foobar, I get this:
>
> schaefer<504> foobar
> Completing commands
> one -- command one
> two -- command two
> Completing extra
> extraone -- extra command one
> zbiggertoshowthealignissue -- extra command two
>
> Note that the alignment is "correct" but with a lot more whitespace
> than the previous "correct" display.
>
> This is ringing a very distant bell. I think that in order to get the
> alignment right, you have to be sure to compadd [and thus _describe]
> the longest strings first; compadd has no way of knowing how many
> groups there will be, and can't go back and fix up a previous group
> when aligning a new one, but it does remember the greatest length it
> has seen in all groups so far, and aligns everything against that.
>
> Leaking that length across separate ZLE passes, as appears to be the
> case with completing for "ls" first, is probably a bug -- something
> should be getting reset on zle entry or exit, but is not.
That is indeed very interesting, but to me, it's a bug that the output
of the first completion is not the same as the second. And that it
also depends on the order of the _describe commands. The completion
clearly waits until all the _describe commands have been issued, and
then renders them (ordered), so couldn't this maximum width be
calculated at that point?
The second bug about the leaking of the length I don't think is that
important. The user probably won't even notice.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2013-04-21 8:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 3:03 Felipe Contreras
2013-04-21 3:03 ` Felipe Contreras
2013-04-21 6:27 ` Bart Schaefer
2013-04-21 8:31 ` Felipe Contreras [this message]
2013-04-21 18:27 ` Bart Schaefer
2013-04-21 20:59 ` Felipe Contreras
2013-04-21 21:09 ` Mikael Magnusson
2013-04-21 22:00 ` Felipe Contreras
2013-04-22 6:59 ` Bart Schaefer
2013-04-22 7:30 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s0mnhRbq6pfhKDAE_moVyab0cR2tvuOmVzPjmE1f49S-g@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).