From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29479 invoked from network); 24 Aug 2022 23:00:14 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 24 Aug 2022 23:00:14 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1661382014; b=eKEN8fiBRNvGkD6o3sqE617Lf0JzfShWyljYfIh2/ZM8gXM17E6Tu+rKxchk+ur0ZPWev+JBrL 9zr19s5RD7nvT0HhKxj3rtDMvhAUK/OKozK+mZtK+p1cmiX08u3mWg6BTt72gefaFEDTB7UJ3E v1KR7w83Fonsik0Os+q4tINFngc0nhNwbGM/ojTWFUbiytz+yLhsTGkJdYiwnTg1j6RpDOy/K7 oHjZFjp23qRpQ0Z7+KaCvWjKjRinw5IJo+JesMmWH+/f/I6fylhqK8Ths1pvwAw8Djz92Pcnmg ZSIOFjW0q40GZbioeiYJPDz/YdrDJjFcW1VYRprVSiU6lQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f41.google.com) smtp.remote-ip=209.85.208.41; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1661382014; bh=AoycRRQ9sWJL0k0LQdGLcKroKX2JM5LkBfG/Klb/mAA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=lFlLalI3pPBNxUPf/KC2+xsi/SiwGStf/MmtKJzTplgxVYJJqH2+49vFNil2gqZvjILXKO1ngy 56Xht30FrjvVw7oM77BzGvolzn+Z4OMQWh5luCb2vp3zVJIEioMDAtT7gMWnrAXXPnBbKPuyR+ fSzUlvLHmw4+zz6TrdjMmDD2VxCAtjNp7SAlNB3uWTSIBnsQLxg3iDyDVEgY949x7iSYGLYuuH wspGE9B3tbk2G3EhdQBw/ok/fqCxc82MdFP6Y6wBOHQ2Aw5gFTmhIE2eQZO9WB4Xqxg2C0iA4s g67tZRCLy5r2i0NGxAE+Y02e6ab/cgZdEUiuyAaQ3M8R5g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=xWiPrYYLHZXhsq7WY1iR8Vp+GM0g+pJybJHqxlX495s=; b=rLITpOXd76RZP1X/38SAGLsq2E wcr8tudyyMcn3kalKPiyE4OU5obddFP9RfzFo7td++GmEJ7n/W58z3W1vZ933Prh2nsRtpRRotOEp E7KQ51URObnM+vNF2zHLKgOjKV8tQKLzmIB3ClFg8hys7nC5g7r+5+NEpaHTF+1VRfGuhMsZkfbHT PyIxOgks7mpDpvtM3Jl4EiQSoF5M2mv1W/5vLGFOAfrwOD+vpML80ltXSSdNnIfQDWx0dZAIVwaNa r7a1cQG0d5rLZORRppPLvvHtcEQgv7AFzo6qqvj7KokVDjvqaJXENC3DzI1SQUI+ZN3pZEnP5R1i7 bXRUfISA==; Received: from authenticated user by zero.zsh.org with local id 1oQzM5-00007A-PG; Wed, 24 Aug 2022 23:00:13 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f41.google.com) smtp.remote-ip=209.85.208.41; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ed1-f41.google.com ([209.85.208.41]:45923) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oQzGx-000Pby-ER; Wed, 24 Aug 2022 22:54:55 +0000 Received: by mail-ed1-f41.google.com with SMTP id u6so18852380eda.12 for ; Wed, 24 Aug 2022 15:54:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=xWiPrYYLHZXhsq7WY1iR8Vp+GM0g+pJybJHqxlX495s=; b=L5lnUR33F8vV3I2tcdgYViijwzJsS22mZefSJ2nkDh3MlDoxfgyqKBvc087WsbSvtF svxaZB8ez15frsv/WbOJ97R0oEKjivo+NqeWnYFsXZ1nEGEu0oYuJrqD9NUJQl6s85y3 ylA7WzhyDsuyc2d7y/g4crntL/RduPyv0A3fmo5fBF5MMXSHDus2WPL1gIKIVUw3sf0n A8Nllo7XaQgKsHN+e4hr9IWR+eIAvYZbIt9IdvIBbmZevaiW30Kz7p5+bd9c0w9iyXkr Xn0rTMTgB2YT2BV7MeTH+xAPAHcou+a2oSUmDufspNMi+p9njotU0wN+S5Okgl8VIqy4 7AlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=xWiPrYYLHZXhsq7WY1iR8Vp+GM0g+pJybJHqxlX495s=; b=NxeaorQ06UdN98oToUH0HnduC0mmHdZhInFqZbOXF5h2L4NsrJA48YPg7qTpz36Psy Yl0uyQ4TnO3bxncBnok5IOwPpg9r8oW/0ylfOWMGZPzbRIJtfkQmv712e5Au2A3n59D/ VduzSt8Y9jIAH6g30bwQuCWGnTh2fkp55k7Dhn21YBvLfOF99211kQ3cjIGwYlnL1UBI w65cn4DAes4cRyXbOt2TzZY3UWGX4OGV9uYKda0VPQitYmi1H2s0X+3WhdFuVIaaeAlp ruoBOfkAH0jC3KzWaFY/HvTOIljl8xFb9AVGZaaX2AAqe1lxFZ6644dufasvkTxvCbHh h/QQ== X-Gm-Message-State: ACgBeo2EOT/Yj07dLfuerrUyXBxWBD8GVOAjIYMdeagmvL1q/Rtn+7KF NnA7JK9JhEICxJAvq0FGqcVppTIVGCxilj1QfI8MO1J6Vh4= X-Google-Smtp-Source: AA6agR4MKmYRSrBcOO68U5Rh442DcSegvClMUA5w7bCg6Xt/hkNMOxdCOrXq9wuqID7a7HDAHhq/ExDoo7sAYdxm8Ow= X-Received: by 2002:a05:6402:238b:b0:446:5861:5b4 with SMTP id j11-20020a056402238b00b00446586105b4mr943560eda.280.1661381695008; Wed, 24 Aug 2022 15:54:55 -0700 (PDT) MIME-Version: 1.0 References: <20220824043145.165779-1-felipe.contreras@gmail.com> In-Reply-To: From: Felipe Contreras Date: Wed, 24 Aug 2022 17:54:44 -0500 Message-ID: Subject: Re: [RFC PATCH 0/3] Improve defaults To: Bart Schaefer Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 50520 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Wed, Aug 24, 2022 at 5:18 PM Bart Schaefer wrote: > > On Wed, Aug 24, 2022 at 2:50 PM Felipe Contreras > wrote: > > > > On Wed, Aug 24, 2022 at 3:58 PM Bart Schaefer wrote: > > > > > > Side-effects upon existing uses of "fc -p" are not > > > considered, > > > > How are they not considered? > > "fc -p" with no other arguments explicitly resets the variables to > their defaults. Yes, which includes HISTFILE="", so SAVEHIST doesn't matter. > The current default for SAVEHIST is zero, so having > that become nonzero is an issue. How? Saving 1000 lines to "" is a no-op. If the user does "fc -p tmp_history" then SAVEHIST will not be the default, but whatever the user has specified. > Changing the default HISTSIZE is less of a concern but still affects "fc -p". Only if the user hasn't set HISTSIZE. I'm not familiar with "fc -p/P", but I read the code, and I fail to see the issue. > > > nor are use cases involving SHARE_HISTORY, APPEND_HISTORY, > > > INC_APPEND_HISTORY, and HIST_SAVE_NO_DUPS, > > > > Once again, how are they not considered? > > Simply that usually when any of those are set, which is not uncommon, > it makes much less sense to have equivalent values of SAVEHIST and > HISTSIZE. Yes, but if the user has set APPEND_HISTORY, and SAVEHIST=HISTSIZE doesn't make much sense, then the user surely has set SAVEHIST to a value that does make sense (i.e. not 0), therefore changing the default value of SAVEHIST is irrelevant. > As I said, that's probably a case where they're all being > set anyway, but these patches aren't helpful. The default values don't have to be helpful in all configurations, only in the majority of them. For all the rest the user can specify something other than the default, like they are doing right now. -- Felipe Contreras