From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Mikael Magnusson <mikachu@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] prompt: support generic non-visible regions
Date: Thu, 11 Aug 2022 18:22:41 -0500 [thread overview]
Message-ID: <CAMP44s1HmwR5rN605cNM7L20xop2Sj2g5oP1CUdCpsvqSa-9jA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Y9P+Ho+Wc8h67_GHe9-LmvuiAx4dMEHHyH9wB+x4YORQ@mail.gmail.com>
On Thu, Aug 11, 2022 at 3:38 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Thu, Aug 11, 2022, 2:47 PM Felipe Contreras <felipe.contreras@gmail.com> wrote:
>>
>> > > It's the same: what we do in zsh with `%F{color}`, we do in readline
>> > > with $'\001\e[31m\002'.
>>
>> This is my sincere belief. You are free to not believe it is.
>
>
> This is getting a bit silly, but:
>
> While the above is generically true, given "color" is a placeholder for a set of possible escapes of which "31m" is a specific example, it is not true that $'\001anyrandomstring\002' in readline is accomplished via %F{anything} in zsh.
Fine, if you really want to be punctilious: "%F{red}" =>
"\001\e[31m\002", and "%F{$color_name}" =>
"\001\e[${color_code}m\002".
I don't see what this has to do with the patch.
Anyway, since I haven't seen any comments regarding the actual code of
the patch I've resent it with the updated commit message.
--
Felipe Contreras
next prev parent reply other threads:[~2022-08-11 23:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 11:51 Felipe Contreras
2022-08-10 18:59 ` Mikael Magnusson
2022-08-10 19:56 ` Felipe Contreras
2022-08-11 14:02 ` Mikael Magnusson
2022-08-11 14:26 ` Felipe Contreras
2022-08-11 18:32 ` Mikael Magnusson
2022-08-11 18:47 ` Felipe Contreras
2022-08-11 18:54 ` Mikael Magnusson
2022-08-11 19:46 ` Felipe Contreras
2022-08-11 20:38 ` Bart Schaefer
2022-08-11 23:22 ` Felipe Contreras [this message]
2022-08-11 14:37 ` Roman Perepelitsa
2022-08-11 15:21 ` Bart Schaefer
2022-08-11 16:20 ` Felipe Contreras
2022-08-11 16:49 ` Bart Schaefer
2022-08-11 18:48 ` Felipe Contreras
2022-08-11 17:24 ` Roman Perepelitsa
2022-08-11 18:55 ` Roman Perepelitsa
2022-08-11 19:23 ` Felipe Contreras
2022-08-11 19:35 ` Roman Perepelitsa
2022-08-11 19:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s1HmwR5rN605cNM7L20xop2Sj2g5oP1CUdCpsvqSa-9jA@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).