From: Felipe Contreras <felipe.contreras@gmail.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] prompt: support generic non-visible regions
Date: Thu, 11 Aug 2022 13:47:08 -0500 [thread overview]
Message-ID: <CAMP44s20U2b682vY4e2Wv7HcdDMsnkwn541v_mbHvh2tfyy+Gg@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3Ro=aS+oLTuYUaRNX46tmHCCQ4UNcEY790bviax-PEGRg@mail.gmail.com>
On Thu, Aug 11, 2022 at 1:32 PM Mikael Magnusson <mikachu@gmail.com> wrote:
> On 8/11/22, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> > The commit message says:
> >
> > 1. We do readline $'\001\e[31m\002' as zsh '%F{red}'.
> >
> > This is true.
>
> The statement is true, but it's not what the commit message says, it says:
> "readline assumes anything between \001 (start of header) and \002 (start
> of text) is non-visible characters.
>
> In zsh we do this with `%F{color}`"
It's the same: what we do in zsh with `%F{color}`, we do in readline
with $'\001\e[31m\002'.
> I don't know why you are arguing about this, there's nothing bad about
> fixing an error in a commit message after someone points it out.
I don't believe it's an error. You are the one that is arguing it's an error.
Regardless of what you choose to call it, it will be changed. I don't
need you to believe it's correct, and you don't need me to believe
it's an error.
The end result is the same: it will change.
--
Felipe Contreras
next prev parent reply other threads:[~2022-08-11 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 11:51 Felipe Contreras
2022-08-10 18:59 ` Mikael Magnusson
2022-08-10 19:56 ` Felipe Contreras
2022-08-11 14:02 ` Mikael Magnusson
2022-08-11 14:26 ` Felipe Contreras
2022-08-11 18:32 ` Mikael Magnusson
2022-08-11 18:47 ` Felipe Contreras [this message]
2022-08-11 18:54 ` Mikael Magnusson
2022-08-11 19:46 ` Felipe Contreras
2022-08-11 20:38 ` Bart Schaefer
2022-08-11 23:22 ` Felipe Contreras
2022-08-11 14:37 ` Roman Perepelitsa
2022-08-11 15:21 ` Bart Schaefer
2022-08-11 16:20 ` Felipe Contreras
2022-08-11 16:49 ` Bart Schaefer
2022-08-11 18:48 ` Felipe Contreras
2022-08-11 17:24 ` Roman Perepelitsa
2022-08-11 18:55 ` Roman Perepelitsa
2022-08-11 19:23 ` Felipe Contreras
2022-08-11 19:35 ` Roman Perepelitsa
2022-08-11 19:44 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s20U2b682vY4e2Wv7HcdDMsnkwn541v_mbHvh2tfyy+Gg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).