From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 32314 invoked from network); 11 Aug 2022 18:47:37 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Aug 2022 18:47:37 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1660243657; b=Hq+aNoff5kuK+r9eEyHYsVdL8NifbTXXyebnTDuAkVYELT50Yg8JjEb57PRQiOEQzzPTuIDfgC LEYXdlFyP6C36bIwJdq83HGnSes9Oksm+mPaF5KGknCE6SK4L9qNe37NjGL32OB7cFYurS+1zT GYVYJS5omzaF2DPKkYD5IfbX/c0RI9/TOQL9QvvEYzudGRGfvU+5+3yYaOVGpyS///ASoD/QuL UoovNYYy827m3NwbuJ4qPRXtZqq+LK5QIPRvVY6SFmsHbDARYCX5hkmuLJCWQnb4jGgoYIdzid x8QBXoPxWa8TXu9tSxAiyDXbxe9u7gjcfI1f/ocNEDwwVA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1660243657; bh=UaOcM6FrOI9lXDpqm3p1xzIoiP0aUcPLnyrP7NYKZnc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=qrEgLOhJjegZDiAAOon7oWVt0W3h1Hvioq/a7Og2g0HzV8/qdKaEtezldyjhwPulikwDd1senE QznlXCp2sz+Q4Xntnhza0xmp958q5TnT0gybunan+1Jzxfp+joXdUx8+9O5OcPhbU7+bW6ayvz gIL7IIiiWCEmNDfY/9Kr/Vhsfk6DKEueTHa2J/t9/TVsLCIpNtJUg8nw7Ek/eQ3ocRn71pCXQb /RzKSN5Ok3F/1EZamYTDAgOxjpJ6jGaeTDRCqS2tyUra8uuxP0AmGymiyvPTaSX/ykK8z8+cT8 Q12pPYi/WtriPswf8Fu5F1JUeAdLB3UGi6TbozDdDPEQcg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=GVPPUZBrGbZMO3R+347OFVudHm1YSJQh5TgMoCaWA/Q=; b=BBhSQAfh21liq+UFY3PinA4jFT VVjWIAfjFmr7OVdINsQqIV2XFGlUPdQQoThb/FlothYzaYLDaMKbuMyAnHM+dmg1J3EgHEupTI3EU 9TwB9q+kEv3RDXpyR0XuvtqpG7pD/+R9j/3+VGZ7Z3bgd55EHBQZyw8lwl/816JCIxHTQuOzsVuhs OwHfGhzdW+AhGUeIj382OZJKdrCVKcn4Ix2tn1NxpkDXECiqIIbZzsvUnVF9EYpCpwa8VvonxfV+y gGSJ1CxQ1mexrufOtffYzUYVpjUJTwIKWdDzAe9TJo1Ayjz5Vq6ZHsla1JtpAj7fdTUgzF1xju9r4 B9VjbsmQ==; Received: from authenticated user by zero.zsh.org with local id 1oMDDU-000HdT-VH; Thu, 11 Aug 2022 18:47:37 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f51.google.com) smtp.remote-ip=209.85.218.51; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f51.google.com ([209.85.218.51]:37823) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oMDDE-000HJb-Cp; Thu, 11 Aug 2022 18:47:20 +0000 Received: by mail-ej1-f51.google.com with SMTP id kb8so35043270ejc.4 for ; Thu, 11 Aug 2022 11:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GVPPUZBrGbZMO3R+347OFVudHm1YSJQh5TgMoCaWA/Q=; b=dZ99yPo8gazIEoGbDff+rMvVVckru2A7gbneS55KiDN85iWGWYkm37SnbCGd/kzQH1 INi0ZoHfQoq7b7/hC9QgPTZYdVkOQiMWKI161yRYEt/CZ9Y4SZusvppTo7WlZwIeiwfO WLou+zWEDZDbB3hCF8hqEC2NiTpPyBb5f+pzWoR2KLma35qUxz6qkZYIAAjhUcNcsK/S nHk/t7ig90VZidcpruOP/LJGl/m8wTRwAl3PYaZHJxpVYrg+ZNdP6Jse1fYN9AhAz5rC /i4w1s7LRRBDlcXZDIJjy0ASISWRPYbqD2SweZbt8E5nJekcXvnmIVYQcFqlwcM38Ijr ODKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GVPPUZBrGbZMO3R+347OFVudHm1YSJQh5TgMoCaWA/Q=; b=WhY9ACaHmyzv/cn2eYOxdeqPHciFflkV06T+yLNPfkHabIKPw7CjqGS3TjGMmfHORx mgwx/P/FFzvL/Cn2I98KtsL/0nLX7stUP4UisZXGGsvjG2iSNExF4++0xC/ktktPZwUI 7mI6X0eUqCWYDbwsrJiq8fU8CITpPsY93f9KR6u4dcJxyxz5iLhQjrixT/C4G3opyugP CAGSyso+6JroMky9ZoTa+s01cPXlOpUpwmTnjc7Te8wk3voP7bl0fq8nDzCVdvAfxH38 XbxxrJEJ/+m83fnTLlsVo4H+XYz6+b7EMV9XrWKBITClobJTWIvtJHkYnrFeXJ28ou7O XaIw== X-Gm-Message-State: ACgBeo1UkPOMYvchdtcJb7M/g/C8wT/3RvZDNaUXmYo3DTovq/t/Iw3b Hrlq/Cw5YRUwQGbdDgeohXY++CJ+L7b/P1yX/Fg= X-Google-Smtp-Source: AA6agR7a7tmJI8NSKr/yqZZ3zTmGwIovZ+x7BtxKrIQPPTOcNlhbQqcOF6xldaAIzjcq3V1ANK1UzqBJFF1ep+MHAR0= X-Received: by 2002:a17:907:94c7:b0:730:d5bc:14c with SMTP id dn7-20020a17090794c700b00730d5bc014cmr303975ejc.68.1660243639934; Thu, 11 Aug 2022 11:47:19 -0700 (PDT) MIME-Version: 1.0 References: <20220810115120.182853-1-felipe.contreras@gmail.com> In-Reply-To: From: Felipe Contreras Date: Thu, 11 Aug 2022 13:47:08 -0500 Message-ID: Subject: Re: [PATCH] prompt: support generic non-visible regions To: Mikael Magnusson Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50460 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Aug 11, 2022 at 1:32 PM Mikael Magnusson wrote: > On 8/11/22, Felipe Contreras wrote: > > The commit message says: > > > > 1. We do readline $'\001\e[31m\002' as zsh '%F{red}'. > > > > This is true. > > The statement is true, but it's not what the commit message says, it says: > "readline assumes anything between \001 (start of header) and \002 (start > of text) is non-visible characters. > > In zsh we do this with `%F{color}`" It's the same: what we do in zsh with `%F{color}`, we do in readline with $'\001\e[31m\002'. > I don't know why you are arguing about this, there's nothing bad about > fixing an error in a commit message after someone points it out. I don't believe it's an error. You are the one that is arguing it's an error. Regardless of what you choose to call it, it will be changed. I don't need you to believe it's correct, and you don't need me to believe it's an error. The end result is the same: it will change. -- Felipe Contreras