From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4989 invoked from network); 11 Aug 2022 19:29:20 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Aug 2022 19:29:20 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1660246160; b=HHJybz4QRbdoq76GiO9PcRlr4PnZa9kVJIvvbp01HexFeCQD/X9IK9Szo+0JN66dWvnxfomIko fQnfsS1eWz0aTlgvba/La/pNnToPqM+FCrzo8m4+Ohec8eQbPu7igTFz2ogFrzR7AHncB4lKra wW6jh8DuHSj7JmflI0ZN+gRsmTgKVYY3zj2bRHFmclJWtFRN1pvSGXYJUc4V8rF75ojaN5jDIH xNQLJ+JYqmiWf3Mt9JaB9ZwJBAuoVCRMdd9ZZm8MB5FjOcTXed4z2u6ycvKvyFhy8BMITLO9S2 hwxzTZWGm//qhMmpgICkKGLPcWAR2c4raRQOum6eQ9KAEg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f52.google.com) smtp.remote-ip=209.85.218.52; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1660246160; bh=TEnq5WZlMO7CXHAPza2grhLN5mtvToWt9cPLXS59sas=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=By5B55cqR1k3An7JpFcv56ZogRepz1YIdDqKVKc+4n5pAqXKSIF4LOksULIhXGper256zfTiTU sXdLLJwUo+/gXy/MobbtZTpqXj2x+LvFMC2kPYG5zqC//YQR/Du14a+9mAynYthOGh67mnB3N4 6fL9QjDarJWY0xWKtcrW3rVH+Oqg1WpIAFcAoAt+s0bCItmDOrqnEeYCdIeFYanr3vqycxvboc LDJwjtgKyQ8UXjLYi3NE8ldnLk+hDRFNSSXGl6BRmpptqBZyehbCU6/EeqRCEpreZvC5pjc3Er Qct106qTZk0gWzOFz1jROSF/d/dFxOeIhgzgVpUOkEnidQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=OosZUPz68nuLS5qIAxVk2UGD60J3yZM/L3LL8YNiEZw=; b=I7a19hVlNvj2XvjZn6dU1zuz0x 50Gg6my46fpJwgHqyoJBogSX0Z6MY3zCdTLiToFIu+roepCreteQC1TPFK9yiHTo5kYAbkUZqMXt8 h5fV6DbMzBovsDjDjBhw4qd7MFkrUAHr20wM11b9hlX/NAP6okxwFsSL0cscjdjOywKFpgIji+k38 mfkReoaCFWvfBWUfVMa96cIrhSABNKoq8gglkX+6liadEvwYLBeNU++VgbpnPAtE8tdhmKGa9odkA WaI6VGRPKqjNpcK14wXurF5s+6EVPLrcC2yByzr5wr4jV8/YJ9sgU2q8fCvXRcBcdFWeKERYounvw vHdOb5Fw==; Received: from authenticated user by zero.zsh.org with local id 1oMDrs-000L7w-56; Thu, 11 Aug 2022 19:29:20 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f52.google.com) smtp.remote-ip=209.85.218.52; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f52.google.com ([209.85.218.52]:46746) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oMDmk-000KT0-50; Thu, 11 Aug 2022 19:24:02 +0000 Received: by mail-ej1-f52.google.com with SMTP id y13so35107458ejp.13; Thu, 11 Aug 2022 12:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=OosZUPz68nuLS5qIAxVk2UGD60J3yZM/L3LL8YNiEZw=; b=ll2UKVtvLnEr5X4tyHe1D5bGqs0VcuqavJoTkXEKFvPpBxPHILaAY5tGn86GAxqC0a N6qpmnGKOdtpWBdcMT1uyaddirc7VTfyzcvPiMDC1zXzXDBWcn4UErxbAZK+b5j3vR2c g60DedBs76+YbCX5z2WeTPEZ+zcEUEjRRLlji3vWKg+Phr+PO/fu+cRT6ZB0nghrCuLB 6ysc2yL0URTJ293paqU0blRl/HzRnwckWizjwTi92N8qFwmdHm9kvvWLdh/HDCesWEuE Ghu1JFHwjvnMNomMKBqq+RFw6PziLrdrPA0faQAc0i2M/C79cJ8czTz6kjACVVnRHzts PLIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=OosZUPz68nuLS5qIAxVk2UGD60J3yZM/L3LL8YNiEZw=; b=1NSN5gDgOPKUz9tNG2MRz83YjqtUH9Wt35LawHNsyTtTSNKSFvFDrf0ezRTPG8ZHkM qRLZHiATDeBOwZTB8EXjCI73nXhkDPvpdnKjgtJtYa02nnjjU1ODVKRoof+eQtAJoyfn hVuXbBWnZr+U48jet2Jc0J/GgGNVGVoSh92AJJgUMi0ASOVB682l/Et86Mp19n57YE/j 7pF06IPjGsI2Yc5du4GBYa9ivd4tvFThO7MSA1x65wLHhRLLHIhvwfwCmurFIow1tHcd vus37sgjdOs0XIN+zC1fBgm8MXdPb9Kn/tz1NnqwO86ree98coCq3UYQJ/VnLg2BsjSq jjuA== X-Gm-Message-State: ACgBeo1s40PkwbimiPL0orkW4A7UuxudJ9SFs7ljZInyQZe15FfxRYKz m3jw7aJ4FPHJvd06FNjydqrPZihsFqnenYCM4Hk= X-Google-Smtp-Source: AA6agR7nVM+9UfKhGjeRxRg43zN2vq1IAerCQz1DZDD9eP8/hq78LjpTZYXaTZoj9anoCuYcJP25kGtV7BedhtOmsx4= X-Received: by 2002:a17:907:2c62:b0:730:d9b9:aabb with SMTP id ib2-20020a1709072c6200b00730d9b9aabbmr391377ejc.84.1660245841684; Thu, 11 Aug 2022 12:24:01 -0700 (PDT) MIME-Version: 1.0 References: <20220810115120.182853-1-felipe.contreras@gmail.com> In-Reply-To: From: Felipe Contreras Date: Thu, 11 Aug 2022 14:23:50 -0500 Message-ID: Subject: Re: [PATCH] prompt: support generic non-visible regions To: Roman Perepelitsa Cc: zsh-workers@zsh.org, Oliver Kiddle , dana Content-Type: text/plain; charset="UTF-8" X-Seq: 50464 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Aug 11, 2022 at 12:24 PM Roman Perepelitsa wrote: > > On Thu, Aug 11, 2022 at 4:37 PM Roman Perepelitsa > wrote: > > > > I like this patch [...] > > I should've said that I like the idea behind it. The patch implements > one part of it. To complete the implementation percent expansion needs > to output \001 and \002. That's easy. The current code in prompt.c uses Inpar and Outpar, which are 0x88 and 0x8A respectively. If instead we do: #define invis_start ((char) 0x01) #define invis_end ((char) 0x02) And replace Inpar/Outpar with invis_start/invis_end the code should behave identically (since those characters are removed). Then in promptexpand() we simply not remove them. I'm not sure if leaking these characters is what we want though. -- Felipe Contreras