zsh-workers
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Roman Perepelitsa <roman.perepelitsa@gmail.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug with unset variables
Date: Thu, 12 Nov 2020 15:48:41 -0600	[thread overview]
Message-ID: <CAMP44s3hqCW38Axt151JnmJEcymOtWNfaXoqunfPUco3m0A5Jw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7ZwyKq_RxM_RXWu42Y-RbCkRtrLTqesfqCmFNc_C_CwoA@mail.gmail.com>

On Thu, Nov 12, 2020 at 1:26 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Thu, Nov 12, 2020 at 10:47 AM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > No. Zsh is not consistent. I did not type /typeset var=''/, I typed
> > /typeset var/.

> So now we have to decide what to do when with local variables.

Which is probably the main purpose of typeset (i.e. local).

> They
> can either have a totally new semantic, or we can follow the semantic
> for globals.

Syntax is not semantics.

  var=
  typeset var=

These two have a very similar syntax, so it makes sense that the
semantics are the same. But there's no previous equivalent of "typeset
var".

> Guess which one makes more sense when you are adding
> local scope to a language which previously had only two possible
> conceptions of variables (exist and are empty, or do not exist at
> all).

There's a third conception; a non-empty value.

  var=
  typeset var=

  var="foo"
  typeset var="foo"

These are obvious. The only thing that is left is deciding what
"typeset var" does. These are the options:

1. Errors
2. Nothing
3. Changes the scope
4. Changes the scope and sets an empty value
5. Changes the scope and sets an arbitrary value

Obviously 1 and 2 are not useful options. 5 doesn't really make sense,
and 4 is a subset of 5. More importantly; there's already ways to do 4
and 5.

So why not do a) something useful, b) something that isn't arbitrary,
and c) something that can't be done in other ways?

> That said ...
>
> > Adding a setopt option for the new behavior doesn't break a lot of
> > existing zsh code.
>
> It probably wouldn't break any _scripts_ even to modify the behavior
> of KSH_TYPESET for this.  Whether we can cleanly perform an implicit
> unset in the C code structure, and (if not) whether cobbling this in
> is worthwhile, I haven't investigated or formed an opinion.

I have already started some experiments.

At first glance there doesn't seem to be any straight-forward way of
doing this, but I'm not familiar with the code either, so it would
take a while for me to reach any conclusion.

Either way it seems clear to me reorganizing the code to make it at
least possible will remove many of the weird checks and corner cases
scattered all over, or at least make them more understandable.

We'll have to see.

Cheers.

-- 
Felipe Contreras


  reply	other threads:[~2020-11-12 21:49 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11 15:57 Felipe Contreras
2020-11-11 16:13 ` Roman Perepelitsa
2020-11-11 16:56   ` Felipe Contreras
2020-11-11 17:02     ` Roman Perepelitsa
2020-11-11 18:03       ` Felipe Contreras
2020-11-11 18:16         ` Roman Perepelitsa
2020-11-11 20:42           ` Felipe Contreras
2020-11-12  0:20             ` Mikael Magnusson
2020-11-12  1:10               ` Felipe Contreras
2020-11-12  8:45             ` Roman Perepelitsa
2020-11-12 10:47               ` Peter Stephenson
2020-11-12 18:48                 ` Bart Schaefer
2020-11-12 19:49                 ` Felipe Contreras
2020-11-12 18:46               ` Felipe Contreras
2020-11-12 19:10                 ` Roman Perepelitsa
2020-11-12 21:08                   ` Felipe Contreras
2020-11-13  8:51                     ` Roman Perepelitsa
2020-11-14  0:52                       ` Felipe Contreras
2020-11-14  5:41                         ` Roman Perepelitsa
2020-11-16 19:41                           ` Felipe Contreras
2020-11-16 20:22                             ` Roman Perepelitsa
2020-11-17 20:28                               ` Felipe Contreras
2020-11-18 22:45                                 ` Daniel Shahaf
2020-11-22  1:20                                   ` Felipe Contreras
2020-11-23  4:00                                     ` Daniel Shahaf
2020-11-23  6:18                                       ` Felipe Contreras
2020-11-19  2:59                                 ` Bart Schaefer
2020-11-22  1:50                                   ` Felipe Contreras
2020-11-17 20:54                             ` Bart Schaefer
2020-11-22  1:49                               ` Felipe Contreras
2020-11-23  6:48                                 ` Bart Schaefer
2020-11-23  7:26                                   ` Felipe Contreras
2020-11-23 20:26                                     ` Bart Schaefer
2020-11-23 23:39                                       ` Felipe Contreras
2020-11-24  0:52                                         ` Bart Schaefer
2020-11-25  8:46                                           ` Felipe Contreras
2020-11-27 15:44                                             ` Daniel Shahaf
2020-11-27 20:49                                               ` Felipe Contreras
2020-11-27 20:59                                                 ` Daniel Shahaf
2020-11-27 21:33                                                   ` Bart Schaefer
2020-11-27 23:37                                                     ` Daniel Shahaf
2020-11-27 23:45                                                       ` Bart Schaefer
2020-11-28  0:24                                                       ` Bart Schaefer
2020-11-28  7:32                                                         ` Bart Schaefer
2020-11-28 12:05                                                         ` Felipe Contreras
2020-11-12 19:26                 ` Bart Schaefer
2020-11-12 21:48                   ` Felipe Contreras [this message]
2020-11-13 22:17                     ` Bart Schaefer
2020-11-14  0:58                       ` Felipe Contreras
2020-11-11 18:36         ` Bart Schaefer
2020-11-11 21:08           ` Felipe Contreras
2020-11-11 17:02     ` Peter Stephenson
2020-11-11 18:05       ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMP44s3hqCW38Axt151JnmJEcymOtWNfaXoqunfPUco3m0A5Jw@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=roman.perepelitsa@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).