From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9361 invoked from network); 4 Aug 2022 17:09:17 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Aug 2022 17:09:17 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1659632958; b=Pg1at/qd0DrN3hyTl+8bmhLalYxosGleFUciwpD1rbgx66uuRMBImyRuSC5V7Qzd7QkGHYyvQK gs00hC0lto5wEImbjBqepBI2nrN9OT4yByJBvwIKhrbFpv00GK4oFZuz1sFy3muTsn4MuFxX1z tKFG4qIGXGgtVXq2mgGMJWxrUB9KakiOwB2fNC2yxLoP2SojrCInl141RNMMmBfz7C9sABDK6u BC6zW8vrr45k7wLbEXxG34AFSdZGvc4BGXIFLPCocEkFfYyYyvCSOOBnA9a5xuMUI9ua0t6Izl IuJ1X2FIHBX+gURLDui7E+bL4Ozyn5k+u2yGInGb9IR5fw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1659632958; bh=LYfN9R6VAspZnRHWhuUP1lwAbhaeeewNishWPZ0bIrM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=VN6lMiQybW+lhY7fh+22e1C6oaW6O2I4n5BmKRRizzcwtC2H/B5ro2ELdlo1B31+xKdtcikrRX 1R945mfKJTm6BwWtrYqCqpJEkv4UkBALaSs/Woeg4a9zdLv8rXbPxZytntjHfF8EaSBrzIlAx5 mpodrpjw5ZpV869D4JTHX/jXbqqT/BjAz3tS176MfZNpxnDWHRDd70p+bLkzU32g22+fvbjXEE BvPKBIrNfc1earbfqNwwFpMaoOwMFz8ujxT5u8OI8dad5KXkTFElCA4aU5nWoRsHqE+9z260K4 4rLkauQZ1ICQ3vXQctvyBXe1MsFq7/1jfpW4NiPZSR6Yag==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=c/fyjiLxPnpLCKYqaETBAT6+ujWqEeoV6P99GdaX0zc=; b=nSQjRm8Op2gy0JYr3+RQMyl7Lm RxaHTj1rnpmEqHxaZeavRD2L/QlZXM2MHfqHlwSxzw4EwcneO77r6wZkMD/LTNELhRc3WEGcVF76N sRfVtVvzOS5PfSzzre9jij6FXde2ooa4sP+C96BdMoVVoeihfYjL1EqFUYkTU8iBzuCbVcoNqEck8 oyWgExuKH7MY4rMEwbJ+V5aSGUcIK2++JiMdPLKU4IUu1/uajbu2yIntlUg4xvUx5f4b57btBmgZX eIMF2JWmDc8+40+261y4eH/LO6DdvS2ZQs+WsogrK6+gGeIukKmdhyJL6lMuybK2VNs2+Y2gJftJ5 Rucx85kA==; Received: from authenticated user by zero.zsh.org with local id 1oJeLU-0000Zf-Ra; Thu, 04 Aug 2022 17:09:16 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f49.google.com) smtp.remote-ip=209.85.218.49; dkim=pass header.d=gmail.com header.s=20210112 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-ej1-f49.google.com ([209.85.218.49]:37873) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oJeGK-00007i-N0; Thu, 04 Aug 2022 17:03:57 +0000 Received: by mail-ej1-f49.google.com with SMTP id kb8so428406ejc.4 for ; Thu, 04 Aug 2022 10:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=c/fyjiLxPnpLCKYqaETBAT6+ujWqEeoV6P99GdaX0zc=; b=Hc9YaRqSVqCFbw6mPoYjJUBDC6vOizBFLRpOndUVyGZz6kQ7jrrmM9c1CJ0wgYE4Ct mOy/Br+I8G27yCC1xtmHj66weU70qe4vm37TFgO/oe/6MiYj3tjcbecUYaWtxgCnwxBQ 9VAsjafIgNHdgG8TergN76JC3hT7j2qdpVeNvkN59zoF69ZX6Wm/X4gf+YtgJjjX6+Ke Xe7fxQtSKuKPb4e3fxbHoqRAndLg2qAW5cySx3Y6UvwyzoXhQdtrboBqc1U2h/VTpKYk 69AWFH9Aw1yY2E/zfAIftvQK/G/7FwKxyqdySaAfsJbiqOPBGzJCrUp5pcIi3CaVVy0x eDbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=c/fyjiLxPnpLCKYqaETBAT6+ujWqEeoV6P99GdaX0zc=; b=fMyl3uEIx24M4+aPuknBE1YUpoO77SliPSqAp8nSVLDJWzqafYgKrQBdMv6kugeu1E z0Kgk88MXsjG2/eImxfN/lxO3RMdeRx6y34kT7f5E+RByEZzZMILV/AnYt37CQvUjVRe 2o2QLawRDU6WL5Q7l53sCJr+0abbdNnaLBZTfnmkJ8o1j/xLlcoDnYpvt4KxD991FCHb kle6Pp+g+gN8rz+dM5MNDeYrwdrG6FIrq1SPDgPTmXxqdWKifTwMgBeOooLus5LD6ySi Jkd5P0quZkZkfcOwv5upXWn7LoI3aRwxOa3W7/Ky14CwtsxOFdAvmtW0Q/V4tjWFDLbx o8Uw== X-Gm-Message-State: ACgBeo2/T8C/spZqwp9JiDMTZGOAFVfLhcYzCFvDyIRQEC6MYw9o4Vct +IW5AaUMJ3sTxbC9d5KPO3hpI2F97m78jejfrsfl8EXJ X-Google-Smtp-Source: AA6agR7N3yscs/cmadgEnqBf7lQYiMV15/2q/RZ/FnDDGhURJb1qVmkg7m+f2dwDPCUC+AACEiPeArmSMTs7dSaAMEQ= X-Received: by 2002:a17:907:28c8:b0:730:9ccc:331f with SMTP id en8-20020a17090728c800b007309ccc331fmr2075487ejc.608.1659632636150; Thu, 04 Aug 2022 10:03:56 -0700 (PDT) MIME-Version: 1.0 References: <20220730010310.3383526-1-felipe.contreras@gmail.com> <1D49B7B5-5B13-4700-93EF-6818676BF846@kba.biglobe.ne.jp> In-Reply-To: <1D49B7B5-5B13-4700-93EF-6818676BF846@kba.biglobe.ne.jp> From: Felipe Contreras Date: Thu, 4 Aug 2022 12:03:45 -0500 Message-ID: Subject: Re: [PATCH 0/3] completion: make: various improvements To: Jun T Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 50446 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Aug 4, 2022 at 4:33 AM Jun T wrote: > > 2022/08/03 23:36, Felipe Contreras wrote: > > > > On Wed, Aug 3, 2022 at 3:54 AM Jun T wrote: > >> > >> If 'call-command' style is set to false, then these targets are not > >> offered (as a possible target). > > > > But if you set it to true they are. > > > > We are talking about the *current code*. The current code already has > > this behavior. > > # I was thinking we were talking about how we can improve the > # current code. Code can be improved in any number of ways. One way is to make small incremental changes that minimize the potential for regressions in logically independent patches. Doing all the improvements you can make in one go doesn't minimize the potential for regressions. > Without your patch, if call-command is on, 'make ' at the top level > of the zsh source tree gives, after a very long wait, huge number of > possible targets (a few hundreds or more?), but most of them are not > valid targets. > > With your patch it immediately gives about 60 candidates. > (Most of them are valid, but they still include configure.ac.) > > So I thought (probably mistakenly) that part of the objectives of > the patch was to offer only valid targets. But anyway, I think it is > better to filter out invalid targets if it is easy to do so. The objective of the patch is to improve the current situation to the point where typing 'make ' is actually usable. Once this has been done in step 1, improving the list of targets can be done in step 2. There's no need to try to do two things at the same time, at least not in the same patch. > The patch below is basically [1/3]+[2/3], with a few additions: > (2) Use make option -q instead of -s (as in your awk-version). For the record, I use -q because that's what bash-completion uses: -npq. I do not mind any of these changes, but I would have done them on top of my changes. I would rebase my changes and include yours, but IIRC you guys squash all the commits anyway. Either way, I think anything is better than the current situation. Cheers. -- Felipe Contreras