zsh-workers
 help / color / mirror / code / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: One possible answer to typeset vs. unset
Date: Fri, 4 Dec 2020 05:04:11 -0600	[thread overview]
Message-ID: <CAMP44s3y2zqbG=8Zxqmn5RcwHC-CF2VaiwADhUbj2AokRKndkA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7a0es6W_Si9YbQzszzYBSuubmocot_8goywaL_Owb=pjw@mail.gmail.com>

On Thu, Dec 3, 2020 at 3:19 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Tue, Dec 1, 2020 at 12:55 AM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > I don't know what would be the proper solution for tied variables, but
> > I used this hack to make the tests pass:
>
> I looked at this for a while yesterday evening.  My conclusion is that
> tied variables are already a bit of a hack.

Indeed. It might not be worthwhile to look at them at this point.

> Consequently I don't know if your patch would cause a different test
> for unset-ness (that hasn't been written yet) to fail, but something
> like that patch may be unavoidable.

I can't parse that. What would such unset-ness test do?

Anyway. I don't see the two approaches particularly different. If
nobody can argue that "typeset var" and "typeset -i var" should behave
differently (one with no value and the other with value), then some
kind of flag like PM_DECLARED would be needed. I'll add that to my
approach.

Next, I think all the instances in which PM_UNSET is checked should be
verified, to see if PM_DECLAREDNULL makes sense in those. I'll do
that.

Next, we need a way to make sure $empty[(i|I)] returns something
sensible (that would be for both approaches).

And I think that's it. All that's left is deciding what flag would
turn this mode on.

Lastly, I don't know if there is any low-hanging fruit, for example;
doing the same as bash 5.0 with localvar_inherit and localvar_unset.
In my opinion localvar_inherit should also be the default (and
presumably that's what POSIX will eventually decide). I don't quite
get localvar_unset, but seems to also be a sensible default. Or maybe
that's an entirely new topic.

Cheers.

-- 
Felipe Contreras


  reply	other threads:[~2020-12-04 11:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-28 19:49 Bart Schaefer
2020-11-28 20:00 ` Bart Schaefer
2020-11-28 20:21 ` Bart Schaefer
2020-12-01  8:54 ` Felipe Contreras
2020-12-03 21:19   ` Bart Schaefer
2020-12-04 11:04     ` Felipe Contreras [this message]
2020-12-04 15:49       ` Bart Schaefer
2020-12-04 19:47         ` Bart Schaefer
2020-12-05  0:22           ` Bart Schaefer
2020-12-05  0:28         ` Bart Schaefer
2020-12-05  0:51       ` Bart Schaefer
2020-12-05 22:17         ` Bart Schaefer
2020-12-23 23:00         ` Felipe Contreras
2020-12-02 17:18 ` Vincent Lefevre
2020-12-02 18:03   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMP44s3y2zqbG=8Zxqmn5RcwHC-CF2VaiwADhUbj2AokRKndkA@mail.gmail.com' \
    --to=felipe.contreras@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).