zsh-workers
 help / color / mirror / code / Atom feed
From: Yichao Yu <yyc1992@gmail.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: zsh-workers@zsh.org
Subject: Re: zsh bug: isearch doesn't support unicode properly
Date: Mon, 28 Oct 2013 13:53:41 -0400	[thread overview]
Message-ID: <CAMvDr+R_3cRSv7kD6m85fzqQdCGmf1nLb8frGy5oLaaQZsJorw@mail.gmail.com> (raw)
In-Reply-To: <20131028173134.5a62ee5f@pwslap01u.europe.root.pri>

>> I'm not yet sure what's wrong with these characters but at least the
>> meta character processing looks suspicious.
>
> Yes --- how about this?
>
> diff --git a/Src/Zle/zle_utils.c b/Src/Zle/zle_utils.c
> index d0e7b55..b84d253 100644
> --- a/Src/Zle/zle_utils.c
> +++ b/Src/Zle/zle_utils.c
> @@ -145,6 +145,7 @@ zlecharasstring(ZLE_CHAR_T inchar, char *buf)
>                 ptr2--;
>             }
>             *ptr = Meta;
> +           ptr[1] ^= 32;
>             ret++;
>         }

Yep, patched it on the 5.0.2 release, tested with a few inputs that
used to have problems and it seems to fix the problem.

Thanks for the fast patch.

BTW, will this be included in the next release (5.0.3?). (Just want to
know if I still need to compile zsh myself on the next ArchLinux
update)

>
> pws


  reply	other threads:[~2013-10-28 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-28 15:42 Yichao Yu
2013-10-28 17:31 ` Peter Stephenson
2013-10-28 17:53   ` Yichao Yu [this message]
2013-10-28 17:58     ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMvDr+R_3cRSv7kD6m85fzqQdCGmf1nLb8frGy5oLaaQZsJorw@mail.gmail.com \
    --to=yyc1992@gmail.com \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).