zsh-workers
 help / color / mirror / code / Atom feed
From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Possible bug: HASH_CMDS has no observable effect
Date: Sun, 13 Sep 2020 11:31:38 +0200	[thread overview]
Message-ID: <CAN=4vMp4nkPQ9GrHNyDC4_qijrdfiuSmm-aE-AC_vOi1LjkvBA@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7aBwDz_Uo4r2ohv9wLBpeHna2C9g0QGN5FsXmqs8Hh2CA@mail.gmail.com>

On Sat, Sep 12, 2020 at 10:41 PM Bart Schaefer
<schaefer@brasslantern.com> wrote:
>
> That's exactly how it works.  The search in execute() is only done if
> an absolute file location for the command isn't provided by the
> parent, which only occurs if HASH_CMDS is not set.

This is what I expected to happen but that's not what actually
happens. Sometimes, when HASH_CMDS is set, a successfully invoked
command does not get hashed.

Here's a new test case that doesn't use docker.

  % zsh -f
  % mkdir /tmp/foo
  % path+=(/tmp/foo)
  % print $+commands[bar]
  0
  % print 'echo hello' >/tmp/foo/bar
  % chmod +x /tmp/foo/bar
  % bar
  hello
  % print $+commands[bar]
  0

The output of the last command should be "1", right? Everything else
looks as expected.

Roman.


  parent reply	other threads:[~2020-09-13  9:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  8:21 Roman Perepelitsa
2020-09-11 14:48 ` Phil Pennock
2020-09-11 15:01   ` Roman Perepelitsa
2020-09-11 16:10     ` Phil Pennock
2020-09-11 16:33       ` Roman Perepelitsa
2020-09-11 21:10         ` Bart Schaefer
2020-09-12  7:02           ` Roman Perepelitsa
2020-09-12  8:35             ` Bart Schaefer
2020-09-12  8:49               ` Roman Perepelitsa
2020-09-12 20:41                 ` Bart Schaefer
2020-09-12 20:43                   ` Bart Schaefer
2020-09-13  9:31                   ` Roman Perepelitsa [this message]
2020-09-13 22:24                     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN=4vMp4nkPQ9GrHNyDC4_qijrdfiuSmm-aE-AC_vOi1LjkvBA@mail.gmail.com' \
    --to=roman.perepelitsa@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).