From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: draw prompt on the correct line after window change
Date: Mon, 6 Jan 2020 19:46:47 +0100 [thread overview]
Message-ID: <CAN=4vMpw1EEQHyhx2dAVN8cZ78SMy6-xmWFM1tRX8TDtsTN-fw@mail.gmail.com> (raw)
In-Reply-To: <CAKc7PVCBoLWhNMVdQGmmgFB_zaObo2Ga=YU21yWJC-6KZ+EsHQ@mail.gmail.com>
On Mon, Jan 6, 2020 at 7:31 PM Sebastian Gniazdowski
<sgniazdowski@gmail.com> wrote:
>
> On Mon, 6 Jan 2020 at 19:07, Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> > I should clarify that the ball is totally on my side. The patch
> > received cool feedback but wasn't rejected outright. I estimated that
> > effort required to turn the tide is likely higher than I can muster
> > and chose to withdraw.
>
> From what I've read:
> 1. Bart said that using the terminals feature to save cursor position
> might collide with application's use of the the feature
Yes, I saw that. I believe this patch doesn't break any existing
useful code. If anyone can point me to a piece of code that could be
broken by my patch, I'll test it.
> So, I think that there's not much to do on your side.
I gave up because because no one has expressed enthusiasm and two
members in good standing expressed skepticism that I was unable to
address. No one is obligated to accept my patches unless I put in the
work to convince the community that the patch does something useful
and doesn't break things. It didn't seem like I was making progress on
either of these fronts, so I gave up.
Roman.
next prev parent reply other threads:[~2020-01-06 18:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 17:20 Roman Perepelitsa
2019-07-15 19:14 ` Mikael Magnusson
2019-07-15 19:32 ` Roman Perepelitsa
2019-07-15 19:41 ` Roman Perepelitsa
2019-07-15 21:24 ` Bart Schaefer
2019-07-15 22:09 ` Roman Perepelitsa
2019-07-15 22:11 ` Roman Perepelitsa
2019-07-15 23:28 ` Bart Schaefer
2019-07-16 8:16 ` Roman Perepelitsa
2019-07-16 0:01 ` Bart Schaefer
2020-01-06 17:50 ` Sebastian Gniazdowski
2020-01-06 18:07 ` Roman Perepelitsa
2020-01-06 18:31 ` Sebastian Gniazdowski
2020-01-06 18:46 ` Roman Perepelitsa [this message]
2020-01-06 19:02 ` Sebastian Gniazdowski
2020-01-06 19:28 ` Bart Schaefer
2020-01-06 19:38 ` Roman Perepelitsa
2020-02-01 17:22 ` Roman Perepelitsa
2020-01-06 19:40 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN=4vMpw1EEQHyhx2dAVN8cZ78SMy6-xmWFM1tRX8TDtsTN-fw@mail.gmail.com' \
--to=roman.perepelitsa@gmail.com \
--cc=sgniazdowski@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).