zsh-workers
 help / color / mirror / code / Atom feed
From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Thu, 17 Nov 2022 14:28:29 +0100	[thread overview]
Message-ID: <CAN=4vMq1kXr1OsjXB9QQSEC=M9gXwuzyPWUOBY3L9LH-s-R1zQ@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDuo112DieG6ur_M0giV4UXVTjKRLuzrpUchcoj6V_LEtA@mail.gmail.com>

On Thu, Nov 17, 2022 at 2:06 PM Marlon Richert <marlon.richert@gmail.com> wrote:
>
> It's not the "inverted meaning" here that is the bug. `zle -F` (with
> or without -w) just shouldn't ever change $LASTWIDGET in the first
> place. It breaks a lot of existing widget functions and there is no
> possible workaround.

Relevant: https://www.zsh.org/mla/workers/2019/msg00204.html

Especially this part:

> The same branch also adds -W option to zle widget command. This
> option instructs zle to keep LASTWIDGET unchanged.

This part of the patch wasn't applied and the code is long gone (I
didn't attach it to the email) but it's fairly straightforward to
implement.

Roman.


  reply	other threads:[~2022-11-17 13:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 15:06 Marlon Richert
2022-11-16 18:24 ` Bart Schaefer
2022-11-17 13:04   ` Marlon Richert
2022-11-17 13:28     ` Roman Perepelitsa [this message]
2022-11-17 16:18     ` Bart Schaefer
2023-01-11  7:45       ` Marlon Richert
2023-01-17  0:01 ` [PATCH] " Bart Schaefer
2023-01-17  9:22   ` Peter Stephenson
2023-01-17 18:00     ` Bart Schaefer
2023-07-16 10:28       ` dana
2023-07-17  8:42         ` Peter Stephenson
2023-07-17 15:17         ` Bart Schaefer
2023-07-17 15:52           ` dana
2023-07-17 15:57             ` Bart Schaefer
2023-07-17 16:57               ` Bart Schaefer
2023-07-20  4:01                 ` dana
2023-07-20  4:25                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN=4vMq1kXr1OsjXB9QQSEC=M9gXwuzyPWUOBY3L9LH-s-R1zQ@mail.gmail.com' \
    --to=roman.perepelitsa@gmail.com \
    --cc=marlon.richert@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).