From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,HTML_MESSAGE,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 86909196 for ; Thu, 23 May 2019 05:49:39 +0000 (UTC) Received: (qmail 9721 invoked by alias); 23 May 2019 05:49:20 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44354 Received: (qmail 3322 invoked by uid 1010); 23 May 2019 05:49:20 -0000 X-Qmail-Scanner-Diagnostics: from mail-io1-f42.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25454. spamassassin: 3.4.2. Clear:RC:0(209.85.166.42):SA:0(-2.0/5.0):. Processed in 2.624544 secs); 23 May 2019 05:49:20 -0000 X-Envelope-From: roman.perepelitsa@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.42 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=Q7WF/SZ7e9eS317U2ezSCxlV8qezwZ3GwW34w8Tor2s=; b=NWbx3avMTm3xb2EbJ60pRBvXRjQ/DjYwE3+wpaR4TljWjXy5LBRFby3p2zJyYlPn9x 8gwGl7IGL3oVdlcMj34DrVL3dX/Ce29yGXINxW04hfg4kZwzfnAO6Zs9kxtWjowILjSs 5IL7LunuwTIycCLSo+5h82ZBYi7qbsu4K5BmrDqCzIBlVxc7y8yJqLOpoeHz2iheCv8l dwkfsr4komL330ORdqn0IXYWw87GJJRZGCEP2FpRznksh9HcUFwb1aBh4d8QBuKkj5lO A3TseMVCKoIkliEhdjLgUieCjkXhNRJ61VWozmBgg4JGu4keRftFnmkp42ngsuusBZnQ esSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=Q7WF/SZ7e9eS317U2ezSCxlV8qezwZ3GwW34w8Tor2s=; b=NuwBlweq0vxl0W6gxNZFlyxJaRs8NXmQD/BL9+S0m8PORnYv3aK7d3wohZNAmakXqi i6g5PXstgOkCSFKABSWF9i2wIysGfE3ZKsyOPckF24NZKFIzkLMb23lNqj0f7dQNPEyQ XS9pn1MxAnZ30IERjKDY/D1idmID+eodWZYkQCtw3WIAxR3J4ISgWFEsSL+wr6gy9hXZ ZOb99VwusXi9IBUEr/9XnmMwSfuP7qlwqR0nTk/IsAtjNrydhXhl3163D46UMH/WZC+8 42TWy5Q11FOxxvRQ97NjsbU5J2YZO+c0JYbeekXLW8u6A1Eq4ZeNB/l+A6t918ssZ6he gtTA== X-Gm-Message-State: APjAAAUzjOZR8+8EbpRfI5PGaH7rlPFMN29tcRGuv13/UCUi/vPxi4O1 o1VOUjZZpwXqUhHtFeDWN/1B6fVs3WiAg4Jb3p3gocRE X-Google-Smtp-Source: APXvYqzWPqagtfNFXR/IVK7tmMlqFfRl392Gpwzbm0k2i1UPFtAcqfeoAVQQtMkwis8ADPYcFI8ouiyk/I7Wh15w+BM= X-Received: by 2002:a6b:b7ce:: with SMTP id h197mr29116729iof.169.1558590524432; Wed, 22 May 2019 22:48:44 -0700 (PDT) MIME-Version: 1.0 References: <68081d8c-1aa6-203b-eb6c-e2d048de1340@ibr.cs.tu-bs.de> In-Reply-To: From: Roman Perepelitsa Date: Thu, 23 May 2019 07:48:33 +0200 Message-ID: Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix) To: zsh-workers@zsh.org Content-Type: multipart/mixed; boundary="0000000000008f4c28058987a277" --0000000000008f4c28058987a277 Content-Type: multipart/alternative; boundary="0000000000008f4c24058987a275" --0000000000008f4c24058987a275 Content-Type: text/plain; charset="UTF-8" Is there anything else I need to do to move this forward? The patch works on all terminals I and others have tried (11 in total; some with multiple versions and/or configurations). The code no longer special-cases ZLE_RPROMPT_INDENT=0, which is nice. There is branch for ZLE_RPROMPT_INDENT=0 but it's just an optimization to avoid an unnecessary zputc(&zr_cr) call when it's known to have no effect. So I think the logic is simpler now. I've attached the patch to the email. You can also find it at https://github.com/zsh-users/zsh/compare/master...romkatv:rprompt-indent. Roman. > --0000000000008f4c24058987a275 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Is there anything else I need to do to move this forw= ard? The patch works on all terminals I and others have tried (11 in total;= some with multiple versions and/or configurations). The code no longer spe= cial-cases=C2=A0ZLE_RPROMPT_INDENT=3D0, which is nice. There is branch for= =C2=A0ZLE_RPROMPT_INDENT=3D0 but it's just an optimization to avoid an = unnecessary=C2=A0zputc(&zr_cr) call when it's known to have no effe= ct. So I think the logic is simpler now.

I've = attached the patch to the email. You can also find it at=C2=A0htt= ps://github.com/zsh-users/zsh/compare/master...romkatv:rprompt-indent.<= br>

Roman.
--0000000000008f4c24058987a275-- --0000000000008f4c28058987a277 Content-Type: text/x-patch; charset="US-ASCII"; name="rprompt-indent.patch" Content-Disposition: attachment; filename="rprompt-indent.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jw08iwtt0 ZGlmZiAtLWdpdCBhL1NyYy9abGUvemxlX3JlZnJlc2guYyBiL1NyYy9abGUvemxlX3JlZnJlc2gu YwppbmRleCAxZjI5Mzg0NWYuLjg1ZTU1ZTBkNCAxMDA2NDQKLS0tIGEvU3JjL1psZS96bGVfcmVm cmVzaC5jCisrKyBiL1NyYy9abGUvemxlX3JlZnJlc2guYwpAQCAtMTY3OCw3ICsxNjc4LDEyIEBA IHpyZWZyZXNoKHZvaWQpCiAKIAkgICAgbW92ZXRvKDAsIHdpbncgLSBycHJvbXB0X29mZiAtIHJw cm9tcHR3KTsKIAkgICAgenB1dHMocnByb21wdGJ1Ziwgc2hvdXQpOwotCSAgICB2Y3MgPSB3aW53 IC0gcnByb21wdF9vZmY7CisJICAgIGlmIChycHJvbXB0X29mZikgeworCQl2Y3MgPSB3aW53IC0g cnByb21wdF9vZmY7CisJICAgIH0gZWxzZSB7CisJCXpwdXRjKCZ6cl9jcik7CisJCXZjcyA9IDA7 CisJICAgIH0KIAkvKiByZXNldCBjaGFyYWN0ZXIgYXR0cmlidXRlcyB0byB0aGF0IHNldCBieSB0 aGUgbWFpbiBwcm9tcHQgKi8KIAkgICAgdHh0Y2hhbmdlID0gcG1wdF9hdHRyOwogCSAgICAvKgpA QCAtMjE1OSwyNSArMjE2NCwyMCBAQCBtb3ZldG8oaW50IGxuLCBpbnQgY2wpCiAgICAgY29uc3Qg UkVGUkVTSF9FTEVNRU5UICpyZXA7CiAKICAgICBpZiAodmNzID09IHdpbncpIHsKLQlpZiAocnBy b21wdF9pbmRlbnQgPT0gMCAmJiB0Y2NhbihUQ0xFRlQpKSB7Ci0JICB0Y19sZWZ0Y3VycygxKTsK LQkgIHZjcy0tOwotCX0gZWxzZSB7Ci0JICAgIHZsbisrLCB2Y3MgPSAwOwotCSAgICBpZiAoIWhh c2FtKSB7Ci0JCXpwdXRjKCZ6cl9jcik7Ci0JCXpwdXRjKCZ6cl9ubCk7Ci0JICAgIH0gZWxzZSB7 Ci0JCWlmICgodmxuIDwgbmxuY3QpICYmIG5idWZbdmxuXSAmJiBuYnVmW3Zsbl0tPmNocikKLQkJ ICAgIHJlcCA9IG5idWZbdmxuXTsKLQkJZWxzZQotCQkgICAgcmVwID0gJnpyX3NwOwotCQl6cHV0 YyhyZXApOwotCQl6cHV0YygmenJfY3IpOwotCQlpZiAoKHZsbiA8IG9sbmN0KSAmJiBvYnVmW3Zs bl0gJiYgb2J1Zlt2bG5dLT5jaHIpCi0JCSAgICAqb2J1Zlt2bG5dID0gKnJlcDsKLQkgICAgfQot CX0KKyAgICB2bG4rKywgdmNzID0gMDsKKyAgICBpZiAoIWhhc2FtKSB7CisJenB1dGMoJnpyX2Ny KTsKKwl6cHV0YygmenJfbmwpOworICAgIH0gZWxzZSB7CisJaWYgKCh2bG4gPCBubG5jdCkgJiYg bmJ1Zlt2bG5dICYmIG5idWZbdmxuXS0+Y2hyKQorCSAgICByZXAgPSBuYnVmW3Zsbl07CisJZWxz ZQorCSAgICByZXAgPSAmenJfc3A7CisJenB1dGMocmVwKTsKKwl6cHV0YygmenJfY3IpOworCWlm ICgodmxuIDwgb2xuY3QpICYmIG9idWZbdmxuXSAmJiBvYnVmW3Zsbl0tPmNocikKKwkgICAgKm9i dWZbdmxuXSA9ICpyZXA7CisgICAgfQogICAgIH0KIAogICAgIGlmIChsbiA9PSB2bG4gJiYgY2wg PT0gdmNzKQo= --0000000000008f4c28058987a277--