From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 27351 invoked from network); 16 Dec 2020 08:34:12 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 Dec 2020 08:34:12 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1608107652; b=lMQ6KvI5EJJJKo5L9hAKSeNpG6M88g38oPItPcwDC9JISIRSZTq+1BzHkO6hMTB3NSscx1BHYY aMu4iXCZlGuxkTykNMUF/pUWFuhNXXgmDP802rwtHrix2xkAa6st7Z/Go4EySBL8uB83B2E5zA v07NgCxuzvb/EzopYJQK8IPkcFwhpgf0K4k4+GD+FIiPPczoJOmui6J0S6deoAYKntL51xyYKX 8NSOKOW0LNfaDDkMNrWp+i8mxdUQvy9H0PCdXwglIUcIwXSwkwRIdHAMEhd70MQ1onB9LcEjPy yfU6MY2jsXLK43jUTFml/dvUqYVg+0cSaXojKTmUD5gaSw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-il1-f177.google.com) smtp.remote-ip=209.85.166.177; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1608107652; bh=2HsOt2vNPIrjMsVAojQLxn0NSXhkzkyIO9MjwVm8S6o=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=qT3MysRu7CPw16H7zIMYYObi3jgax8A+DRT7zsF7AIIfwvrWE4sLEm93FT0mTJd5LmtFnDWF/x lcWic6Z71CmHSOhUmyk8CeVTnZ3xuNjgloysi6KtF52pRrZYvX/MhKjqa06VSEdYXnX31ZuF2W wTVpjBAfeVeR2HB+0fNN8cx7mdOoWPvKjTeRgz4UkUU7O65s/LKMqGTHZxkXcqygRC2ZGuGecC 51VcAMwirGJdTmFIHc+gRqcHO3SrbYc6uPQf/ndqWyyCqri1K7kfmv7HLqrCcwtPeHr3QpMIAA xB1WHWwO/faUDoxcNntO3libwFMbVyujvY42hT3G8fv3nA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=qkNL/2beru7nvbmU+ngh94wTf1LE01cyMVy9Uwl0l+I=; b=iQgwfaJwjC4Oyc6zKpfF4In4na K+zuOV8B1Y9FKuZepgeIc6xy3FXkvhNjb2S3oj6MSzTutiswEc9pSbRea/ZJ+H1i5uEPHRTxRRV50 D8M4iP6Jf7Sc1HmGYiMqr5G07NQvlzG8Qt/kkgC4kpU8BXKDoB+lmAOZTU/4DutpXC9s7LqU780S5 H02EK7q+/UtkfI+fdCpv0TcteQ0piLJflfLbtZEB9viU7ekhdPj6pTq7VulcZlT0gF/9lkLKViV5W XOPClrXerAEsx0V3OCqfqt+vSrxUI11nt0zk31mr/g5+AHsxLIBjMO5lVoiQpxwGQf485ooAPiMfi VugCZqyg==; Received: from authenticated user by zero.zsh.org with local id 1kpSG9-00057C-Ip; Wed, 16 Dec 2020 08:34:09 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-f177.google.com) smtp.remote-ip=209.85.166.177; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-il1-f177.google.com ([209.85.166.177]:41593) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kpSFk-0004yO-98; Wed, 16 Dec 2020 08:33:45 +0000 Received: by mail-il1-f177.google.com with SMTP id p5so21808181iln.8 for ; Wed, 16 Dec 2020 00:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qkNL/2beru7nvbmU+ngh94wTf1LE01cyMVy9Uwl0l+I=; b=vTm6/BHyyif839mWaeuY/HJlDz69sPASlLLPoOE/5R+cZBSgcy5D8FE/16nzi2llXb jPp4Uu74nz7SlqdTc2ZKb3DNy2inN1LwQWhYs5upHOt69fxNUJ9aVIe6UkycCXRvn2QE 3cukaquce+lYdiOtu1RC5PiFjhSfR6hY72bIQFWc7jJQwMdL9MBnAchFXr588QXovouW BIsQcO0fBaUYJnY3R1AZhy6bs6xAounUjsiVMIqWiEUpwZTs2baNW+yc24x035FCg1wD FxqKLeItw4wA0FUB0g5St0gsgp5BaXJLzlYgbUzlOEZWEGAoprUia7jkMAY1P8XhsahE cSmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qkNL/2beru7nvbmU+ngh94wTf1LE01cyMVy9Uwl0l+I=; b=bkd7RZunGdx9DLdMPmtX/sZQ3ayamMz+Vild5GQ4e0TUE6Xh7Vkpknu3yIDvIhYmzH bpcARnPUqrK5xinA8e0SR2zEi+cf6tSUBiWRQs5tYLsrbiD2u7ZTcGwqelJrNRYDLTiI b+WQmoas9ow8shLragpncBM91om48hHH52Ym1trK94bdpjeSq6VNO/WYIFqV2txZw2h/ w2GNNU7pg5Oej4LKnGo8WavyBeoNsD7cHpFHonmNpS87W1MgVV5t+bpIUgGE+yzsO133 DHsbgiAtP9Bwo+jci4S5YVlyMx1BGsK83qKxr4QnSjNTf66i0KufHouEJ3HuwbRFZ5Y2 OM0Q== X-Gm-Message-State: AOAM530aymFUiX4Ddp6XDdz5ZeoFLXSwmlzYils3NKhSo9I7uzxxcrOI myf5mL+x/tE8iReLh+r16Op07y1MggY8Nx4HWBhiJWadFPD7cb5Y X-Google-Smtp-Source: ABdhPJw3POlK8pg6ExqIbC2GbeUHmKyFz1DO3tWNApFUNGjsHJFuez7D+fEonUWP0Bu8iJV9vJ6I9zQzZOsallwagIQ= X-Received: by 2002:a92:9806:: with SMTP id l6mr47999550ili.304.1608107622698; Wed, 16 Dec 2020 00:33:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Roman Perepelitsa Date: Wed, 16 Dec 2020 09:33:31 +0100 Message-ID: Subject: Re: [BUG]: zle-line-pre-redraw breaks vi-repeat-change To: Zsh hackers list Cc: GammaFunction@vivaldi.net Content-Type: multipart/mixed; boundary="0000000000009cdc4d05b690bbe1" X-Seq: 47744 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --0000000000009cdc4d05b690bbe1 Content-Type: text/plain; charset="UTF-8" On Wed, Oct 7, 2020 at 2:49 PM Roman Perepelitsa wrote: > > If zle-line-pre-redraw is defined, vi-repeat-change behaves as if the > numeric argument was always 1. > > To reproduce from `zsh -f`: > > % function zle-line-pre-redraw() {} > % zle -N zle-line-pre-redraw > % bindkey -v > % 123456<2X><.> > > The last line in more detail: > > - "123456" is self-insert > - ESC is vi-cmd-mode > - "2X" is vi-backward-delete-char with NUMERIC = 2 > - "." is vi-repeat-change > > Expected: BUFFER contains "16". > > Actual: BUFFER contains "126". > > The actual behavior is unchanged if <.> is replaced with <3.>. The > expected BUFFER in this case is "6". GammaFunction@vivaldi.net (CC-ed) has sent https://github.com/zsh-users/zsh/pull/69 that fixes the two tests I've described above. Here's the patch from the PR. Roman. --0000000000009cdc4d05b690bbe1 Content-Type: text/plain; charset="US-ASCII"; name="restore-vi-repeat.patch.txt" Content-Disposition: attachment; filename="restore-vi-repeat.patch.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kir5pdrv0 ZGlmZiAtLWdpdCBhL1NyYy9abGUvemxlX21haW4uYyBiL1NyYy9abGUvemxlX21haW4uYwppbmRl eCA4YzA1MzQ3MDguLjA1NjFjM2IzYiAxMDA2NDQKLS0tIGEvU3JjL1psZS96bGVfbWFpbi5jCisr KyBiL1NyYy9abGUvemxlX21haW4uYwpAQCAtMTA2NSw2ICsxMDY1LDcgQEAgcmVkcmF3aG9vayh2 b2lkKQogCWludCBzYXZlcnJmbGFnID0gZXJyZmxhZywgc2F2cmV0ZmxhZyA9IHJldGZsYWc7CiAJ aW50IGxhc3RjbWRfcHJldiA9IGxhc3RjbWQ7CiAJaW50IG9sZF9pbmNvbXBmdW5jID0gaW5jb21w ZnVuYzsKKwlpbnQgb2xkX3ZpaW5yZXBlYXQgPSB2aWlucmVwZWF0OwogCWNoYXIgKmFyZ3NbMl07 CiAJVGhpbmd5IGxiaW5ka19zYXZlID0gbGJpbmRrLCBiaW5ka19zYXZlID0gYmluZGs7CiAKQEAg LTEwNzksNiArMTA4MCw3IEBAIHJlZHJhd2hvb2sodm9pZCkKIAlpbmNvbXBmdW5jID0gMDsKIAll eGVjemxlZnVuYyhpbml0dGhpbmd5LCBhcmdzLCAxLCAwKTsKIAlpbmNvbXBmdW5jID0gb2xkX2lu Y29tcGZ1bmM7CisJdmlpbnJlcGVhdCA9IG9sZF92aWlucmVwZWF0OwogCiAJLyogUmVzdG9yZSBl cnJmbGFnIGFuZCByZXRmbGFnIGFzIHpsZWNhbGxob29rKCkgZG9lcyAqLwogCWVycmZsYWcgPSBz YXZlcnJmbGFnIHwgKGVycmZsYWcgJiBFUlJGTEFHX0lOVCk7Cg== --0000000000009cdc4d05b690bbe1--