From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2f86eba0 for ; Mon, 6 Jan 2020 19:39:24 +0000 (UTC) Received: (qmail 13561 invoked by alias); 6 Jan 2020 19:39:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45258 Received: (qmail 295 invoked by uid 1010); 6 Jan 2020 19:39:16 -0000 X-Qmail-Scanner-Diagnostics: from mail-il1-f176.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25684. spamassassin: 3.4.2. Clear:RC:0(209.85.166.176):SA:0(-2.0/5.0):. Processed in 1.864067 secs); 06 Jan 2020 19:39:16 -0000 X-Envelope-From: roman.perepelitsa@gmail.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.166.176 as permitted sender) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kKv0rHSG6un58L4CduRWWh//AWOHPWwAF4EC18KoymY=; b=YaVewXJlPz/edHMb/85tV2r5DPXzJUqDBgIydpXttBnhGnly3o4Dgswc6+S6wOquxU 2iJPFbU3FdouEM0Zb6KxAMu1nZ+ofjcHD1cBgraxtdmkLuxIAwGlQG2BtPY1UVn7sx5z k43MdKL9hG4mFkyaoSX7eYoE2z2dYbDtGeQ2yJ0AXiI3LzHiib6b38qaOHxinXVIDQ7u bupBCr+EGmDspiTkUMU4UoHc4hXFn8X3iBR7PDkjqNutF3rDQnHZ6BY0zc2BU0r0xVzL Vb0dlw6VilO+rYczM2ZyhBgspOwuPjbqPLYfRmRqgXFh+Ya2ReX2jagrgh4Zn5wkqjNg UGLw== X-Gm-Message-State: APjAAAXz+w84BqMYaEBkJuiN0wzii6VCaBtj3XdqR/oejuY8syE4He6M T3UNkeq7cdDQH0f9FuUpBfG4kU7ecWr2iIsK9Aw= X-Google-Smtp-Source: APXvYqx+IcFm4v+e+aX3D5lvUlN6G97Vy69C97dQERgw4X0tFVviXnZuttz3Tbh5GFcOlrD962dvJaEWdTyoPlTXtwo= X-Received: by 2002:a92:da44:: with SMTP id p4mr92519702ilq.168.1578339521905; Mon, 06 Jan 2020 11:38:41 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Roman Perepelitsa Date: Mon, 6 Jan 2020 20:38:31 +0100 Message-ID: Subject: Re: PATCH: draw prompt on the correct line after window change To: Bart Schaefer Cc: Sebastian Gniazdowski , Zsh hackers list Content-Type: text/plain; charset="UTF-8" On Mon, Jan 6, 2020 at 8:28 PM Bart Schaefer wrote: > IIR the problem correctly, a possible approach to resolve my concern would be to have the terminal report the cursor position for the shell to read+save it, rather than rely on the terminal save/restore action. I implemented this prior to the patch I sent. Unfortunately, this added enough prompt latency to make it noticeable. I suppose some users might value correct WINCH behavior above fast prompt but I'm not one of them. When I switched to save/restore cursor, I haven't looked back. It looks to me like a strict improvement over the current state. I think it doesn't break or slow anything down, while at the same time it fixes WINCH handling in most cases (not in all cases though, see my original email). I might be wrong, and there might be code that gets broken. If you know any code that might be broken by my patch due to its use of save/restore cursor, please point me to it and I'll test my patch against it. Roman.