zsh-workers
 help / color / mirror / code / Atom feed
From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug report: `setopt noaliases` not respected in `local` statement without assignment.
Date: Thu, 26 Mar 2020 11:38:34 +0100	[thread overview]
Message-ID: <CAN=4vMqxxC62wQD0eKCqd8kmOq09RxSAf0t+E7eThku9ngFO1A@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDurch52306wHG4q6QWt-VXxMmtJSWhBE0s-JU=wTf-VdA@mail.gmail.com>

On Thu, Mar 26, 2020 at 11:27 AM Marlon Richert
<marlon.richert@gmail.com> wrote:
>
> Aha. So, if I want that aliases don't get expanded in the functions in https://github.com/junegunn/fzf/blob/master/shell/completion.zsh, then where should I put the `setopt noaliases` statement? Does it suffice to just put `emulate -L zsh; setopt localoptions noaliases;` at the top of the file? I don't want the noaliases option to leak into my own shell environment.
>
> Or is there a better solution possible here than using noaliases?

The official solution to this problem is to use autoloadable functions
instead of sourcing zsh scripts with function definitions.

One practical alternative is to add a bit of code at the top and at
the bottom of completion.zsh. Like this:

    'builtin' 'local' '-a' '_fzf_completion_opts'
    [[ ! -o 'aliases'         ]] || _fzf_completion_opts+=('aliases')
    [[ ! -o 'sh_glob'         ]] || _fzf_completion_opts+=('sh_glob')
    [[ ! -o 'no_brace_expand' ]] || _fzf_completion_opts+=('no_brace_expand')
    'builtin' 'setopt' 'no_aliases' 'no_sh_glob' 'brace_expand'

    # the meat of completion.zsh goes here

    (( ${#_fzf_completion_opts} )) && setopt ${_fzf_completion_opts[@]}
    'builtin' 'unset' '_fzf_completion_opts'

Note that this doesn't just disable aliases but also changes a couple
other options that similarly affect parsing of functions. (You could
also wrap the whole script in try-always to make sure options are
restored even if evaluation of the script stops prematurely.)

Another alternative is to rename completion.zsh to
internal-completion.zsh and place this shim in place of the original
completion.zsh:

    'builtin' 'emulate' 'zsh' '-o' 'no_aliases' '-c' 'builtin source
${${(%):-%x}:h}/internal-completion.zsh'

Roman.




> On Thu, 26 Mar 2020 at 11:59, Roman Perepelitsa <roman.perepelitsa@gmail.com> wrote:
>>
>> On Thu, Mar 26, 2020 at 10:55 AM Marlon Richert
>> <marlon.richert@gmail.com> wrote:
>> >
>> > Test case:
>> >
>> > alias -g tail="multitail -Cs --follow-all"
>> > f() {
>> >   setopt localoptions no_aliases
>> >   local tail
>> >   tail=1
>> >   echo $tail
>> > }
>>
>> Alias expansion happens when functions get parsed. If you don't want
>> `tail` to be alias-expanded within function `f`, you need to add
>> `setopt no_aliases` before the function of `f`.
>>
>> > g() {
>> >   setopt localoptions no_aliases
>> >   local tail=1
>> >   echo $tail
>> > }
>>
>> `tail` within `local tail=1` is not subject to global alias expansion.
>>
>> Roman.

  reply	other threads:[~2020-03-26 10:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-26  9:54 Marlon Richert
2020-03-26  9:59 ` Roman Perepelitsa
2020-03-26 10:27   ` Marlon Richert
2020-03-26 10:38     ` Roman Perepelitsa [this message]
2020-03-26 22:34       ` Daniel Shahaf
2020-03-29 10:24         ` Roman Perepelitsa
2020-03-29 20:47           ` Daniel Shahaf
2020-03-29 21:03             ` Roman Perepelitsa
2020-03-29 21:12               ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN=4vMqxxC62wQD0eKCqd8kmOq09RxSAf0t+E7eThku9ngFO1A@mail.gmail.com' \
    --to=roman.perepelitsa@gmail.com \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).