From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22359 invoked from network); 22 Oct 2020 13:31:33 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 22 Oct 2020 13:31:33 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1603373493; b=hVkT7R1NOxN1FfmpIi2kT/2H0jhaBqxSGbLLvSl3tsRsLOaS2cELCSBxM+XTc5yLR0PisaQ7B+ RgjmjHa20sA1mHJv5sF52YapLXolJNzYlCyyJ4AtJC7Dtf1phY+A2TpQkSZAXM0P3k/14quGJm ccbN38I2FZzw3oZWdWX1xL2LpNr0gFvFh4MWSnfKLSWBXHiVKktqeCKykSLVh7uiRQEK1h0xqS 7Pzl4RsZRAVbcfVF0P4k4RA9PWnamazE6837DtjnEHN2J4LMU5Py+XbU2Vz8ojZDuKxLHCL9am NxOMbK1ID+vKn/zTqAQj8aCFa8IlMkBu3oBn5jLxx9v0uw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-il1-f180.google.com) smtp.remote-ip=209.85.166.180; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1603373493; bh=RRLJrs6IO1BcN/J5nCgVw5PEUkIfWsM9i/lbZ+IV2SA=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=OMwtULWPM9AEXTL4nh+zPZGLHspNIun1vNBzBt9wp8ciRRGGUXBe0IUdqos3B5mkXF+ZBFNyOe HgL7W9f5e9UBk79WxoLbAvfUdQctEJ/XHVLBmtNWTQkJX/nvX2xqIRdOa+ODbDX9Hl1cCDq0BW 7tMGe5Onkjf4tlCIlbwLPv4Ox0kxpdztmxmbBBvCxMaDkLoPPKEt8Y01ywmHW/TluqkRbj7oCP 3AAUazONrignCsakvp+nTqOJFit/s/h7W5M/orohqmCTHCMAdWcDgKavu6gePdzmXpz4Lm9Hpb Sss1782iGCCaGT96Fh9QdMs4RWOokh+5R7kYeRdzS6pG5A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=RRLJrs6IO1BcN/J5nCgVw5PEUkIfWsM9i/lbZ+IV2SA=; b=prbMBtBVrXneHKJtOlbontQScJ FeVXbqQQImUPpkp27H3RPIs1eYYrGY0O8/3XXGPzrxAXcJ1yBKzfwjiQGs7IRgv/NcEa4YcO/0u7p ugix9PUprxVW5BHVXHpEDu/ZHAhmHHywXxlXPx4ASgbTN+NwcIk7b0gZpwa5uCf68yyBO6C15fVtk hVgdZarMX/jd/Ere+8bEd4XaKNfUZTbFO42e78E3F5ngpL6LIDexLba/SaDxVUI8Fyfv9qGuPjVXq 0SlrG+ZynvYP/UbPJ7hNzaPoMThSkjjqNBnvoEpKWiAp1S9uugVgszVYCKUUDxwF0ojMsZbLfAbgn Nmi6u8Lw==; Received: from authenticated user by zero.zsh.org with local id 1kVagk-000EPh-Af; Thu, 22 Oct 2020 13:31:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-il1-f180.google.com) smtp.remote-ip=209.85.166.180; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-il1-f180.google.com ([209.85.166.180]:46184) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kVagS-000EHR-Ta; Thu, 22 Oct 2020 13:31:14 +0000 Received: by mail-il1-f180.google.com with SMTP id a20so1700056ilk.13 for ; Thu, 22 Oct 2020 06:31:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RRLJrs6IO1BcN/J5nCgVw5PEUkIfWsM9i/lbZ+IV2SA=; b=gnJ9RgWSxzAPHiu8rTNmhiNxgkVspqJb5PzBJSpNvjMtc7xviDITuh8qEZg27UqzMo nsgxjkbnTWtyW++v1or6C99A4OQSDZZzK9zUFitjajdCG/QvSDq8hK9jcvT7byn4lkel UMUS3BFfZBXVMiMerQNym0VSb8GONmuxhXNXxu4LFu2qp5tvzEj5IQLfnVSX64YkU9G2 JVwaePqxVUJFinD3mZt52oLVZuvqg4B94FMkSgyGt9rFmtlz01ufPTZqns5Wgr6eHQoP 2Ankf4x1NQPvvwbWR2Oj3YSS8xDGeuLPCm1zFgq6gNn+utw+zrPpwHy8iP9QXRGrgma5 vY/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RRLJrs6IO1BcN/J5nCgVw5PEUkIfWsM9i/lbZ+IV2SA=; b=qr/y1WdJsIkvDqxZ7ePEC9UDX+V0tvg6Q7sP8qfz0Aes9ZK8c2aBYHe1ApyR4TfbIZ FS+XBc7unvmedCAJROiJ+KrrGJGFIqlEFOhKMiwIXE83BHD5IfZpcb8aP9l36JQ57ezf ugJfmNSg7xX3SVD+l6Ds0x93DyKhFeX/O97YUheugDDXBPWWpOHaEK0qI2pg3uixccVv /keElP8Zj8uRODVpVNo1DBcgQzZ3HzPASK3ameScEKGmrgIfJ+moNe/1H5ERnOJn2SO8 2/d4mNJNyiduXfkTI/CLyUPek6jtXatybC66yhxZPUH23j5QqOT9QQyJq0QjZVHoxMwD qhYg== X-Gm-Message-State: AOAM532EzeXjvoM72eP/MH9K1miPSquUcTG+gttYaJpPTQJ1oH7VTuhX s5O8gmRdOzDWDrTk/XD4zSXgQQbvmVEtr+W0sn0Gc04ps18= X-Google-Smtp-Source: ABdhPJxgOjVCw7g0ynOM7ZUQng+6GxenBTUomXSeVwaByojlNBPPW9rKFxAGm8XRZrBZAAOmT/73djmIVzZkhYchcus= X-Received: by 2002:a92:da0e:: with SMTP id z14mr1803187ilm.151.1603373471237; Thu, 22 Oct 2020 06:31:11 -0700 (PDT) MIME-Version: 1.0 References: <20201009200737.GA78914@CptOrmolo.darkstar> <20201009205357.GA6449@CptOrmolo.darkstar> In-Reply-To: From: Roman Perepelitsa Date: Thu, 22 Oct 2020 15:30:59 +0200 Message-ID: Subject: Re: [patch] Avoid race in zf_mkdir To: Bart Schaefer Cc: Zsh hackers list Content-Type: multipart/mixed; boundary="00000000000032267205b2427a6a" X-Seq: 47476 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: --00000000000032267205b2427a6a Content-Type: text/plain; charset="UTF-8" On Thu, Oct 15, 2020 at 5:36 PM Roman Perepelitsa wrote: > > On Thu, Oct 15, 2020 at 5:29 PM Bart Schaefer wrote: > > > > - I'm paranoid about tests like "while (n--)", I prefer "while (n-- > 0)". > > Changed. (Not publishing the new patch yet. Will do so once this > discussion concludes.) Here's the fixed version. Will commit soon. Roman. --00000000000032267205b2427a6a Content-Type: text/plain; charset="US-ASCII"; name="mkdir-patch-v3.txt" Content-Disposition: attachment; filename="mkdir-patch-v3.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgkv5nhl0 ZGlmZiAtLWdpdCBhL1NyYy9Nb2R1bGVzL2ZpbGVzLmMgYi9TcmMvTW9kdWxlcy9maWxlcy5jCmlu ZGV4IDZkMjBlMzhhOC4uN2ViYWNiYTZjIDEwMDY0NAotLS0gYS9TcmMvTW9kdWxlcy9maWxlcy5j CisrKyBiL1NyYy9Nb2R1bGVzL2ZpbGVzLmMKQEAgLTEyMiwxOSArMTIyLDI5IEBAIGRvbWtkaXIo Y2hhciAqbmFtLCBjaGFyICpwYXRoLCBtb2RlX3QgbW9kZSwgaW50IHApCiB7CiAgICAgaW50IGVy cjsKICAgICBtb2RlX3Qgb3VtYXNrOworICAgIHN0cnVjdCBzdGF0IHN0OworICAgIGludCBuID0g ODsKICAgICBjaGFyIGNvbnN0ICpycGF0aCA9IHVubWV0YShwYXRoKTsKIAotICAgIGlmKHApIHsK LQlzdHJ1Y3Qgc3RhdCBzdDsKLQotCWlmKCFzdGF0KHJwYXRoLCAmc3QpICYmIFNfSVNESVIoc3Qu c3RfbW9kZSkpCisgICAgd2hpbGUobi0tID4gMCkgeworCW91bWFzayA9IHVtYXNrKDApOworCWVy ciA9IG1rZGlyKHJwYXRoLCBtb2RlKSA/IGVycm5vIDogMDsKKwl1bWFzayhvdW1hc2spOworCWlm ICghZXJyKQorCSAgICByZXR1cm4gMDsKKwlpZighcCB8fCBlcnIgIT0gRUVYSVNUKQorCSAgICBi cmVhazsKKwlpZihzdGF0KHJwYXRoLCAmc3QpKSB7CisJICAgIGlmKGVycm5vID09IEVOT0VOVCkK KwkJY29udGludWU7CisJICAgIGVyciA9IGVycm5vOworCSAgICBicmVhazsKKwl9CisJaWYoU19J U0RJUihzdC5zdF9tb2RlKSkKIAkgICAgcmV0dXJuIDA7CisJYnJlYWs7CiAgICAgfQotICAgIG91 bWFzayA9IHVtYXNrKDApOwotICAgIGVyciA9IG1rZGlyKHJwYXRoLCBtb2RlKSA/IGVycm5vIDog MDsKLSAgICB1bWFzayhvdW1hc2spOwotICAgIGlmKCFlcnIpCi0JcmV0dXJuIDA7CisKICAgICB6 d2Fybm5hbShuYW0sICJjYW5ub3QgbWFrZSBkaXJlY3RvcnkgYCVzJzogJWUiLCBwYXRoLCBlcnIp OwogICAgIHJldHVybiAxOwogfQo= --00000000000032267205b2427a6a--