Re: PATCH: draw prompt on the correct line after window change

[Roman Perepelitsa <roman.perepelitsa@gmail.com>]

On Mon, Jul 15, 2019 at 11:24 PM Bart Schaefer
<schaefer@brasslantern.com> wrote:
>
> On Mon, Jul 15, 2019 at 10:21 AM Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> >
> > I've tested this code only on GNOME Terminal. Before I go testing on a
> > dozen different terminals I'd like to get some feedback. Anything I'm
> > missing? Anything tricky to look out for?
>
> The most significant problem with window resizing is not the terminal
> itself, but window/session managers that try to do "live update" of
> the window contents as the cursor is rapidly dragged around.  These
> tend to send a stream of WINCH signals which we have had to do various
> tricks to manage.  I would be concerned that attempting to write a
> control sequence to the terminal and read back the response in the
> midst of a flood of such signals would fail as often as it succeeds.
> If this is already limited/controlled by the mechanisms in place,
> great.

This patch isn't only doing writes to the terminal without any reads.
Whenever ZLE prints prompt, it issues TCSAVECURSOR which instruct the
terminal to save the position of the cursor in a special stash. When
window resizes, ZLE issues TCRESTRCURSOR to tell the terminal to move
the cursor to the previously saved position. The nice thing about
these commands is that the stashed cursor position will still be in
the right place after the terminal has reflowed text.

I _think_ this shouldn't window/session managers but I'll definitely
need to test it first. Do you have suggestions on what I should test
with? I have a battery of 13 terminals and 4 operating systems that I
use for testing changes but I'm not sure any of my configurations
qualify as high-risk for this patch.

> > The patch is attached to the email. You can also see it in
> > https://github.com/zsh-users/zsh/compare/master...romkatv:fix-winchanged.
>
> Thanks for the link, it's the only way I was able to see this on a
> mobile device.  Please inline patches, or attach them as text/plain
> (not text/x-something), without base64 encoding if possible.

Sorry about that. I don't think it's possible to specify content type
for attachments in GMail. Perhaps if I attach *.txt instead of *.patch
it'll become "text/plain"? I'll try it next time.

Roman.