zsh-workers
 help / color / mirror / code / Atom feed
From: Roman Perepelitsa <roman.perepelitsa@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix)
Date: Sun, 19 May 2019 23:07:53 +0200	[thread overview]
Message-ID: <CAN=4vMr46PsxS-+gDSBU=mGeGMLtWsRxTp9wMAB87qL12serNQ@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7buWyujVw-PqWuB40ywQ5BrePrTYWdkkB1Q6RSwuVeG8A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1149 bytes --]

On Sun, May 19, 2019 at 10:12 PM Bart Schaefer <schaefer@brasslantern.com>
wrote:

> On Sun, May 19, 2019 at 11:51 AM Roman Perepelitsa
> <roman.perepelitsa@gmail.com> wrote:
> >
> > I've tested my patch on two more terminals: Dumb Linux terminal
> (TERM=linux) and Command Prompt with WSL. On both of them ZSH misbehaves
> without my patch and works correctly with it.
>
> This is promising and the patch looks plausible, but I must ask:  Have
> you tested the case where the rprompt is printed on the final line of
> the visible screen?
>

I went back and retested. Yes, it works correctly when rprompt is printed
on the final line of the visible screen.

I've now tested on two more terminals: KDE Konsole and Alacritty. This is
the full list of terminals I've tested so far, all reasonably new versions:

- GNOME Terminal.
- MacOS Terminal.
- Dumb Linux Terminal.
- Windows Command Prompt (WSL).
- Konsole.
- Alacritty.

On all of them when RPROMPT is non-empty and ZLE_RPROMPT_INDENT=0 ZSH
behaves incorrectly without the patch, and correctly with the patch (
https://github.com/zsh-users/zsh/compare/master...romkatv:rprompt-indent2).

Roman.

  reply	other threads:[~2019-05-19 21:08 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-19 15:38 Roman Perepelitsa
2019-05-19 15:41 ` Roman Perepelitsa
2019-05-19 17:04 ` Bart Schaefer
2019-05-19 17:34   ` Roman Perepelitsa
2019-05-19 18:09     ` Roman Perepelitsa
2019-05-19 18:51       ` Roman Perepelitsa
2019-05-19 20:12         ` Bart Schaefer
2019-05-19 21:07           ` Roman Perepelitsa [this message]
2019-05-20  8:21             ` Yannic Schröder
2019-05-20  8:36               ` Roman Perepelitsa
2019-05-20 10:21                 ` Charles Blake
2019-05-20 10:46                   ` Roman Perepelitsa
2019-05-20 11:06                     ` Daniel Shahaf
2019-05-20 11:07                     ` Charles Blake
2019-05-20 11:11                       ` Peter Stephenson
2019-05-20 11:32                       ` Roman Perepelitsa
2019-05-20 12:41                     ` Charles Blake
2019-05-20 13:16                       ` Roman Perepelitsa
     [not found]                         ` <CAKiz1a-nOkAe42JoxFRgMJ+LXZ3fgMxqgwNZOW+2Y45oqzu8hA@mail.gmail.com>
2019-05-20 13:55                           ` Roman Perepelitsa
2019-05-23  5:48                             ` Roman Perepelitsa
2019-05-23 21:36                               ` Daniel Shahaf
2019-05-23 22:52                                 ` Roman Perepelitsa
2019-05-24 12:18                                   ` Daniel Shahaf
2019-05-27 15:36                                     ` Roman Perepelitsa
2019-05-27 21:51                                       ` Peter Stephenson
2019-05-28  8:44                                         ` Peter Stephenson
2019-05-28  8:46                                           ` Roman Perepelitsa
2019-05-28 14:26                                         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN=4vMr46PsxS-+gDSBU=mGeGMLtWsRxTp9wMAB87qL12serNQ@mail.gmail.com' \
    --to=roman.perepelitsa@gmail.com \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).