zsh-workers
 help / color / Atom feed
From: Rocky Bernstein <rocky.bernstein@gmail.com>
To: Stephane Chazelas <stephane.chazelas@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Feature Request: Allow skipping zsh statement on return from trap DEBUG
Date: Fri, 25 Oct 2019 21:37:25 -0400
Message-ID: <CANCp2gaxpuHP=3mG1giHdG0ei3=NxQ-FrGg+y-yt9EMZeeANvQ@mail.gmail.com> (raw)
In-Reply-To: <20191025175206.7lpnhzcenlwqs4el@chaz.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]

My apologies for not realizing this. I _did_ look at the trap DEBUG command
and even noticed the DEBUG_BEFORE_CMD, but I guess I didn't read carefully
enough to notice ERR_EXIT.

At any rate with commit
https://github.com/rocky/zshdb/commit/d3f00505f58ddb3d781a2140d92baa19dcc0a200
(and the one before that) this is now all in the debugger, and it works
great!

When I get a chance, a new release, 1.1.0, will go out soon with this in
it.

Thanks, yet again, to Stephane for helping me out here.

-- 
I make mistakes, that's why I work on debuggers.


On Fri, Oct 25, 2019 at 1:52 PM Stephane Chazelas <
stephane.chazelas@gmail.com> wrote:

> 2019-10-24 16:17:27 -0400, Rocky Bernstein:
> > A while ago I wrote a debugger for zsh called zshdb
> > <https://zshdb.readthedocs.io/en/latest/>. See also
> > https://repology.org/project/zshdb/versions .
> >
> > A feature that is missing in the debugger and that is available in the
> > corresponding debugger for bash, bashdb,  is the skip command.
> >
> > This command skips over the upcoming statement to be executed. The way
> this
> > works in bashdb, is that if the debug hook returns with a nonzero value.
> > The way BASH works is that if the trap DEBUG hook returns a nonzero
> value,
> > BASH skips statement to be run.
> >
> > Thoughts about extening zsh so that it too will skip the upcoming
> statement
> > if the zsh trap DEBUG hook return a non-zero value.  Or more generally
> some
> > means by which a DEBUG hook can indicate to zsh to skip the upcoming
> > statement?
> [...]
>
> See info zsh trap:
>
> }  If SIG is DEBUG then ARG will be executed before each command if
> }  the option DEBUG_BEFORE_CMD is set (as it is by default), else
> }  after each command.  Here, a 'command' is what is described as a
> }  'sublist' in the shell grammar, see *note Simple Commands &
> }  Pipelines::.  If DEBUG_BEFORE_CMD is set various additional
> }  features are available.  First, it is possible to skip the next
> }  command by setting the option ERR_EXIT; see the description of the
> }  ERR_EXIT option in *note Description of Options::.  Also, the shell
> }  parameter ZSH_DEBUG_CMD is set to the string corresponding to the
> }  command to be executed following the trap.  Note that this string
> }  is reconstructed from the internal format and may not be formatted
> }  the same way as the original text.  The parameter is unset after
> }  the trap is executed.
>
> Was added in 2008: https://www.zsh.org/mla/workers/2008/msg01075.html
>
> You participated in that discussion, sounds likely you actually
> requested the feature then.
>
> TRAPDEBUG() {
>   echo "$ZSH_DEBUG_CMD"
>   [[ $ZSH_DEBUG_CMD = *x* ]] && set -o errexit
> }
> echo x
> echo y
>
>
> gives:
>
> echo x
> echo y
> y
>
> --
> Stephane
>

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 20:17 Rocky Bernstein
2019-10-25 17:52 ` Stephane Chazelas
2019-10-26  1:37   ` Rocky Bernstein [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANCp2gaxpuHP=3mG1giHdG0ei3=NxQ-FrGg+y-yt9EMZeeANvQ@mail.gmail.com' \
    --to=rocky.bernstein@gmail.com \
    --cc=stephane.chazelas@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git