From: Shlomi Fish <shlomif@gmail.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: zsh-workers@zsh.org
Subject: Re: "rpmbuild -tb [tab]" or "rpmbuild -ta [tab]" get stuck / do not complete even if there are tarballs in ./*
Date: Wed, 19 Aug 2020 10:44:27 +0300 [thread overview]
Message-ID: <CANy4znUdupDjdig3ZwzVjpKx2DQi9Jnf8Qz9z-yki4bLEPhHoQ@mail.gmail.com> (raw)
In-Reply-To: <20200818134648.40bb72c2@tarpaulin.shahaf.local2>
[-- Attachment #1: Type: text/plain, Size: 1542 bytes --]
Hi Daniel!
Thanks for the quick response.
On Tue, Aug 18, 2020 at 4:46 PM Daniel Shahaf <d.s@daniel.shahaf.name>
wrote:
> Shlomi Fish wrote on Tue, 18 Aug 2020 16:12 +0300:
> > sorry for the late reply.
> >
>
> No worries; it was timely.
>
> > On Sun, Aug 16, 2020 at 5:09 PM Daniel Shahaf <d.s@daniel.shahaf.name>
> > wrote:
> >
> > > [[[
> > > diff --git a/Completion/Redhat/Command/_rpm
> > > b/Completion/Redhat/Command/_rpm
> > > index e3469245f..85292fa78 100644
> > > --- a/Completion/Redhat/Command/_rpm
> > > +++ b/Completion/Redhat/Command/_rpm
> > > @@ -282,7 +282,7 @@ _rpm () {
> > > build_r) tmp=( '*:source package:_files -g "*.(#i)src.rpm(-.)"' )
> ;|
> > > build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;|
> > > build_?)
> > > - _arguments -s -C $buildopts $commonopts $pathopts \
> > > + _arguments -s -C $buildopts $commonopts $pathopts "${tmp[@]}" \
> > > ;;
> > > checksig)
> > > _arguments -s -C \!-K \
> > > ]]]
> > >
> > >
> > I applied the patch to "fedpkg clone --anonymous zsh" and rebuilt, and it
> > seems to have fixed the issue. Thanks!
> >
>
> You're welcome. Pushed.
>
> The regression seems to have been introduced by the previous commit
> (44788, aka zsh-5.7.1-135-g2c0387305). I didn't review that commit for
> additional instances of this issue.
>
Thanks!
> Cheers,
>
> Daniel
>
--
Shlomi Fish https://www.shlomifish.org/
Buddha has the Chuck Norris nature.
Please reply to list if it's a mailing list post - http://shlom.in/reply .
[-- Attachment #2: Type: text/html, Size: 2824 bytes --]
prev parent reply other threads:[~2020-08-19 7:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 13:57 Shlomi Fish
2020-08-16 14:09 ` Daniel Shahaf
2020-08-18 13:12 ` Shlomi Fish
2020-08-18 13:46 ` Daniel Shahaf
2020-08-19 7:44 ` Shlomi Fish [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANy4znUdupDjdig3ZwzVjpKx2DQi9Jnf8Qz9z-yki4bLEPhHoQ@mail.gmail.com \
--to=shlomif@gmail.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).