zsh-workers
 help / color / mirror / code / Atom feed
From: jsks <js.shirin@gmail.com>
To: zsh-workers@zsh.org
Subject: err_exit/err_return regression
Date: Thu, 9 Jul 2015 13:33:09 +0200	[thread overview]
Message-ID: <CAOCbtnsTgLStbfjKF9AfF61z_WWniKOKurSEdB1iy5cHjbbvrw@mail.gmail.com> (raw)

Since patch 34065, with either err_exit or err_return set, zsh does
not exit/return given a nonzero exist status of a command following
'else'.

Example:

$ setopt err_return; if false; then :; else false; echo foo; fi
foo

However, command lists following 'if' and 'elif' work as expected.

$ setopt err_return; if true; then false; echo foo; else :; fi

In the execif function of loop.c, when executing the command list of
an else statement, given that lastval from the evaluation of the
previous if/elif is nonzero, the flag noerrexit is never reset to its
original value.

noerrexit = olderrexit ? olderrexit : lastval ? 2 : 0;

Unless I misunderstood the intended behaviour, didn't know how to
handle this with regards to the patch fixing for example return values
and for loops, so simply reporting.

/jsks


             reply	other threads:[~2015-07-09 11:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-09 11:33 jsks [this message]
2015-07-09 13:38 ` Peter Stephenson
2015-09-29 15:43   ` Joshua Krusell
2015-09-29 18:54     ` Peter Stephenson
2015-09-29 20:52       ` Joshua Krusell
2015-09-30  1:09         ` Bart Schaefer
2015-10-01 20:32           ` Joshua Krusell
2015-10-04  0:26             ` Bart Schaefer
2015-10-04  2:58               ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOCbtnsTgLStbfjKF9AfF61z_WWniKOKurSEdB1iy5cHjbbvrw@mail.gmail.com \
    --to=js.shirin@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).