From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-35355-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 26831 invoked by alias); 1 Jun 2015 22:13:58 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 35355
Received: (qmail 14171 invoked from network); 1 Jun 2015 22:13:54 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,
	RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc:content-type;
        bh=fYp2YxtoXY6a4RBMmr8Us2ybgt9rYTGwj2PQ4YTnz6g=;
        b=IoUtmFW0eGvs+Jh6G6LamtGjH2L2hi9zTaYwSrc0NeN2oVosRgtolHIfkXMwIOUNNd
         U+vJjvcIEm7gcJuhBqWU8OeT42ssNWLzQA8zwPG8UGkcmicTnmZPkCaM/1Jn9iXObMjE
         d/H29XuJHgCPTzmV71LemRfzSJK5q1Ne0T385Vwf9m/OdQcYo5JAqdjciCRTsF5eVgFw
         9JM6qXu2Ks9XDXH/r1Jh1bM4JEfyPUOdZ6KDhfKqD5M8stqLbrKClsLD6ObjJD+23tTy
         3RH+9Fv5sjTF2w34aBJ4yFT8ueKHcS4WqqUIOP8lUHoE7fmJiriJwsaGV5/ka/9GMufi
         TttA==
X-Received: by 10.112.140.9 with SMTP id rc9mr10209013lbb.14.1433196830576;
 Mon, 01 Jun 2015 15:13:50 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <150531171724.ZM29828@torch.brasslantern.com>
References: <20150531192334.26a88ef9@ntlworld.com> <150531171724.ZM29828@torch.brasslantern.com>
From: Baptiste Daroussin <baptiste.daroussin@gmail.com>
Date: Tue, 2 Jun 2015 00:13:30 +0200
Message-ID: <CAPKC6oJ0fOEeg1--qpufEYQoxTeUnD8KDNSHV5Sfn7J4EtPYCw@mail.gmail.com>
Subject: Re: zsh 5.0.8 available (preliminary announcement)
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: text/plain; charset=UTF-8

2015-06-01 2:17 GMT+02:00 Bart Schaefer <schaefer@brasslantern.com>:
> On May 31,  7:23pm, Peter Stephenson wrote:
> }
> } Please could people have a quick check there's nothing major broken
> } before I announce it more widely.
>
> Passes "make check" on Ubuntu 12.04.5 and MacOS 10.9.5 (gnu tools).

On FreeBSD I have 5 tests failing (actually for a couple of release of
zsh) all related to zpty.

This time I found time to analyse the code.

It appears that freebsd has posix_openpt, but the code using that only
used if USE_DEV_PTMX is defined (which is not on FreeBSD)

Switching the #ifdef USE_DEV_PTMX line 157 to:

#if defined(HAVE_POSIX_OPENPT) || defined(USE_DEV_PTMX)


after doing that all tests passes.

regards,
Bapt