Re: zsh 5.0.8 available (preliminary announcement)

[Baptiste Daroussin <baptiste.daroussin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 887 bytes --]

2015-06-02 0:13 GMT+02:00 Baptiste Daroussin <baptiste.daroussin@gmail.com>:
> 2015-06-01 2:17 GMT+02:00 Bart Schaefer <schaefer@brasslantern.com>:
>> On May 31,  7:23pm, Peter Stephenson wrote:
>> }
>> } Please could people have a quick check there's nothing major broken
>> } before I announce it more widely.
>>
>> Passes "make check" on Ubuntu 12.04.5 and MacOS 10.9.5 (gnu tools).
>
> On FreeBSD I have 5 tests failing (actually for a couple of release of
> zsh) all related to zpty.
>
> This time I found time to analyse the code.
>
> It appears that freebsd has posix_openpt, but the code using that only
> used if USE_DEV_PTMX is defined (which is not on FreeBSD)
>
> Switching the #ifdef USE_DEV_PTMX line 157 to:
>
> #if defined(HAVE_POSIX_OPENPT) || defined(USE_DEV_PTMX)
>
>
> after doing that all tests passes.
>
> regards,
> Bapt

Here is the patch for this

regards,
Bapt

[-- Attachment #2: 0001-Allow-to-use-the-get_pty-code-using-posix_openpt-on-.patch --]
[-- Type: text/x-patch, Size: 670 bytes --]

From aa2388c975b0e3741599f89358e5fa8e11f57e23 Mon Sep 17 00:00:00 2001
From: Baptiste Daroussin <bapt@FreeBSD.org>
Date: Tue, 2 Jun 2015 07:44:09 +0200
Subject: [PATCH] Allow to use the get_pty code using posix_openpt on systems
 without /dev/ptmx

---
 Src/Modules/zpty.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c
index 7b6130c..a77b0df 100644
--- a/Src/Modules/zpty.c
+++ b/Src/Modules/zpty.c
@@ -154,7 +154,7 @@ getptycmd(char *name)
     return NULL;
 }
 
-#ifdef USE_DEV_PTMX
+#if defined(USE_DEV_PTMX) || defined(HAVE_POSIX_OPENPT)
 
 #ifdef HAVE_SYS_STROPTS_H
 #include <sys/stropts.h>
-- 
2.4.2